ceph/qa/CMakeLists.txt

set(CEPH_BUILD_VIRTUALENV $ENV{TMPDIR})
if(NOT CEPH_BUILD_VIRTUALENV)
  set(CEPH_BUILD_VIRTUALENV ${CMAKE_BINARY_DIR})
endif()

if(WITH_TESTS)
  include(AddCephTest)
  add_tox_test(qa flake8-py2 flake8-py3)
endif()
qa: Enable flake8 tox and fix failures There were a couple of problems found by flake8 in the qa/ directory (most of them fixed now). Enabling flake8 during the usual check runs hopefully avoids adding new issues in the future. Signed-off-by: Thomas Bechtold <tbechtold@suse.com> 2019-12-09 15:17:23 +00:00			`set(CEPH_BUILD_VIRTUALENV $ENV{TMPDIR})`
			`if(NOT CEPH_BUILD_VIRTUALENV)`
			`set(CEPH_BUILD_VIRTUALENV ${CMAKE_BINARY_DIR})`
			`endif()`

			`if(WITH_TESTS)`
			`include(AddCephTest)`
qa: Run flake8 on python2 and python3 To be able to catch problems with python2 and python3, run flake8 with both versions. From the flake8 homepage: It is very important to install Flake8 on the correct version of Python for your needs. If you want Flake8 to properly parse new language features in Python 3.5 (for example), you need it to be installed on 3.5 for Flake8 to understand those features. In many ways, Flake8 is tied to the version of Python on which it runs. Also fix the problems with python3 on the way. Note: This requires now the six module for teuthology. But this is already an install_require in teuthology itself. Signed-off-by: Thomas Bechtold <tbechtold@suse.com> 2019-12-09 16:27:46 +00:00			`add_tox_test(qa flake8-py2 flake8-py3)`
qa: Enable flake8 tox and fix failures There were a couple of problems found by flake8 in the qa/ directory (most of them fixed now). Enabling flake8 during the usual check runs hopefully avoids adding new issues in the future. Signed-off-by: Thomas Bechtold <tbechtold@suse.com> 2019-12-09 15:17:23 +00:00			`endif()`