ceph/qa/CMakeLists.txt

set(CEPH_BUILD_VIRTUALENV $ENV{TMPDIR})
if(NOT CEPH_BUILD_VIRTUALENV)
  set(CEPH_BUILD_VIRTUALENV ${CMAKE_BINARY_DIR})
endif()

if(WITH_TESTS)
  include(AddCephTest)
  add_tox_test(qa TOX_ENVS py3 flake8 import-tasks)
endif()
qa: Enable flake8 tox and fix failures There were a couple of problems found by flake8 in the qa/ directory (most of them fixed now). Enabling flake8 during the usual check runs hopefully avoids adding new issues in the future. Signed-off-by: Thomas Bechtold <tbechtold@suse.com> 2019-12-09 15:17:23 +00:00			`set(CEPH_BUILD_VIRTUALENV $ENV{TMPDIR})`
			`if(NOT CEPH_BUILD_VIRTUALENV)`
			`set(CEPH_BUILD_VIRTUALENV ${CMAKE_BINARY_DIR})`
			`endif()`

			`if(WITH_TESTS)`
			`include(AddCephTest)`
cmake: do not always add py3 to TOX_ENVS before this change add_tox_test() always add "py3" to testenv, even the caller specifies TOX_ENVS explicitly. after this change, py3 is added only if the caller does not specify any TOX_ENVS. this change helps with the readability. Signed-off-by: Kefu Chai <kchai@redhat.com> 2020-10-09 05:55:39 +00:00			`add_tox_test(qa TOX_ENVS py3 flake8 import-tasks)`
qa: Enable flake8 tox and fix failures There were a couple of problems found by flake8 in the qa/ directory (most of them fixed now). Enabling flake8 during the usual check runs hopefully avoids adding new issues in the future. Signed-off-by: Thomas Bechtold <tbechtold@suse.com> 2019-12-09 15:17:23 +00:00			`endif()`