RepoMirrors
/
ceph
mirror of https://github.com/ceph/ceph
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
ceph/cmake/modules/FindSanitizers.cmake

89 lines
3.1 KiB
CMake
Raw Normal View History

cmake: extract sanitizer detection out also, we don't need to pass '-lasan' or '-ltsan' to linker. it's suggested to use the "-fsanitize=${sanitizer}". please note, this module is compatible with the one used in seastar on purpose, as seastar is included in ceph using add_subdirectory(), and it in turn add its own cmake modules directory using list(APPEND ...), so cmake/modules/FindSantitizers.cmake is prefered over src/seastar/cmake/FindSantitizers.cmake. Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-08-02 05:59:31 +00:00
if(NOT Sanitizers_FIND_COMPONENTS)
set(Sanitizers_FIND_COMPONENTS
cmake: should use lowercase for component name in FindSanitizers.cmake and s/undefined-behavior/undefined_behavior/ to be compatible with seastar Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-08-11 04:30:31 +00:00
address undefined_behavior)
cmake: extract sanitizer detection out also, we don't need to pass '-lasan' or '-ltsan' to linker. it's suggested to use the "-fsanitize=${sanitizer}". please note, this module is compatible with the one used in seastar on purpose, as seastar is included in ceph using add_subdirectory(), and it in turn add its own cmake modules directory using list(APPEND ...), so cmake/modules/FindSantitizers.cmake is prefered over src/seastar/cmake/FindSantitizers.cmake. Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-08-02 05:59:31 +00:00
endif()
if(HAVE_JEMALLOC)
message(WARNING "JeMalloc does not work well with sanitizers")
endif()
cmake: workaround of false alarm from ubsan to workaround a GCC bug, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88684 Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-03-21 10:51:48 +00:00
set(Sanitizers_COMPILE_OPTIONS)
cmake: extract sanitizer detection out also, we don't need to pass '-lasan' or '-ltsan' to linker. it's suggested to use the "-fsanitize=${sanitizer}". please note, this module is compatible with the one used in seastar on purpose, as seastar is included in ceph using add_subdirectory(), and it in turn add its own cmake modules directory using list(APPEND ...), so cmake/modules/FindSantitizers.cmake is prefered over src/seastar/cmake/FindSantitizers.cmake. Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-08-02 05:59:31 +00:00
foreach(component ${Sanitizers_FIND_COMPONENTS})
if(component STREQUAL "address")
cmake: workaround of false alarm from ubsan to workaround a GCC bug, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88684 Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-03-21 10:51:48 +00:00
set(Sanitizers_address_COMPILE_OPTIONS "-fsanitize=address")
cmake: extract sanitizer detection out also, we don't need to pass '-lasan' or '-ltsan' to linker. it's suggested to use the "-fsanitize=${sanitizer}". please note, this module is compatible with the one used in seastar on purpose, as seastar is included in ceph using add_subdirectory(), and it in turn add its own cmake modules directory using list(APPEND ...), so cmake/modules/FindSantitizers.cmake is prefered over src/seastar/cmake/FindSantitizers.cmake. Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-08-02 05:59:31 +00:00
elseif(component STREQUAL "leak")
cmake: workaround of false alarm from ubsan to workaround a GCC bug, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88684 Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-03-21 10:51:48 +00:00
set(Sanitizers_leak_COMPILE_OPTIONS "-fsanitize=leak")
cmake: extract sanitizer detection out also, we don't need to pass '-lasan' or '-ltsan' to linker. it's suggested to use the "-fsanitize=${sanitizer}". please note, this module is compatible with the one used in seastar on purpose, as seastar is included in ceph using add_subdirectory(), and it in turn add its own cmake modules directory using list(APPEND ...), so cmake/modules/FindSantitizers.cmake is prefered over src/seastar/cmake/FindSantitizers.cmake. Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-08-02 05:59:31 +00:00
elseif(component STREQUAL "thread")
cmake: quote a list using quotes otherwised we'd have ``` CMake Error at cmake/modules/FindSanitizers.cmake:17 (if): if given arguments: "address" "IN_LIST" "address" "thread" "undefined_behavior" "OR" "leak" "IN_LIST" "address" "thread" "undefined_behavior" Unknown arguments specified ``` when enabling TSan with WITH_TSAN=ON. Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2024-03-17 10:53:03 +00:00
if ("address" IN_LIST "${Sanitizers_FIND_COMPONENTS}" OR
"leak" IN_LIST "${Sanitizers_FIND_COMPONENTS}")
cmake: extract sanitizer detection out also, we don't need to pass '-lasan' or '-ltsan' to linker. it's suggested to use the "-fsanitize=${sanitizer}". please note, this module is compatible with the one used in seastar on purpose, as seastar is included in ceph using add_subdirectory(), and it in turn add its own cmake modules directory using list(APPEND ...), so cmake/modules/FindSantitizers.cmake is prefered over src/seastar/cmake/FindSantitizers.cmake. Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-08-02 05:59:31 +00:00
message(SEND_ERROR "Cannot combine -fsanitize-leak w/ -fsanitize-thread")
elseif(NOT CMAKE_POSITION_INDEPENDENT_CODE)
message(SEND_ERROR "TSan requires all code to be position independent")
endif()
cmake: fix libtsan detection This variable is case-sensitive. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2019-09-30 17:54:13 +00:00
set(Sanitizers_thread_COMPILE_OPTIONS "-fsanitize=thread")
cmake: should use lowercase for component name in FindSanitizers.cmake and s/undefined-behavior/undefined_behavior/ to be compatible with seastar Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-08-11 04:30:31 +00:00
elseif(component STREQUAL "undefined_behavior")
cmake: workaround of false alarm from ubsan to workaround a GCC bug, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88684 Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-03-21 10:51:48 +00:00
# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88684
set(Sanitizers_undefined_behavior_COMPILE_OPTIONS "-fsanitize=undefined;-fno-sanitize=vptr")
cmake: extract sanitizer detection out also, we don't need to pass '-lasan' or '-ltsan' to linker. it's suggested to use the "-fsanitize=${sanitizer}". please note, this module is compatible with the one used in seastar on purpose, as seastar is included in ceph using add_subdirectory(), and it in turn add its own cmake modules directory using list(APPEND ...), so cmake/modules/FindSantitizers.cmake is prefered over src/seastar/cmake/FindSantitizers.cmake. Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-08-02 05:59:31 +00:00
else()
message(SEND_ERROR "Unsupported sanitizer: ${component}")
endif()
cmake: workaround of false alarm from ubsan to workaround a GCC bug, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88684 Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-03-21 10:51:48 +00:00
list(APPEND Sanitizers_COMPILE_OPTIONS "${Sanitizers_${component}_COMPILE_OPTIONS}")
cmake: extract sanitizer detection out also, we don't need to pass '-lasan' or '-ltsan' to linker. it's suggested to use the "-fsanitize=${sanitizer}". please note, this module is compatible with the one used in seastar on purpose, as seastar is included in ceph using add_subdirectory(), and it in turn add its own cmake modules directory using list(APPEND ...), so cmake/modules/FindSantitizers.cmake is prefered over src/seastar/cmake/FindSantitizers.cmake. Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-08-02 05:59:31 +00:00
endforeach()
cmake,ceph.in: preload libasan if WITH_ASAN we need to preload libasan.so as the python exectuable is not likely to be compiled with ASan enabled. see: https://github.com/google/sanitizers/wiki/AddressSanitizerAsDso#asan-and-ld_preload just to ease the use of ASan, for fine-tuned behaviour, use `ASAN_OPTIONS`. Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-10-22 06:06:38 +00:00
if(Sanitizers_address_COMPILE_OPTIONS OR Sanitizers_leak_COMPILE_OPTIONS)
# ASAN_LIBRARY will be read by ceph.in to preload the asan library
find_library(ASAN_LIBRARY
NAMES
cmake: update FindSanitizers for new libasan versions Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-03-05 02:10:29 +00:00
libasan.so.10
libasan.so.9
libasan.so.8
libasan.so.7
cmake/modules/FindSanitizers: prefer libasan.6 libasan.6 is shipped as part of GCC-11, so prefer it over older versions Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-05-24 08:18:27 +00:00
libasan.so.6
cmake,ceph.in: preload libasan if WITH_ASAN we need to preload libasan.so as the python exectuable is not likely to be compiled with ASan enabled. see: https://github.com/google/sanitizers/wiki/AddressSanitizerAsDso#asan-and-ld_preload just to ease the use of ASan, for fine-tuned behaviour, use `ASAN_OPTIONS`. Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-10-22 06:06:38 +00:00
libasan.so.5
libasan.so.4
libasan.so.3)
endif()
cmake: workaround of false alarm from ubsan to workaround a GCC bug, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88684 Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-03-21 10:51:48 +00:00
if(Sanitizers_COMPILE_OPTIONS)
list(APPEND Sanitizers_COMPILE_OPTIONS
"-fno-omit-frame-pointer")
cmake: extract sanitizer detection out also, we don't need to pass '-lasan' or '-ltsan' to linker. it's suggested to use the "-fsanitize=${sanitizer}". please note, this module is compatible with the one used in seastar on purpose, as seastar is included in ceph using add_subdirectory(), and it in turn add its own cmake modules directory using list(APPEND ...), so cmake/modules/FindSantitizers.cmake is prefered over src/seastar/cmake/FindSantitizers.cmake. Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-08-02 05:59:31 +00:00
endif()
include(CheckCXXSourceCompiles)
cmake: expose Sanitizers_COMPILE_OPTIONS as a list * cmake/modules/FindSanitizers.cmake: do not pollute CMAKE_REQUIRED_FLAGS * cmake/modules/FindSanitizers.cmake: expose Sanitizers_COMPILE_OPTIONS as a list * CMakeLists.txt: append Sanitizers_COMPILE_OPTIONS to *_LINKER_FLAGS after replacing ";" with " " in it. Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-08-31 08:09:21 +00:00
include(CMakePushCheckState)
cmake_push_check_state()
string (REPLACE ";" " " CMAKE_REQUIRED_FLAGS "${Sanitizers_COMPILE_OPTIONS}")
cmake: extract sanitizer detection out also, we don't need to pass '-lasan' or '-ltsan' to linker. it's suggested to use the "-fsanitize=${sanitizer}". please note, this module is compatible with the one used in seastar on purpose, as seastar is included in ceph using add_subdirectory(), and it in turn add its own cmake modules directory using list(APPEND ...), so cmake/modules/FindSantitizers.cmake is prefered over src/seastar/cmake/FindSantitizers.cmake. Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-08-02 05:59:31 +00:00
set(CMAKE_REQUIRED_LIBRARIES ${Sanitizers_COMPILE_OPTIONS})
check_cxx_source_compiles("int main() {}"
Sanitizers_ARE_SUPPORTED)
cmake/.../FindSanitizers: add check for Sanitizers_FIBER_SUPPPORT With newer clang and gcc versions (observed on clang-17.0.6 as well as gcc 12/13), asan is throwing stack-use-after-return during OSD startup related to usage of seastar::async, which relies on swapcontext internally. seastar/src/core/thread.cc supports asan's hooks, but only if SEASTAR_HAVE_ASAN_FIBER_SUPPORT is set. seastar's CMakeList.txt sets it based on Sanitizers_FIBER_SUPPORT, which probably should be set by the module at src/seastar/cmake/FindSanitizers.cmake, but that module doesn't seem to be actually invoked anywhere. Ceph's version of that module (cmake/modules/FindSanitizers.cmake) does not set Sanitizers_FIBER_SUPPORT. This commit adds that check as well as the related code snippet. Fixes: https://tracker.ceph.com/issues/64512 Signed-off-by: Samuel Just <sjust@redhat.com>
2024-02-20 23:56:26 +00:00
file (READ ${CMAKE_CURRENT_LIST_DIR}/code_tests/Sanitizers_fiber_test.cc _sanitizers_fiber_test_code)
check_cxx_source_compiles ("${_sanitizers_fiber_test_code}" Sanitizers_FIBER_SUPPORT)
cmake: expose Sanitizers_COMPILE_OPTIONS as a list * cmake/modules/FindSanitizers.cmake: do not pollute CMAKE_REQUIRED_FLAGS * cmake/modules/FindSanitizers.cmake: expose Sanitizers_COMPILE_OPTIONS as a list * CMakeLists.txt: append Sanitizers_COMPILE_OPTIONS to *_LINKER_FLAGS after replacing ";" with " " in it. Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-08-31 08:09:21 +00:00
cmake_pop_check_state()
cmake: extract sanitizer detection out also, we don't need to pass '-lasan' or '-ltsan' to linker. it's suggested to use the "-fsanitize=${sanitizer}". please note, this module is compatible with the one used in seastar on purpose, as seastar is included in ceph using add_subdirectory(), and it in turn add its own cmake modules directory using list(APPEND ...), so cmake/modules/FindSantitizers.cmake is prefered over src/seastar/cmake/FindSantitizers.cmake. Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-08-02 05:59:31 +00:00
include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(Sanitizers
REQUIRED_VARS
cmake: workaround of false alarm from ubsan to workaround a GCC bug, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88684 Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-03-21 10:51:48 +00:00
Sanitizers_COMPILE_OPTIONS
Sanitizers_ARE_SUPPORTED)
cmake: extract sanitizer detection out also, we don't need to pass '-lasan' or '-ltsan' to linker. it's suggested to use the "-fsanitize=${sanitizer}". please note, this module is compatible with the one used in seastar on purpose, as seastar is included in ceph using add_subdirectory(), and it in turn add its own cmake modules directory using list(APPEND ...), so cmake/modules/FindSantitizers.cmake is prefered over src/seastar/cmake/FindSantitizers.cmake. Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-08-02 05:59:31 +00:00
if(Sanitizers_FOUND)
if(NOT TARGET Sanitizers::Sanitizers)
add_library(Sanitizers::Sanitizers INTERFACE IMPORTED)
set_target_properties(Sanitizers::Sanitizers PROPERTIES
cmake: workaround of false alarm from ubsan to workaround a GCC bug, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88684 Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-03-21 10:51:48 +00:00
INTERFACE_COMPILE_OPTIONS "${Sanitizers_COMPILE_OPTIONS}"
INTERFACE_LINK_LIBRARIES "${Sanitizers_COMPILE_OPTIONS}")
cmake: extract sanitizer detection out also, we don't need to pass '-lasan' or '-ltsan' to linker. it's suggested to use the "-fsanitize=${sanitizer}". please note, this module is compatible with the one used in seastar on purpose, as seastar is included in ceph using add_subdirectory(), and it in turn add its own cmake modules directory using list(APPEND ...), so cmake/modules/FindSantitizers.cmake is prefered over src/seastar/cmake/FindSantitizers.cmake. Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-08-02 05:59:31 +00:00
endif()
foreach(component ${Sanitizers_FIND_COMPONENTS})
if(NOT TARGET Sanitizers::${component})
set(target Sanitizers::${component})
cmake: workaround of false alarm from ubsan to workaround a GCC bug, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88684 Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-03-21 10:51:48 +00:00
set(compile_option "${Sanitizers_${component}_COMPILE_OPTIONS}")
cmake: extract sanitizer detection out also, we don't need to pass '-lasan' or '-ltsan' to linker. it's suggested to use the "-fsanitize=${sanitizer}". please note, this module is compatible with the one used in seastar on purpose, as seastar is included in ceph using add_subdirectory(), and it in turn add its own cmake modules directory using list(APPEND ...), so cmake/modules/FindSantitizers.cmake is prefered over src/seastar/cmake/FindSantitizers.cmake. Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-08-02 05:59:31 +00:00
add_library(${target} INTERFACE IMPORTED)
set_target_properties(${target} PROPERTIES
cmake: workaround of false alarm from ubsan to workaround a GCC bug, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88684 Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-03-21 10:51:48 +00:00
INTERFACE_COMPILE_OPTIONS "${compile_option}"
INTERFACE_LINK_LIBRARIES "${compile_option}")
cmake: extract sanitizer detection out also, we don't need to pass '-lasan' or '-ltsan' to linker. it's suggested to use the "-fsanitize=${sanitizer}". please note, this module is compatible with the one used in seastar on purpose, as seastar is included in ceph using add_subdirectory(), and it in turn add its own cmake modules directory using list(APPEND ...), so cmake/modules/FindSantitizers.cmake is prefered over src/seastar/cmake/FindSantitizers.cmake. Signed-off-by: Kefu Chai <kchai@redhat.com>
2018-08-02 05:59:31 +00:00
endif()
endforeach()
endif()