RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2024-12-12 06:28:31 +00:00
Code Issues Packages Projects Releases Wiki Activity
3b10d16235
ceph/cmake/modules/Distutils.cmake

96 lines
4.0 KiB
CMake
Raw Normal View History

cmake: install ceph-disk to /usr/sbin * add keyword "INSTALL_SCRIPT" to distutils_install_module(), so we can override the install path of ceph-disk script. * refactor the Distutils.cmake module a little bit, the ${option} variable out lives the CODE snipplet. so we need to reset it at the beginning. Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-06-01 17:50:21 +00:00
include(CMakeParseArguments)
cmake: install ceph-{detect-init,disk} add a cmake module named Distutils.cmake for setting up python modules using setup.py. Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-05-28 07:44:36 +00:00
cmake: install ceph-disk to /usr/sbin * add keyword "INSTALL_SCRIPT" to distutils_install_module(), so we can override the install path of ceph-disk script. * refactor the Distutils.cmake module a little bit, the ${option} variable out lives the CODE snipplet. so we need to reset it at the beginning. Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-06-01 17:50:21 +00:00
function(distutils_install_module name)
cmake/Distutils.cmake: make pkg files optional, add bin Skip nonexistent 'expected' Python packaging files, and add bin/ as a possible file for symlinking during build (for Python projects with slightly different forms, currently ceph-volume) Signed-off-by: Dan Mick <dan.mick@redhat.com>
2017-07-20 20:54:37 +00:00
set(py_srcs setup.py README.rst requirements.txt test-requirements.txt bin ${name})
cmake: install ceph-{detect-init,disk} add a cmake module named Distutils.cmake for setting up python modules using setup.py. Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-05-28 07:44:36 +00:00
foreach(src ${py_srcs})
cmake/Distutils.cmake: make pkg files optional, add bin Skip nonexistent 'expected' Python packaging files, and add bin/ as a possible file for symlinking during build (for Python projects with slightly different forms, currently ceph-volume) Signed-off-by: Dan Mick <dan.mick@redhat.com>
2017-07-20 20:54:37 +00:00
if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/${src})
list(APPEND py_clone ${CMAKE_CURRENT_BINARY_DIR}/${src})
add_custom_command(
OUTPUT ${src}
DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${src}
COMMAND ${CMAKE_COMMAND} -E create_symlink ${CMAKE_CURRENT_SOURCE_DIR}/${src} ${src})
endif()
cmake: install ceph-{detect-init,disk} add a cmake module named Distutils.cmake for setting up python modules using setup.py. Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-05-28 07:44:36 +00:00
endforeach()
add_custom_target(${name}-clone ALL
DEPENDS ${py_clone})
cmake: install ceph-disk to /usr/sbin * add keyword "INSTALL_SCRIPT" to distutils_install_module(), so we can override the install path of ceph-disk script. * refactor the Distutils.cmake module a little bit, the ${option} variable out lives the CODE snipplet. so we need to reset it at the beginning. Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-06-01 17:50:21 +00:00
cmake_parse_arguments(DU "" INSTALL_SCRIPT "" ${ARGN})
install(CODE "
cmake: install python packages into $CMAKE_INSTALL_PREFIX * Distutils.cmake: set --prefix=${CMAKE_INSTALL_PREFIX} for python packages installed using setuptools. it was set to --prefix=/user only when $DESTDIR is set. so if user installs ceph using -DCMAKE_INSTALL_PREFIX, these python packages still go to /usr, which is unexpected. * ceph-disk/CMakeLists.txt: install script into ${CMAKE_INSTALL_SBINDIR} instead of /usr/sbin Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-07-04 03:10:49 +00:00
set(options --prefix=${CMAKE_INSTALL_PREFIX})
cmake: install ceph-disk to /usr/sbin * add keyword "INSTALL_SCRIPT" to distutils_install_module(), so we can override the install path of ceph-disk script. * refactor the Distutils.cmake module a little bit, the ${option} variable out lives the CODE snipplet. so we need to reset it at the beginning. Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-06-01 17:50:21 +00:00
if(DEFINED ENV{DESTDIR})
if(EXISTS /etc/debian_version)
list(APPEND options --install-layout=deb)
endif()
list(APPEND options --root=\$ENV{DESTDIR})
if(NOT \"${DU_INSTALL_SCRIPT}\" STREQUAL \"\")
list(APPEND options --install-script=${DU_INSTALL_SCRIPT})
endif()
endif()
execute_process(
cmake: Also build Python bindings for Python 3 Signed-off-by: Oleh Prypin <oleh@pryp.in>
2016-07-13 12:57:30 +00:00
COMMAND ${PYTHON${PYTHON_VERSION}_EXECUTABLE}
cmake: install ceph-disk to /usr/sbin * add keyword "INSTALL_SCRIPT" to distutils_install_module(), so we can override the install path of ceph-disk script. * refactor the Distutils.cmake module a little bit, the ${option} variable out lives the CODE snipplet. so we need to reset it at the beginning. Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-06-01 17:50:21 +00:00
setup.py install \${options}
WORKING_DIRECTORY \"${CMAKE_CURRENT_BINARY_DIR}\")")
cmake: install ceph-{detect-init,disk} add a cmake module named Distutils.cmake for setting up python modules using setup.py. Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-05-28 07:44:36 +00:00
endfunction(distutils_install_module)
cmake: install cython modules * fix CYTHON_ADD_MODULE() macro. because python_add_module() offered by FindPythonLibs.cmake creates a target with name of ${name}, which conflicts with existing targets like "rbd" or "rados". so we can not reuse the name in ${name}.pyx. and instead, we should specify the target name explicitly. * add distutils_install_cython_module() function to build and install cython modules. * we can split build and install of cython module, but the install phase always tries to build the module. so keep it this way. will look at it later on. * move the variables initializations into the Distutils.cmake module. Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-06-01 05:38:05 +00:00
function(distutils_add_cython_module name src)
get_property(compiler_launcher GLOBAL PROPERTY RULE_LAUNCH_COMPILE)
get_property(link_launcher GLOBAL PROPERTY RULE_LAUNCH_LINK)
set(PY_CC \"${compiler_launcher} ${CMAKE_C_COMPILER}\")
set(PY_CXX \"${compiler_launcher} ${CMAKE_CXX_COMPILER}\")
set(PY_LDSHARED \"${link_launcher} ${CMAKE_C_COMPILER} -shared\")
add_custom_target(${name} ALL
COMMAND
env
CC=${PY_CC}
CXX=${PY_CXX}
LDSHARED=${PY_LDSHARED}
cmake: Suppress warnings on Cython output They are automatically generated code and we don't really control it. Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2016-11-08 20:43:26 +00:00
OPT=\"-DNDEBUG -g -fwrapv -O2 -w\"
cmake: install cython modules * fix CYTHON_ADD_MODULE() macro. because python_add_module() offered by FindPythonLibs.cmake creates a target with name of ${name}, which conflicts with existing targets like "rbd" or "rados". so we can not reuse the name in ${name}.pyx. and instead, we should specify the target name explicitly. * add distutils_install_cython_module() function to build and install cython modules. * we can split build and install of cython module, but the install phase always tries to build the module. so keep it this way. will look at it later on. * move the variables initializations into the Distutils.cmake module. Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-06-01 05:38:05 +00:00
LDFLAGS=-L${CMAKE_LIBRARY_OUTPUT_DIRECTORY}
CYTHON_BUILD_DIR=${CMAKE_CURRENT_BINARY_DIR}
pybind: Add CMake support in rados Signed-off-by: Anirudha Bose <ani07nov@gmail.com>
2016-06-13 18:17:09 +00:00
CEPH_LIBDIR=${CMAKE_LIBRARY_OUTPUT_DIRECTORY}
cmake: Suppress warnings on Cython output They are automatically generated code and we don't really control it. Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2016-11-08 20:43:26 +00:00
CFLAGS=\"-iquote${CMAKE_SOURCE_DIR}/src/include -w\"
cmake: Also build Python bindings for Python 3 Signed-off-by: Oleh Prypin <oleh@pryp.in>
2016-07-13 12:57:30 +00:00
${PYTHON${PYTHON_VERSION}_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/setup.py
build --verbose --build-base ${CYTHON_MODULE_DIR}
--build-platlib ${CYTHON_MODULE_DIR}/lib.${PYTHON${PYTHON_VERSION}_VERSION_MAJOR}
cmake: install cython modules * fix CYTHON_ADD_MODULE() macro. because python_add_module() offered by FindPythonLibs.cmake creates a target with name of ${name}, which conflicts with existing targets like "rbd" or "rados". so we can not reuse the name in ${name}.pyx. and instead, we should specify the target name explicitly. * add distutils_install_cython_module() function to build and install cython modules. * we can split build and install of cython module, but the install phase always tries to build the module. so keep it this way. will look at it later on. * move the variables initializations into the Distutils.cmake module. Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-06-01 05:38:05 +00:00
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
DEPENDS ${src})
endfunction(distutils_add_cython_module)
function(distutils_install_cython_module name)
cmake: pass LDSHARED env var to distutils otherwise, the default gcc will be used, and the $CMAKE_C_COMPILER passed to the outer CMakeLists.txt won't kick in. moreover, if the building script (ceph.spec for instance) could set the $PATH, and expect that the CMakeLists.txt will use the toolchain executables in the $PATH to build Ceph, distutils will continue using the default $CC for linking the python bindings, on UNIX it will be gcc in the new shell's $PATH, because we are using `install(CODE "... execute_process( ...))` for installing the python bindings. apparently, this is not expected. because the new shell's $PATH is very likely different from the one changed by the building script. to address this, we should always specify the `$LDSHARED` env var explicitly. also, pass env vars using `ENV{}` instead of the `env` command to workaround the issue of https://cmake.org/pipermail/cmake/2015-December/062216.html, because it's not straightforward to set environment variables with spaces in the them using cmake. and because one cannot use add_custom_target() in the script mode of cmake. this leave me only limited options to fix this issue. Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-11-11 17:50:42 +00:00
get_property(compiler_launcher GLOBAL PROPERTY RULE_LAUNCH_COMPILE)
get_property(link_launcher GLOBAL PROPERTY RULE_LAUNCH_LINK)
set(PY_CC "${compiler_launcher} ${CMAKE_C_COMPILER}")
set(PY_LDSHARED "${link_launcher} ${CMAKE_C_COMPILER} -shared")
cmake: install cython modules * fix CYTHON_ADD_MODULE() macro. because python_add_module() offered by FindPythonLibs.cmake creates a target with name of ${name}, which conflicts with existing targets like "rbd" or "rados". so we can not reuse the name in ${name}.pyx. and instead, we should specify the target name explicitly. * add distutils_install_cython_module() function to build and install cython modules. * we can split build and install of cython module, but the install phase always tries to build the module. so keep it this way. will look at it later on. * move the variables initializations into the Distutils.cmake module. Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-06-01 05:38:05 +00:00
install(CODE "
cmake: pass LDSHARED env var to distutils otherwise, the default gcc will be used, and the $CMAKE_C_COMPILER passed to the outer CMakeLists.txt won't kick in. moreover, if the building script (ceph.spec for instance) could set the $PATH, and expect that the CMakeLists.txt will use the toolchain executables in the $PATH to build Ceph, distutils will continue using the default $CC for linking the python bindings, on UNIX it will be gcc in the new shell's $PATH, because we are using `install(CODE "... execute_process( ...))` for installing the python bindings. apparently, this is not expected. because the new shell's $PATH is very likely different from the one changed by the building script. to address this, we should always specify the `$LDSHARED` env var explicitly. also, pass env vars using `ENV{}` instead of the `env` command to workaround the issue of https://cmake.org/pipermail/cmake/2015-December/062216.html, because it's not straightforward to set environment variables with spaces in the them using cmake. and because one cannot use add_custom_target() in the script mode of cmake. this leave me only limited options to fix this issue. Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-11-11 17:50:42 +00:00
set(ENV{CC} \"${PY_CC}\")
set(ENV{LDSHARED} \"${PY_LDSHARED}\")
set(ENV{CPPFLAGS} \"-iquote${CMAKE_SOURCE_DIR}/src/include\")
set(ENV{LDFLAGS} \"-L${CMAKE_LIBRARY_OUTPUT_DIRECTORY}\")
set(ENV{CYTHON_BUILD_DIR} \"${CMAKE_CURRENT_BINARY_DIR}\")
set(ENV{CEPH_LIBDIR} \"${CMAKE_LIBRARY_OUTPUT_DIRECTORY}\")
cmake: refactor distutils_install_module to follow the pattern of distutils_install_cython_module Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-07-04 03:26:28 +00:00
set(options --prefix=${CMAKE_INSTALL_PREFIX})
cmake: install cython modules * fix CYTHON_ADD_MODULE() macro. because python_add_module() offered by FindPythonLibs.cmake creates a target with name of ${name}, which conflicts with existing targets like "rbd" or "rados". so we can not reuse the name in ${name}.pyx. and instead, we should specify the target name explicitly. * add distutils_install_cython_module() function to build and install cython modules. * we can split build and install of cython module, but the install phase always tries to build the module. so keep it this way. will look at it later on. * move the variables initializations into the Distutils.cmake module. Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-06-01 05:38:05 +00:00
if(DEFINED ENV{DESTDIR})
if(EXISTS /etc/debian_version)
cmake: refactor distutils_install_module to follow the pattern of distutils_install_cython_module Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-07-04 03:26:28 +00:00
list(APPEND options --install-layout=deb)
cmake: install cython modules * fix CYTHON_ADD_MODULE() macro. because python_add_module() offered by FindPythonLibs.cmake creates a target with name of ${name}, which conflicts with existing targets like "rbd" or "rados". so we can not reuse the name in ${name}.pyx. and instead, we should specify the target name explicitly. * add distutils_install_cython_module() function to build and install cython modules. * we can split build and install of cython module, but the install phase always tries to build the module. so keep it this way. will look at it later on. * move the variables initializations into the Distutils.cmake module. Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-06-01 05:38:05 +00:00
endif()
cmake: refactor distutils_install_module to follow the pattern of distutils_install_cython_module Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-07-04 03:26:28 +00:00
list(APPEND options --root=\$ENV{DESTDIR})
cmake: install cython modules * fix CYTHON_ADD_MODULE() macro. because python_add_module() offered by FindPythonLibs.cmake creates a target with name of ${name}, which conflicts with existing targets like "rbd" or "rados". so we can not reuse the name in ${name}.pyx. and instead, we should specify the target name explicitly. * add distutils_install_cython_module() function to build and install cython modules. * we can split build and install of cython module, but the install phase always tries to build the module. so keep it this way. will look at it later on. * move the variables initializations into the Distutils.cmake module. Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-06-01 05:38:05 +00:00
else()
cmake: refactor distutils_install_module to follow the pattern of distutils_install_cython_module Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-07-04 03:26:28 +00:00
list(APPEND options --root=/)
cmake: install cython modules * fix CYTHON_ADD_MODULE() macro. because python_add_module() offered by FindPythonLibs.cmake creates a target with name of ${name}, which conflicts with existing targets like "rbd" or "rados". so we can not reuse the name in ${name}.pyx. and instead, we should specify the target name explicitly. * add distutils_install_cython_module() function to build and install cython modules. * we can split build and install of cython module, but the install phase always tries to build the module. so keep it this way. will look at it later on. * move the variables initializations into the Distutils.cmake module. Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-06-01 05:38:05 +00:00
endif()
execute_process(
cmake: pass LDSHARED env var to distutils otherwise, the default gcc will be used, and the $CMAKE_C_COMPILER passed to the outer CMakeLists.txt won't kick in. moreover, if the building script (ceph.spec for instance) could set the $PATH, and expect that the CMakeLists.txt will use the toolchain executables in the $PATH to build Ceph, distutils will continue using the default $CC for linking the python bindings, on UNIX it will be gcc in the new shell's $PATH, because we are using `install(CODE "... execute_process( ...))` for installing the python bindings. apparently, this is not expected. because the new shell's $PATH is very likely different from the one changed by the building script. to address this, we should always specify the `$LDSHARED` env var explicitly. also, pass env vars using `ENV{}` instead of the `env` command to workaround the issue of https://cmake.org/pipermail/cmake/2015-December/062216.html, because it's not straightforward to set environment variables with spaces in the them using cmake. and because one cannot use add_custom_target() in the script mode of cmake. this leave me only limited options to fix this issue. Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-11-11 17:50:42 +00:00
COMMAND
cmake: Also build Python bindings for Python 3 Signed-off-by: Oleh Prypin <oleh@pryp.in>
2016-07-13 12:57:30 +00:00
${PYTHON${PYTHON_VERSION}_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/setup.py
build --verbose --build-base ${CYTHON_MODULE_DIR}
--build-platlib ${CYTHON_MODULE_DIR}/lib.${PYTHON${PYTHON_VERSION}_VERSION_MAJOR}
cmake: put cythonized .c files into ${CMAKE_CURRENT_BINARY_DIR} it was put into the directory where .pyx is located. it's not expected in an out-of-tree build. * {rados,rbd,cephfs}/setup.py: use build_ext from cython if possible, fallback to the one from setuptools or distutils * Distutils.cmake: pass --cython-c-in-temp --build-temp and --cython-include-dirs to "build_ext" command Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-07-09 04:58:33 +00:00
build_ext --cython-c-in-temp --build-temp ${CMAKE_CURRENT_BINARY_DIR} --cython-include-dirs ${PROJECT_SOURCE_DIR}/src/pybind/rados
cmake: creage egg_info files into build directory otherwise they will go to the source tree, and "git ls-files" will list them as untracked files, which annoy gitbuilder-ceph-tarball*-cmake gitbuilders. like + echo 'error: Added files:' error: Added files: + cat .git/added-files src/pybind/rados/rados.egg-info/PKG-INFO ... Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-07-08 06:57:41 +00:00
install \${options} --single-version-externally-managed --record /dev/null
egg_info --egg-base ${CMAKE_CURRENT_BINARY_DIR}
--verbose
cmake: install cython modules * fix CYTHON_ADD_MODULE() macro. because python_add_module() offered by FindPythonLibs.cmake creates a target with name of ${name}, which conflicts with existing targets like "rbd" or "rados". so we can not reuse the name in ${name}.pyx. and instead, we should specify the target name explicitly. * add distutils_install_cython_module() function to build and install cython modules. * we can split build and install of cython module, but the install phase always tries to build the module. so keep it this way. will look at it later on. * move the variables initializations into the Distutils.cmake module. Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-06-01 05:38:05 +00:00
WORKING_DIRECTORY \"${CMAKE_CURRENT_SOURCE_DIR}\"
RESULT_VARIABLE install_res)
if(NOT \"\${install_res}\" STREQUAL 0)
message(FATAL_ERROR \"Failed to build and install ${name} python module\")
endif()
")
endfunction(distutils_install_cython_module)
Reference in New Issue Copy Permalink