RepoMirrors
/
ceph
mirror of https://github.com/ceph/ceph
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
ceph/cmake/modules/BuildOpentelemetry.cmake

87 lines
3.9 KiB
CMake
Raw Permalink Normal View History

cmake: replace opentracing-cpp with opentelemetry-cpp we build and use targets needed for jaeger to work with opentelemetry referring: https://github.com/open-telemetry/opentelemetry-cpp/blob/main/examples/jaeger/CMakeLists.txt right now we need a patch for using thrift from distro packages, hence we are using GIT_FETCH based externalProject method, for development purpose, which will be replace by more reliable method in future. NOTE: phase 1, still needs to be tested. Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2021-10-20 08:02:51 +00:00
function(target_create _target _lib)
add_library(${_target} STATIC IMPORTED)
set_target_properties(
${_target} PROPERTIES IMPORTED_LOCATION
"${opentelemetry_BINARY_DIR}/${_lib}")
endfunction()
function(build_opentelemetry)
cmake: remove git fetch and use submodule for building opentelemetry lib We were using git fetch and an unofficial remote to fetch opentelemetry-cpp, as it needed additional patch to include boost headers, with the merge of open-telemetry/opentelemetry-cpp#1100 open-telemetry/opentelemetry-cpp#1020 we do not require to maintain our own patched version. Also, we were using git fetch as a temporary change, now that tracing is always on, it should be right time to adapt to using opentelemetry-cpp as a submodule. This removes compile time fetch for opentelemetry-cpp instead use official opentelemetry-cpp lib as a submodule. Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2022-06-18 10:40:58 +00:00
set(opentelemetry_SOURCE_DIR "${PROJECT_SOURCE_DIR}/src/jaegertracing/opentelemetry-cpp")
cmake: replace opentracing-cpp with opentelemetry-cpp we build and use targets needed for jaeger to work with opentelemetry referring: https://github.com/open-telemetry/opentelemetry-cpp/blob/main/examples/jaeger/CMakeLists.txt right now we need a patch for using thrift from distro packages, hence we are using GIT_FETCH based externalProject method, for development purpose, which will be replace by more reliable method in future. NOTE: phase 1, still needs to be tested. Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2021-10-20 08:02:51 +00:00
set(opentelemetry_BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/opentelemetry-cpp")
set(opentelemetry_cpp_targets opentelemetry_trace opentelemetry_exporter_jaeger_trace)
set(opentelemetry_CMAKE_ARGS -DCMAKE_POSITION_INDEPENDENT_CODE=ON
-DWITH_JAEGER=ON
-DBUILD_TESTING=OFF
cmake: change build type of opentelemtry to Release Signed-off-by: Omri Zeneva <ozeneva@redhat.com>
2022-02-13 18:55:11 +00:00
-DCMAKE_BUILD_TYPE=Release
cmake: use BOOST_ROOT if building with system boost Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2022-02-07 13:12:12 +00:00
-DWITH_EXAMPLES=OFF)
cmake: replace opentracing-cpp with opentelemetry-cpp we build and use targets needed for jaeger to work with opentelemetry referring: https://github.com/open-telemetry/opentelemetry-cpp/blob/main/examples/jaeger/CMakeLists.txt right now we need a patch for using thrift from distro packages, hence we are using GIT_FETCH based externalProject method, for development purpose, which will be replace by more reliable method in future. NOTE: phase 1, still needs to be tested. Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2021-10-20 08:02:51 +00:00
set(opentelemetry_libs
${opentelemetry_BINARY_DIR}/sdk/src/trace/libopentelemetry_trace.a
${opentelemetry_BINARY_DIR}/sdk/src/resource/libopentelemetry_resources.a
${opentelemetry_BINARY_DIR}/sdk/src/common/libopentelemetry_common.a
${opentelemetry_BINARY_DIR}/exporters/jaeger/libopentelemetry_exporter_jaeger_trace.a
cmake: remove git fetch and use submodule for building opentelemetry lib We were using git fetch and an unofficial remote to fetch opentelemetry-cpp, as it needed additional patch to include boost headers, with the merge of open-telemetry/opentelemetry-cpp#1100 open-telemetry/opentelemetry-cpp#1020 we do not require to maintain our own patched version. Also, we were using git fetch as a temporary change, now that tracing is always on, it should be right time to adapt to using opentelemetry-cpp as a submodule. This removes compile time fetch for opentelemetry-cpp instead use official opentelemetry-cpp lib as a submodule. Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2022-06-18 10:40:58 +00:00
${opentelemetry_BINARY_DIR}/ext/src/http/client/curl/libopentelemetry_http_client_curl.a
cmake: replace opentracing-cpp with opentelemetry-cpp we build and use targets needed for jaeger to work with opentelemetry referring: https://github.com/open-telemetry/opentelemetry-cpp/blob/main/examples/jaeger/CMakeLists.txt right now we need a patch for using thrift from distro packages, hence we are using GIT_FETCH based externalProject method, for development purpose, which will be replace by more reliable method in future. NOTE: phase 1, still needs to be tested. Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2021-10-20 08:02:51 +00:00
${CURL_LIBRARIES}
)
set(opentelemetry_include_dir ${opentelemetry_SOURCE_DIR}/api/include/
${opentelemetry_SOURCE_DIR}/exporters/jaeger/include/
${opentelemetry_SOURCE_DIR}/ext/include/
${opentelemetry_SOURCE_DIR}/sdk/include/)
# TODO: add target based propogation
set(opentelemetry_deps opentelemetry_trace opentelemetry_resources opentelemetry_common
opentelemetry_exporter_jaeger_trace http_client_curl
${CURL_LIBRARIES})
if(CMAKE_MAKE_PROGRAM MATCHES "make")
# try to inherit command line arguments passed by parent "make" job
set(make_cmd $(MAKE) ${opentelemetry_cpp_targets})
else()
set(make_cmd ${CMAKE_COMMAND} --build <BINARY_DIR> --target
${opentelemetry_cpp_targets})
endif()
cmake: use BOOST_ROOT if building with system boost Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2022-02-07 13:12:12 +00:00
if(WITH_SYSTEM_BOOST)
list(APPEND opentelemetry_CMAKE_ARGS -DBOOST_ROOT=${BOOST_ROOT})
else()
cmake: replace opentracing-cpp with opentelemetry-cpp we build and use targets needed for jaeger to work with opentelemetry referring: https://github.com/open-telemetry/opentelemetry-cpp/blob/main/examples/jaeger/CMakeLists.txt right now we need a patch for using thrift from distro packages, hence we are using GIT_FETCH based externalProject method, for development purpose, which will be replace by more reliable method in future. NOTE: phase 1, still needs to be tested. Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2021-10-20 08:02:51 +00:00
list(APPEND dependencies Boost)
cmake: use BOOST_ROOT if building with system boost Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2022-02-07 13:12:12 +00:00
list(APPEND opentelemetry_CMAKE_ARGS -DBoost_INCLUDE_DIR=${CMAKE_BINARY_DIR}/boost/include)
cmake: replace opentracing-cpp with opentelemetry-cpp we build and use targets needed for jaeger to work with opentelemetry referring: https://github.com/open-telemetry/opentelemetry-cpp/blob/main/examples/jaeger/CMakeLists.txt right now we need a patch for using thrift from distro packages, hence we are using GIT_FETCH based externalProject method, for development purpose, which will be replace by more reliable method in future. NOTE: phase 1, still needs to be tested. Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2021-10-20 08:02:51 +00:00
endif()
include(ExternalProject)
cmake: remove git fetch and use submodule for building opentelemetry lib We were using git fetch and an unofficial remote to fetch opentelemetry-cpp, as it needed additional patch to include boost headers, with the merge of open-telemetry/opentelemetry-cpp#1100 open-telemetry/opentelemetry-cpp#1020 we do not require to maintain our own patched version. Also, we were using git fetch as a temporary change, now that tracing is always on, it should be right time to adapt to using opentelemetry-cpp as a submodule. This removes compile time fetch for opentelemetry-cpp instead use official opentelemetry-cpp lib as a submodule. Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2022-06-18 10:40:58 +00:00
ExternalProject_Add(opentelemetry-cpp
cmake: replace opentracing-cpp with opentelemetry-cpp we build and use targets needed for jaeger to work with opentelemetry referring: https://github.com/open-telemetry/opentelemetry-cpp/blob/main/examples/jaeger/CMakeLists.txt right now we need a patch for using thrift from distro packages, hence we are using GIT_FETCH based externalProject method, for development purpose, which will be replace by more reliable method in future. NOTE: phase 1, still needs to be tested. Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2021-10-20 08:02:51 +00:00
SOURCE_DIR ${opentelemetry_SOURCE_DIR}
PREFIX "opentelemetry-cpp"
CMAKE_ARGS ${opentelemetry_CMAKE_ARGS}
BUILD_COMMAND ${make_cmd}
BINARY_DIR ${opentelemetry_BINARY_DIR}
INSTALL_COMMAND ""
BUILD_BYPRODUCTS ${opentelemetry_libs}
DEPENDS ${dependencies}
LOG_BUILD ON)
# CMake doesn't allow to add a list of libraries to the import property, hence
# we create individual targets and link their libraries which finally
# interfaces to opentelemetry target
target_create("opentelemetry_trace" "sdk/src/trace/libopentelemetry_trace.a")
target_create("opentelemetry_resources"
"sdk/src/resource/libopentelemetry_resources.a")
target_create("opentelemetry_common"
"sdk/src/common/libopentelemetry_common.a")
target_create("opentelemetry_exporter_jaeger_trace"
"exporters/jaeger/libopentelemetry_exporter_jaeger_trace.a")
target_create("http_client_curl"
cmake: remove git fetch and use submodule for building opentelemetry lib We were using git fetch and an unofficial remote to fetch opentelemetry-cpp, as it needed additional patch to include boost headers, with the merge of open-telemetry/opentelemetry-cpp#1100 open-telemetry/opentelemetry-cpp#1020 we do not require to maintain our own patched version. Also, we were using git fetch as a temporary change, now that tracing is always on, it should be right time to adapt to using opentelemetry-cpp as a submodule. This removes compile time fetch for opentelemetry-cpp instead use official opentelemetry-cpp lib as a submodule. Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2022-06-18 10:40:58 +00:00
"ext/src/http/client/curl/libopentelemetry_http_client_curl.a")
cmake: replace opentracing-cpp with opentelemetry-cpp we build and use targets needed for jaeger to work with opentelemetry referring: https://github.com/open-telemetry/opentelemetry-cpp/blob/main/examples/jaeger/CMakeLists.txt right now we need a patch for using thrift from distro packages, hence we are using GIT_FETCH based externalProject method, for development purpose, which will be replace by more reliable method in future. NOTE: phase 1, still needs to be tested. Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2021-10-20 08:02:51 +00:00
# will do all linking and path setting fake include path for
# interface_include_directories since this happens at build time
cmake: include opentelemetry include directories Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2022-02-03 06:52:33 +00:00
file(MAKE_DIRECTORY ${opentelemetry_include_dir})
cmake: replace opentracing-cpp with opentelemetry-cpp we build and use targets needed for jaeger to work with opentelemetry referring: https://github.com/open-telemetry/opentelemetry-cpp/blob/main/examples/jaeger/CMakeLists.txt right now we need a patch for using thrift from distro packages, hence we are using GIT_FETCH based externalProject method, for development purpose, which will be replace by more reliable method in future. NOTE: phase 1, still needs to be tested. Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2021-10-20 08:02:51 +00:00
add_library(opentelemetry::libopentelemetry INTERFACE IMPORTED)
add_dependencies(opentelemetry::libopentelemetry opentelemetry-cpp)
set_target_properties(
opentelemetry::libopentelemetry
PROPERTIES
cmake: include opentelemetry include directories Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2022-02-03 06:52:33 +00:00
INTERFACE_LINK_LIBRARIES "${opentelemetry_deps}"
INTERFACE_INCLUDE_DIRECTORIES "${opentelemetry_include_dir}")
tracer/osd/librados/build/rgw: rgw and osd end2end tracing using opentelemetry * build: add opentelemetry to cmake system crimson targets that uses Message.cc/h are built before opentelemetry (o-tel), so we need to build o-tel eralier so we also add the library to the include path earlier this shoud work for WITH_JAEGER flag both the ON/OFF cases, and for librados where the compilation flag is ignored * msg/tracer: add o-tel trace to Messages with decode/encode function in tracer.h some files that uses Message.cc/h just need the encode/decode functions and not all others functions. some crimson targets does not link with ceph_context (common) which is required for tracer.cc file. so we just need to include that functions * librados: Add opentelemtry trace param for aio_operate and operate methods in order to propagate the trace info I added the otel-trace as an extra param. in some places, there already was a blkin trace info, and since it is not used in other places we can safely change it to o-tel trace info. this will be done in another commit, so the cleanup of blkin trace will be in a dedicated commit * osd: use the o-tel trace of the msg as a parent span of the osd trace if there is a valid span in the msg, we will add this op to the request trace, otherwise it will start a new trace for the OSD op * rgw: pass put obj trace info to librados in order to make it possible, I saved the trace info inside the sal::Object, so we can use it later when writing the object to rados it could be used also later for read ops. note the trace field of req_state is initalized only in rgw_process, so it's also required in librgw request flow * prevent breaking channges to kSize. make sure that changes between components built with different versions of OTEL do not break message compatibility Signed-off-by: Omri Zeneva <ozeneva@redhat.com>
2022-08-24 13:57:11 +00:00
include_directories(SYSTEM "${opentelemetry_include_dir}")
cmake: replace opentracing-cpp with opentelemetry-cpp we build and use targets needed for jaeger to work with opentelemetry referring: https://github.com/open-telemetry/opentelemetry-cpp/blob/main/examples/jaeger/CMakeLists.txt right now we need a patch for using thrift from distro packages, hence we are using GIT_FETCH based externalProject method, for development purpose, which will be replace by more reliable method in future. NOTE: phase 1, still needs to be tested. Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2021-10-20 08:02:51 +00:00
endfunction()