RepoMirrors/cJSON
1
0
Fork 0
mirror of https://github.com/DaveGamble/cJSON synced 2025-01-09 16:09:29 +00:00
Code Issues Releases Wiki Activity

refactor cJSONUtils_FindPointerFromObjectTo

Browse Source
This commit is contained in:
Max Bruckner 2017-04-30 12:56:02 +02:00
parent 674a678819
commit 4932c80f26
2 changed files with 25 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
cJSON_Utils.c
View File

@ -148,10 +148,10 @@ static void cJSONUtils_PointerEncodedstrcpy(unsigned char *destination, const un
destination[0] = '\0'; destination[0] = '\0';
} }
CJSON_PUBLIC(char *) cJSONUtils_FindPointerFromObjectTo(cJSON *object, cJSON *target) CJSON_PUBLIC(char *) cJSONUtils_FindPointerFromObjectTo(const cJSON * const object, const cJSON * const target)
{ {
size_t c = 0; size_t child_index = 0;
cJSON *obj = 0; cJSON *current_child = 0;
if (object == target) if (object == target)
{ {
@ -159,42 +159,44 @@ CJSON_PUBLIC(char *) cJSONUtils_FindPointerFromObjectTo(cJSON *object, cJSON *ta
return (char*)cJSONUtils_strdup((const unsigned char*)""); return (char*)cJSONUtils_strdup((const unsigned char*)"");
} }
/* recursively search all children of the object */ /* recursively search all children of the object or array */
for (obj = object->child; obj; (void)(obj = obj->next), c++) for (current_child = object->child; current_child != NULL; (void)(current_child = current_child->next), child_index++)
{ {
unsigned char *found = (unsigned char*)cJSONUtils_FindPointerFromObjectTo(obj, target); unsigned char *target_pointer = (unsigned char*)cJSONUtils_FindPointerFromObjectTo(current_child, target);
if (found) /* found the target? */
if (target_pointer != NULL)
{ {
if (cJSON_IsArray(object)) if (cJSON_IsArray(object))
{ {
/* reserve enough memory for a 64 bit integer + '/' and '\0' */ /* reserve enough memory for a 64 bit integer + '/' and '\0' */
unsigned char *ret = (unsigned char*)cJSON_malloc(strlen((char*)found) + 23); unsigned char *full_pointer = (unsigned char*)cJSON_malloc(strlen((char*)target_pointer) + 20 + sizeof("/"));
/* check if conversion to unsigned long is valid /* check if conversion to unsigned long is valid
* This should be eliminated at compile time by dead code elimination * This should be eliminated at compile time by dead code elimination
* if size_t is an alias of unsigned long, or if it is bigger */ * if size_t is an alias of unsigned long, or if it is bigger */
if (c > ULONG_MAX) if (child_index > ULONG_MAX)
{ {
cJSON_free(found); cJSON_free(target_pointer);
return NULL; return NULL;
} }
sprintf((char*)ret, "/%lu%s", (unsigned long)c, found); /* /<array_index><path> */ sprintf((char*)full_pointer, "/%lu%s", (unsigned long)child_index, target_pointer); /* /<array_index><path> */
cJSON_free(found); cJSON_free(target_pointer);
return (char*)ret; return (char*)full_pointer;
} }
else if (cJSON_IsObject(object))
{
unsigned char *ret = (unsigned char*)cJSON_malloc(strlen((char*)found) + cJSONUtils_PointerEncodedstrlen((unsigned char*)obj->string) + 2);
*ret = '/';
cJSONUtils_PointerEncodedstrcpy(ret + 1, (unsigned char*)obj->string);
strcat((char*)ret, (char*)found);
cJSON_free(found);
return (char*)ret; if (cJSON_IsObject(object))
{
unsigned char *full_pointer = (unsigned char*)cJSON_malloc(strlen((char*)target_pointer) + cJSONUtils_PointerEncodedstrlen((unsigned char*)current_child->string) + 2);
full_pointer[0] = '/';
cJSONUtils_PointerEncodedstrcpy(full_pointer + 1, (unsigned char*)current_child->string);
strcat((char*)full_pointer, (char*)target_pointer);
cJSON_free(target_pointer);
return (char*)full_pointer;
} }
/* reached leaf of the tree, found nothing */ /* reached leaf of the tree, found nothing */
cJSON_free(found); cJSON_free(target_pointer);
return NULL; return NULL;
} }
} }

2
cJSON_Utils.h
View File

@ -60,7 +60,7 @@ CJSON_PUBLIC(cJSON *) cJSONUtils_MergePatch(cJSON *target, cJSON *patch);
CJSON_PUBLIC(cJSON *) cJSONUtils_GenerateMergePatch(cJSON *from, cJSON *to); CJSON_PUBLIC(cJSON *) cJSONUtils_GenerateMergePatch(cJSON *from, cJSON *to);
/* Given a root object and a target object, construct a pointer from one to the other. */ /* Given a root object and a target object, construct a pointer from one to the other. */
CJSON_PUBLIC(char *) cJSONUtils_FindPointerFromObjectTo(cJSON *object, cJSON *target); CJSON_PUBLIC(char *) cJSONUtils_FindPointerFromObjectTo(const cJSON * const object, const cJSON * const target);
/* Sorts the members of the object into alphabetical order. */ /* Sorts the members of the object into alphabetical order. */
CJSON_PUBLIC(void) cJSONUtils_SortObject(cJSON *object); CJSON_PUBLIC(void) cJSONUtils_SortObject(cJSON *object);