mirror of
https://github.com/kdave/btrfs-progs
synced 2024-12-18 20:35:24 +00:00
bed70b939f
[BUG] Commit "btrfs-progs: prepare merging compat feature lists" tries to merged "-O" and "-R" options, as they don't correctly represents btrfs features. But that commit caused the following bug during mkfs for experimental build: $ mkfs.btrfs -f -O block-group-tree /dev/nvme0n1 btrfs-progs v5.19.1 See http://btrfs.wiki.kernel.org for more information. ERROR: superblock magic doesn't match ERROR: illegal nodesize 16384 (not equal to 4096 for mixed block group) [CAUSE] Currently btrfs_parse_fs_features() will return a u64, and reuse the same u64 for both incompat and compat RO flags for experimental branch. This can easily leads to conflicts, as BTRFS_FEATURE_INCOMPAT_MIXED_BLOCK_GROUP and BTRFS_FEATURE_COMPAT_RO_BLOCK_GROUP_TREE both share the same bit (1 << 2). Thus for above case, mkfs.btrfs believe it has set MIXED_BLOCK_GROUP feature, but what we really want is BLOCK_GROUP_TREE. [FIX] Instead of incorrectly re-using the same bits in btrfs_feature, split the old flags into 3 flags: - incompat_flag - compat_ro_flag - runtime_flag The first two flags are easy to understand, the corresponding flag of each feature. The last runtime_flag is to compensate features which doesn't have any on-disk flag set, like QUOTA and LIST_ALL. And since we're no longer using a single u64 as features, we have to introduce a new structure, btrfs_mkfs_features, to contain above 3 flags. This also mean, things like default mkfs features must be converted to use the new structure, thus those old macros are all converted to const static structures: - BTRFS_MKFS_DEFAULT_FEATURES + BTRFS_MKFS_DEFAULT_RUNTIME_FEATURES -> btrfs_mkfs_default_features - BTRFS_CONVERT_ALLOWED_FEATURES -> btrfs_convert_allowed_features And since we're using a structure, it's not longer as easy to implement a disallowed mask. Thus functions with @mask_disallowed are all changed to using an @allowed structure pointer (which can be NULL). Finally if we have experimental features enabled, all features can be specified by -O options, and we can output a unified feature list, instead of the old split ones. Signed-off-by: Qu Wenruo <wqu@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
113 lines
3.1 KiB
C
113 lines
3.1 KiB
C
/*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License v2 as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program; if not, write to the
|
|
* Free Software Foundation, Inc., 59 Temple Place - Suite 330,
|
|
* Boston, MA 021110-1307, USA.
|
|
*/
|
|
|
|
/*
|
|
* Defines and function declarations for users of the mkfs API, no internal
|
|
* definitions.
|
|
*/
|
|
|
|
#ifndef __BTRFS_MKFS_COMMON_H__
|
|
#define __BTRFS_MKFS_COMMON_H__
|
|
|
|
#include "kerncompat.h"
|
|
#include <stdbool.h>
|
|
#include "kernel-lib/sizes.h"
|
|
#include "kernel-shared/ctree.h"
|
|
#include "common/defs.h"
|
|
#include "common/fsfeatures.h"
|
|
|
|
struct btrfs_root;
|
|
struct btrfs_trans_handle;
|
|
|
|
#define BTRFS_MKFS_SYSTEM_GROUP_SIZE SZ_4M
|
|
#define BTRFS_MKFS_SMALL_VOLUME_SIZE SZ_1G
|
|
|
|
/*
|
|
* Default settings for block group types
|
|
*/
|
|
#define BTRFS_MKFS_DEFAULT_DATA_ONE_DEVICE 0 /* SINGLE */
|
|
#define BTRFS_MKFS_DEFAULT_META_ONE_DEVICE BTRFS_BLOCK_GROUP_DUP
|
|
|
|
#define BTRFS_MKFS_DEFAULT_DATA_MULTI_DEVICE 0 /* SINGLE */
|
|
#define BTRFS_MKFS_DEFAULT_META_MULTI_DEVICE BTRFS_BLOCK_GROUP_RAID1
|
|
|
|
/*
|
|
* Tree root blocks created during mkfs
|
|
*/
|
|
enum btrfs_mkfs_block {
|
|
MKFS_ROOT_TREE,
|
|
MKFS_EXTENT_TREE,
|
|
MKFS_CHUNK_TREE,
|
|
MKFS_DEV_TREE,
|
|
MKFS_FS_TREE,
|
|
MKFS_CSUM_TREE,
|
|
MKFS_FREE_SPACE_TREE,
|
|
MKFS_BLOCK_GROUP_TREE,
|
|
|
|
/* MKFS_BLOCK_COUNT should be the max blocks we can have at mkfs time. */
|
|
MKFS_BLOCK_COUNT
|
|
};
|
|
|
|
static const enum btrfs_mkfs_block default_blocks[] = {
|
|
MKFS_ROOT_TREE,
|
|
MKFS_EXTENT_TREE,
|
|
MKFS_CHUNK_TREE,
|
|
MKFS_DEV_TREE,
|
|
MKFS_FS_TREE,
|
|
MKFS_CSUM_TREE,
|
|
MKFS_FREE_SPACE_TREE,
|
|
};
|
|
|
|
struct btrfs_mkfs_config {
|
|
/* Label of the new filesystem */
|
|
const char *label;
|
|
/* Block sizes */
|
|
u32 nodesize;
|
|
u32 sectorsize;
|
|
u32 stripesize;
|
|
u32 leaf_data_size;
|
|
struct btrfs_mkfs_features features;
|
|
/* Size of the filesystem in bytes */
|
|
u64 num_bytes;
|
|
/* checksum algorithm to use */
|
|
enum btrfs_csum_type csum_type;
|
|
u64 zone_size;
|
|
|
|
/* Output fields, set during creation */
|
|
|
|
/* Logical addresses of superblock [0] and other tree roots */
|
|
u64 blocks[MKFS_BLOCK_COUNT + 1];
|
|
char fs_uuid[BTRFS_UUID_UNPARSED_SIZE];
|
|
char chunk_uuid[BTRFS_UUID_UNPARSED_SIZE];
|
|
|
|
/* Superblock offset after make_btrfs */
|
|
u64 super_bytenr;
|
|
};
|
|
|
|
int make_btrfs(int fd, struct btrfs_mkfs_config *cfg);
|
|
int btrfs_make_root_dir(struct btrfs_trans_handle *trans,
|
|
struct btrfs_root *root, u64 objectid);
|
|
u64 btrfs_min_dev_size(u32 nodesize, int mixed, u64 meta_profile,
|
|
u64 data_profile);
|
|
int test_minimum_size(const char *file, u64 min_dev_size);
|
|
int is_vol_small(const char *file);
|
|
int test_num_disk_vs_raid(u64 metadata_profile, u64 data_profile,
|
|
u64 dev_cnt, int mixed, int ssd);
|
|
int test_status_for_mkfs(const char *file, bool force_overwrite);
|
|
int test_dev_for_mkfs(const char *file, int force_overwrite);
|
|
|
|
#endif
|