mirror of
https://github.com/kdave/btrfs-progs
synced 2025-04-27 05:27:56 +00:00
ec5ebf35ec
There's a report that handling of --help in connection with other option
is confusing in some cases:
Various sub-commands to btrfs claim --help is an unrecognized option if
there are any other options on the CLI.
Examples of --help being unrecognized.
$ btrfs filesystem defragment -v --help
btrfs filesystem defragment: unrecognized option '--help'
Try 'btrfs filesystem defragment --help' for more information
$ btrfs balance start -v --help
$ btrfs balabtrfs balance start -v --help
btrfs balance start: unrecognized option '--help'
Try 'btrfs balance start --help' for more information
Alternatively, some sub-commands support --help even if there are extra
options on the CLI:
$ btrfs filesystem df -v --help
usage: btrfs filesystem df [options] <path>
Show space usage information for a mount point
-b|--raw raw numbers in bytes
-h|--human-readable human friendly numbers, base 1024 (default)
-H human friendly numbers, base 1000
--iec use 1024 as a base (KiB, MiB, GiB, TiB)
--si use 1000 as a base (kB, MB, GB, TB)
-k|--kbytes show sizes in KiB, or kB with --si
-m|--mbytes show sizes in MiB, or MB with --si
-g|--gbytes show sizes in GiB, or GB with --si
-t|--tbytes show sizes in TiB, or TB with --si
Global options:
--format TYPE where TYPE is: text
Update clean_args_no_options() to detect unrecognized options properly
and do not show full help text (which usued to be done in the past but
is confusing and not pointing to the problem).
There's also a mixup of global verbosity options and command-specific
verbosity options (now deprecated), so in some commands they are
recognized.
Also handle the --help option for commands without options so the
following works:
$ btrfs fi df -v --help /
btrfs filesystem df: invalid option 'v'
Try 'btrfs filesystem df --help' for more information
$ btrfs fi df -H --help /
usage: btrfs filesystem df [options] <path>
Show space usage information for a mount point
-b|--raw raw numbers in byte
...
Issue: #889
Signed-off-by: David Sterba <dsterba@suse.com>
|
||
|---|---|---|
| .. | ||
| array.c | ||
| array.h | ||
| box.h | ||
| clear-cache.c | ||
| clear-cache.h | ||
| cpu-utils.c | ||
| cpu-utils.h | ||
| defs.h | ||
| device-scan.c | ||
| device-scan.h | ||
| device-utils.c | ||
| device-utils.h | ||
| extent-cache.c | ||
| extent-cache.h | ||
| extent-tree-utils.c | ||
| extent-tree-utils.h | ||
| filesystem-utils.c | ||
| filesystem-utils.h | ||
| format-output.c | ||
| format-output.h | ||
| fsfeatures.c | ||
| fsfeatures.h | ||
| help.c | ||
| help.h | ||
| inject-error.c | ||
| inject-error.h | ||
| internal.h | ||
| messages.c | ||
| messages.h | ||
| open-utils.c | ||
| open-utils.h | ||
| parse-utils.c | ||
| parse-utils.h | ||
| path-utils.c | ||
| path-utils.h | ||
| rbtree-utils.c | ||
| rbtree-utils.h | ||
| root-tree-utils.c | ||
| root-tree-utils.h | ||
| send-stream.c | ||
| send-stream.h | ||
| send-utils.c | ||
| send-utils.h | ||
| sort-utils.c | ||
| sort-utils.h | ||
| string-table.c | ||
| string-table.h | ||
| string-utils.c | ||
| string-utils.h | ||
| sysfs-utils.c | ||
| sysfs-utils.h | ||
| task-utils.c | ||
| task-utils.h | ||
| tree-search.h | ||
| units.c | ||
| units.h | ||
| utils.c | ||
| utils.h | ||