mirror of
https://github.com/kdave/btrfs-progs
synced 2024-12-18 04:15:32 +00:00
87b3197d81
The option "--clear-space-cache" is not really that suitable for "btrfs check" group, as there are some concerns: - Allowing transid mismatch - No leaf item checks Thoe behaviour are inherited from the default open ctree flags for "btrfs check", which can be unsafe if the end user just wants to clear the cache. - Unclear if the cache clearing would happen along with repair Thankfully the clearing of space cache is done without any repair Thus there is a proposal to move space cache removal to rescue group, and this patch would do that exactly. However this would lead to some behavior changes: - Transid mismatch would be treated as error - Leaf items size/offset would still be checked If we hit any above error, we should just abort without doing any write. These change would increase the safety of the space cache removal, thus I believe it's worthy to introduce such behavior change. Since we're here, also add a small explanation on why we need this dedicated tool to clear space cache (especially for v1 cache). Issue: #698 Signed-off-by: Qu Wenruo <wqu@suse.com> Signed-off-by: David Sterba <dsterba@suse.com> |
||
|---|---|---|
| .. | ||
| common.h | ||
| main.c | ||
| mode-common.c | ||
| mode-common.h | ||
| mode-lowmem.c | ||
| mode-lowmem.h | ||
| mode-original.h | ||
| qgroup-verify.c | ||
| qgroup-verify.h | ||
| repair.c | ||
| repair.h | ||