mirror of
https://github.com/kdave/btrfs-progs
synced 2025-01-14 09:40:47 +00:00
930c6362d1
There are quite some variable shadowing in btrfs-progs, most of them are just reusing some common names like tmp. And those are quite safe and the shadowed one are even different type. But there are some exceptions: - @end in traverse_tree_blocks() There is already an @end with the same type, but a different meaning (the end of the current extent buffer passed in). Just rename it to @child_end. - @start in generate_new_data_csums_range() Just rename it to @csum_start. - @size of fixup_chunk_tree_block() This one is particularly bad, we declare a local @size and initialize it to -1, then before we really utilize the variable @size, we immediately reset it to 0, then pass it to logical_to_physical(). Then there is a location to check if @size is -1, which will always be true. According to the code in logical_to_physical(), @size would be clamped down by its original value, thus our local @size will always be 0. This patch would rename the local @size to @found_size, and only set it to -1. The call site is only to pass something as logical_to_physical() requires a non-NULL pointer. We don't really need to bother the returned value. - duplicated @ref declaration in run_delayed_tree_ref() - duplicated @super_flags in change_meta_csums() Just delete the duplicated one. Signed-off-by: Qu Wenruo <wqu@suse.com> Signed-off-by: David Sterba <dsterba@suse.com> |
||
|---|---|---|
| .. | ||
| uapi | ||
| accessors.c | ||
| accessors.h | ||
| async-thread.c | ||
| async-thread.h | ||
| backref.c | ||
| backref.h | ||
| compression.h | ||
| ctree.c | ||
| ctree.h | ||
| delayed-ref.c | ||
| delayed-ref.h | ||
| dir-item.c | ||
| disk-io.c | ||
| disk-io.h | ||
| extent_io.c | ||
| extent_io.h | ||
| extent-io-tree.c | ||
| extent-io-tree.h | ||
| extent-tree.c | ||
| file-item.c | ||
| file-item.h | ||
| file.c | ||
| free-space-cache.c | ||
| free-space-cache.h | ||
| free-space-tree.c | ||
| free-space-tree.h | ||
| inode-item.c | ||
| inode.c | ||
| locking.c | ||
| locking.h | ||
| messages.c | ||
| messages.h | ||
| misc.h | ||
| print-tree.c | ||
| print-tree.h | ||
| README.md | ||
| root-tree.c | ||
| send.h | ||
| transaction.c | ||
| transaction.h | ||
| tree-checker.c | ||
| tree-checker.h | ||
| tree-mod-log.h | ||
| ulist.c | ||
| ulist.h | ||
| uuid-tree.c | ||
| volumes.c | ||
| volumes.h | ||
| zoned.c | ||
| zoned.h | ||
Shared sources with kernel
Status and progress of kernel/userspace synchronization.
- accessors.c - done, local changes
- accessors.h - done, local changes
- async-thread.c - done
- async-thread.h - done
- backref.c - todo
- backref.h - todo
- compression.h - done
- ctree.c - partial
- ctree.h - partial
- delayed-ref.c - partial
- delayed-ref.h - partial
- dir-item.c - partial
- disk-io.c - todo
- disk-io.h - todo
- extent_io.c
- extent_io.h
- extent-io-tree.c - done, local changes
- extent-io-tree.h - done, local changes
- extent-tree.c - todo
- file.c - todo
- file-item.c - todo
- file-item.h - partial
- free-space-cache.c - not needed
- free-space-cache.h - not needed
- free-space-tree.c - partial
- free-space-tree.h - partial
- inode.c - todo
- inode-item.c - partial
- locking.c - done, local changes
- locking.h - done, local changes
- messages.c - done, local changes
- messages.h - done, local changes
- misc.h - done
- print-tree.c - partial, sync to kernel
- print-tree.h - partial
- root-tree.c - partial
- root-tree.h - done
- send.h - done
- transaction.c - todo
- transaction.h - partial, local changes
- tree-checker.c - partial, local changes
- tree-checker.h - partial, local changes
- tree-mod-log.h - done, local changes
- ulist.c - done
- ulist.h - done
- uuid-tree.c - partial
- volumes.c - todo, local changes
- volumes.h - todo, local changes
- zoned.c - todo
- zoned.h - todo