mirror of
https://github.com/kdave/btrfs-progs
synced 2025-01-15 02:01:13 +00:00
8f8d94b8c9
Both functions are just doing the same thing, the only difference is only in error handling, as parse_u64() requires callers to handle it, meanwhile arg_strtou64() would call exit(1). This patch would convert arg_strtou64() to utilize parse_u64(), and use the return value to output different error messages. This also means the return value of parse_u64() would be more than just 0 or 1, but -EINVAL for invalid string (including no numeric string at all, has any tailing characters, or minus value), and -ERANGE for overflow. The existing callers are only checking if the return value is 0, thus not really affected. Signed-off-by: Qu Wenruo <wqu@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
70 lines
1.7 KiB
C
70 lines
1.7 KiB
C
/*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License v2 as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program; if not, write to the
|
|
* Free Software Foundation, Inc., 59 Temple Place - Suite 330,
|
|
* Boston, MA 021110-1307, USA.
|
|
*/
|
|
|
|
#include "kerncompat.h"
|
|
#include <stdlib.h>
|
|
#include <stdio.h>
|
|
#include <limits.h>
|
|
#include "common/string-utils.h"
|
|
#include "common/messages.h"
|
|
#include "common/parse-utils.h"
|
|
|
|
int string_is_numerical(const char *str)
|
|
{
|
|
if (!str)
|
|
return 0;
|
|
if (!(*str >= '0' && *str <= '9'))
|
|
return 0;
|
|
while (*str >= '0' && *str <= '9')
|
|
str++;
|
|
if (*str != '\0')
|
|
return 0;
|
|
return 1;
|
|
}
|
|
|
|
int string_has_prefix(const char *str, const char *prefix)
|
|
{
|
|
for (; ; str++, prefix++)
|
|
if (!*prefix)
|
|
return 0;
|
|
else if (*str != *prefix)
|
|
return (unsigned char)*prefix - (unsigned char)*str;
|
|
}
|
|
|
|
/*
|
|
* This function should be only used when parsing command arg, it won't return
|
|
* error to its caller and rather exit directly just like usage().
|
|
*/
|
|
u64 arg_strtou64(const char *str)
|
|
{
|
|
u64 value;
|
|
int ret;
|
|
|
|
ret = parse_u64(str, &value);
|
|
if (ret == -ERANGE) {
|
|
error("%s is too large", str);
|
|
exit(1);
|
|
} else if (ret == -EINVAL) {
|
|
if (str[0] == '-')
|
|
error("%s: negative value is invalid", str);
|
|
else
|
|
error("%s is not a valid numeric value", str);
|
|
exit(1);
|
|
}
|
|
return value;
|
|
}
|
|
|