mirror of
https://github.com/kdave/btrfs-progs
synced 2025-02-18 02:36:56 +00:00
Userspace utilities to manage btrfs filesystems
66d610010b
[BUG] If the first copy of a tree block has a bad key order, but the second copy is completely good, then "btrfs ins dump-tree -b <bytenr>" fails to print anything past the bad key: leaf 29786112 items 47 free space 983 generation 20 owner EXTENT_TREE leaf 29786112 flags 0x1(WRITTEN) backref revision 1 fs uuid 3381d111-94a3-4ac7-8f39-611bbbdab7e6 chunk uuid 9af1c3c7-2af5-488b-8553-530bd515f14c [snip] item 9 key (20975616 METADATA_ITEM 0) itemoff 3543 itemsize 33 refs 1 gen 16 flags TREE_BLOCK tree block skinny level 0 tree block backref root CHUNK_TREE item 10 key (29360128 BLOCK_GROUP_ITEM 33554432) itemoff 3519 itemsize 24 block group used 94208 chunk_objectid 256 flags METADATA|DUP ERROR: leaf 29786112 slot 11 pointer invalid, offset 1245184 size 0 leaf data limit 3995 ERROR: skip remaining slots While kernel can locate the good copy and acts just like nothing happened. [CAUSE] btrfs-progs uses read_tree_block() to try each copy. But it only uses less strict check_tree_block(), which has less sanity check than btrfs_check_node/leaf(). Some error like bad key order is ignored to allow btrfs check to fix it. This leads to above problem. [FIX] Introduce a new member, @candidate_mirror in read_tree_block(), which records the copy passes check_tree_block() but fails btrfs_check_leaf/node() as last chance. Only if no better copy found, then use @candidate_mirror. So btrfs-progs can act just like kernel to use best copy. Link: https://bugzilla.kernel.org/show_bug.cgi?id=202691 Reported-by: Yoon Jungyeon <jungyeon@gatech.edu> [Inspired by that image, not to fix any bug of that bugzilla] Signed-off-by: Qu Wenruo <wqu@suse.com> |
||
|---|---|---|
| check | ||
| convert | ||
| Documentation | ||
| image | ||
| kernel-lib | ||
| kernel-shared | ||
| libbtrfsutil | ||
| m4 | ||
| mkfs | ||
| tests | ||
| travis | ||
| .gitignore | ||
| .travis.yml | ||
| 64-btrfs-dm.rules | ||
| Android.mk | ||
| androidcompat.h | ||
| autogen.sh | ||
| backref.c | ||
| backref.h | ||
| bcp | ||
| btrfs-completion | ||
| btrfs-corrupt-block.c | ||
| btrfs-crc.c | ||
| btrfs-debugfs | ||
| btrfs-find-root.c | ||
| btrfs-fragments.c | ||
| btrfs-list.c | ||
| btrfs-list.h | ||
| btrfs-map-logical.c | ||
| btrfs-sb-mod.c | ||
| btrfs-select-super.c | ||
| btrfs.c | ||
| btrfsck.h | ||
| btrfstune.c | ||
| CHANGES | ||
| chunk-recover.c | ||
| cmds-balance.c | ||
| cmds-device.c | ||
| cmds-fi-du.c | ||
| cmds-fi-usage.c | ||
| cmds-fi-usage.h | ||
| cmds-filesystem.c | ||
| cmds-inspect-dump-super.c | ||
| cmds-inspect-dump-tree.c | ||
| cmds-inspect-tree-stats.c | ||
| cmds-inspect.c | ||
| cmds-property.c | ||
| cmds-qgroup.c | ||
| cmds-quota.c | ||
| cmds-receive.c | ||
| cmds-replace.c | ||
| cmds-rescue.c | ||
| cmds-restore.c | ||
| cmds-scrub.c | ||
| cmds-send.c | ||
| cmds-subvolume.c | ||
| commands.h | ||
| common-defs.h | ||
| configure.ac | ||
| COPYING | ||
| ctree.c | ||
| ctree.h | ||
| delayed-ref.c | ||
| delayed-ref.h | ||
| dir-item.c | ||
| disk-io.c | ||
| disk-io.h | ||
| extent_io.c | ||
| extent_io.h | ||
| extent-cache.c | ||
| extent-cache.h | ||
| extent-tree.c | ||
| file-item.c | ||
| file.c | ||
| find-root.c | ||
| find-root.h | ||
| free-space-cache.c | ||
| free-space-cache.h | ||
| free-space-tree.c | ||
| free-space-tree.h | ||
| fsck.btrfs | ||
| fsfeatures.c | ||
| fsfeatures.h | ||
| hash.h | ||
| hasher.c | ||
| help.c | ||
| help.h | ||
| inode-item.c | ||
| inode-map.c | ||
| inode.c | ||
| INSTALL | ||
| internal.h | ||
| ioctl-test.c | ||
| ioctl.h | ||
| kerncompat.h | ||
| library-test.c | ||
| Makefile | ||
| Makefile.extrawarn | ||
| Makefile.inc.in | ||
| messages.c | ||
| messages.h | ||
| print-tree.c | ||
| print-tree.h | ||
| props.c | ||
| props.h | ||
| qgroup-verify.c | ||
| qgroup-verify.h | ||
| qgroup.c | ||
| qgroup.h | ||
| quick-test.c | ||
| random-test.c | ||
| rbtree-utils.c | ||
| rbtree-utils.h | ||
| README.md | ||
| repair.c | ||
| repair.h | ||
| rescue.h | ||
| root-tree.c | ||
| send-dump.c | ||
| send-dump.h | ||
| send-stream.c | ||
| send-stream.h | ||
| send-utils.c | ||
| send-utils.h | ||
| send.h | ||
| show-blocks | ||
| string-table.c | ||
| string-table.h | ||
| super-recover.c | ||
| task-utils.c | ||
| task-utils.h | ||
| transaction.c | ||
| transaction.h | ||
| utils-lib.c | ||
| utils.c | ||
| utils.h | ||
| uuid-tree.c | ||
| VERSION | ||
| version.h.in | ||
| volumes.c | ||
| volumes.h | ||
Btrfs-progs 
Userspace utilities to manage btrfs filesystems. License: GPLv2.
Btrfs is a copy on write (COW) filesystem for Linux aimed at implementing advanced features while focusing on fault tolerance, repair and easy administration.
This repository hosts following utilities:
- btrfs — the main administration tool (manual page)
- mkfs.btrfs — utility to create the filesystem (manual page)
The C and python 3 bindings are provided by a LGPL library libbtrfsutil see libbtrfsutil/README.md for more.
See INSTALL for build instructions and tests/README.md for testing information.
Release cycle
The major version releases are time-based and follow the cycle of the linux kernel releases. The cycle usually takes 2 months. A minor version releases may happen in the meantime if there are bug fixes or minor useful improvements queued.
The release tags are signed with a GPG key ID F2B4 1200 C54E FB30 380C 1756 C565 D5F9 D76D 583B,
release tarballs are hosted at kernel.org.
See file CHANGES or changelogs on wiki.
Reporting bugs
There are several ways, each has its own specifics and audience that can give feedback or work on a fix. The following list is sorted in the order of preference:
- github issue tracker
- to the mailing list linux-btrfs@vger.kernel.org -- (not required to subscribe), beware that the mail might get overlooked in other traffic
- IRC (irc.freenode.net #btrfs) -- good for discussions eg. if a bug is already known, but reports could miss developers' attention
- bugzilla.kernel.org -- (requires registration), set the product to Filesystems and component Btrfs, please put 'btrfs-progs' into the subject so it's clear that it's not a kernel bug report
Development
The patch submissions, development or general discussions take place at linux-btrfs@vger.kernel.org mailinglist, subsciption is not required to post.
The GitHub pull requests will not be accepted directly, the preferred way is to send patches to the mailinglist instead. You can link to a branch in any git repository if the mails do not make it to the mailinglist or just for convenience (makes it easier to test).
The development model of btrfs-progs shares a lot with the kernel model. The github way is different in some ways. We, the upstream community, expect that the patches meet some criteria (often lacking in github contributions):
- one logical change per patch: eg. not mixing bugfixes, cleanups, features etc., sometimes it's not clear and will be usually pointed out during reviews
- proper subject line: eg. prefix with btrfs-progs: subpart, ... ,
descriptive yet not too long, see
git log --onelinefor some inspiration - proper changelog: the changelogs are often missing or lacking explanation why the change was made, or how is something broken, what are user-visible effects of the bug or the fix, how does an improvement help or the intended usecase
- the Signed-off-by line: this documents who authored the change, you can read
more about the
The Developer's Certificate of Origin (chapter 11)
- if you are not used to the signed-off style, your contributions won't be rejected just because of it's missing, the Author: tag will be added as a substitute in order to allow contributions without much bothering with formalities
Documentation updates
Documentation fixes or updates do not need much explanation so sticking to the code rules in the previous section is not necessary. GitHub pull requests are OK, patches could be sent to me directly and not required to be also in the mailinglist. Pointing out typos via IRC also works, although might get accidentally lost in the noise.