485fceec8d
Testing with the fstests config option POST_MKFS_CMD="btrfstune -m" reported failure, as shown below: ./check btrfs/003 [111.635618] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 1 transid 6 /dev/sdb2 scanned by systemd-udevd (1117) [111.642199] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 2 transid 6 /dev/sdb3 scanned by systemd-udevd (1114) [111.660882] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 3 transid 6 /dev/sdb5 scanned by systemd-udevd (1116) [111.672623] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 4 transid 6 /dev/sdb6 scanned by systemd-udevd (993) [111.701301] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 6 transid 6 /dev/sdb8 scanned by systemd-udevd (1080) [111.706513] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 5 transid 6 /dev/sdb7 scanned by systemd-udevd (1117) [111.716532] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 7 transid 6 /dev/sdb9 scanned by systemd-udevd (1114) [111.721253] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 8 transid 6 /dev/sdb10 scanned by mkfs.btrfs (1504) [112.405186] BTRFS: device fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e devid 4 transid 8 /dev/sdb6 scanned by systemd-udevd (1117) [112.422104] BTRFS: device fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e devid 6 transid 8 /dev/sdb8 scanned by systemd-udevd (1523) [112.448355] BTRFS: device fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e devid 1 transid 8 /dev/sdb2 scanned by systemd-udevd (1115) [112.456126] BTRFS error: device /dev/sdb3 belongs to fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e, and the fs is already mounted [112.461299] BTRFS error: device /dev/sdb7 belongs to fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e, and the fs is already mounted [112.465690] BTRFS info (device sdb2): using crc32c (crc32c-generic) checksum algorithm [112.468758] BTRFS info (device sdb2): using free space tree [112.471318] BTRFS error: device /dev/sdb9 belongs to fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e, and the fs is already mounted [112.475962] BTRFS error: device /dev/sdb10 belongs to fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e, and the fs is already mounted [112.481934] BTRFS error: device /dev/sdb5 belongs to fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e, and the fs is already mounted [112.494614] BTRFS error (device sdb2): devid 2 uuid 99a57db7-2ef6-4240-a700-07ee7e64fb36 is missing [112.497834] BTRFS error (device sdb2): failed to read chunk tree: -2 [112.507705] BTRFS error (device sdb2): open_ctree failed The original fsid created by mkfs was a6599a65-8b6d-4156-bb55-0a3a2f0eae9d, and the fsid created by the btrfstune -m option was 1b3bacbf-14db-49c9-a3ef-547998aacc4e. During mount (after btrfstune -m), only 3 out of 8 devices were scanned by systemd, while the rest were still being discovered. Consequently, the mount command raced to find the missing devices. Since the mount command in the kernel sets the flag fsdevices::opened, any further new alloc_device() were blocked, resulting in the error "the fs is already mounted." It is a good idea to register all devices after changing the fsid. The previous registrations are already stale after changing the fsid. Signed-off-by: Anand Jain <anand.jain@oracle.com> Signed-off-by: David Sterba <dsterba@suse.com> |
||
|---|---|---|
| .github/workflows | ||
| Documentation | ||
| check | ||
| ci | ||
| cmds | ||
| common | ||
| config | ||
| convert | ||
| crypto | ||
| image | ||
| include | ||
| kernel-lib | ||
| kernel-shared | ||
| libbtrfs | ||
| libbtrfsutil | ||
| mkfs | ||
| tests | ||
| tune | ||
| .editorconfig | ||
| .gitignore | ||
| 64-btrfs-dm.rules | ||
| 64-btrfs-zoned.rules | ||
| CHANGES | ||
| COPYING | ||
| INSTALL | ||
| Makefile | ||
| Makefile.extrawarn | ||
| Makefile.inc.in | ||
| README.md | ||
| VERSION | ||
| autogen.sh | ||
| btrfs-completion | ||
| btrfs-corrupt-block.c | ||
| btrfs-crc.c | ||
| btrfs-debugfs | ||
| btrfs-find-root.c | ||
| btrfs-fragments.c | ||
| btrfs-map-logical.c | ||
| btrfs-sb-mod.c | ||
| btrfs-select-super.c | ||
| btrfs.c | ||
| configure.ac | ||
| fsck.btrfs | ||
| inject-error | ||
| quick-test.c | ||
| show-blocks | ||
README.md
Btrfs-progs
Userspace utilities to manage btrfs filesystems. License: GPLv2.
Btrfs is a copy on write (COW) filesystem for Linux aimed at implementing advanced features while focusing on fault tolerance, repair and easy administration.
This repository hosts following utilities and also documentation:
- btrfs — the main administration tool (manual page)
- mkfs.btrfs — utility to create the filesystem (manual page)
- all-in-one binary in the busybox style with mkfs.btrfs, btrfs-image and other tools built-in (standalone tools)
- libbtrfsutil (LGPL v2.1) — C and python 3 bindings, see libbtrfsutil/README.md for more
- manual pages and documentation source published at btrfs.readthedocs.io (RTD)
See INSTALL for build instructions, tests/README.md for testing information and ci/README.md for CI information.
Release cycle
The major version releases are time-based and follow the cycle of the linux kernel releases. The cycle usually takes 2 months. A minor version releases may happen in the meantime if there are bug fixes or minor useful improvements queued.
The release tags are signed with a GPG key ID F2B4 1200 C54E FB30 380C 1756 C565 D5F9 D76D 583B,
release tarballs are hosted at kernel.org.
See file CHANGES or changelogs on RTD.
Reporting bugs
There are several ways, each has its own specifics and audience that can give feedback or work on a fix. The following list is sorted in the order of preference:
- github issue tracker
- to the mailing list linux-btrfs@vger.kernel.org -- (not required to subscribe), beware that the mail might get overlooked in other traffic
- IRC (irc.libera.chat #btrfs) -- good for discussions eg. if a bug is already known, but reports could miss developers' attention
- please don't use https://bugzilla.kernel.org for btrfs-progs bugs
Development
The development takes place in the mailing list (linux-btrfs@vger.kernel.org) or at github (issues, pull requests). Changes should be split to logical parts if possible, documentation may be included in the same patch as to code or separately.
The development model of btrfs-progs shares a lot with the kernel model. The
- one logical change per patch: eg. not mixing bugfixes, cleanups, features etc., sometimes it's not clear and will be usually pointed out during reviews
- proper subject line: eg. prefix with btrfs-progs: subpart, ... ,
descriptive yet not too long, see
git log --onelinefor some inspiration - proper changelog: the changelogs are often missing or lacking explanation why the change was made, or how is something broken, what are user-visible effects of the bug or the fix, how does an improvement help or the intended usecase
- the Signed-off-by line is not mandatory for less significant changes
(typos, documentation) but is desired as this documents who authored the
change, you can read more about the
The Developer's Certificate of Origin (chapter 11)
- if you are not used to the signed-off style, your contributions won't be rejected just because of it's missing, the Author: tag will be added as a substitute in order to allow contributions without much bothering with formalities
Source code coding style and preferences follow the
kernel coding style.
You can find the editor settings in .editorconfig and use the
EditorConfig plugin to let your editor use that,
or update your editor settings manually.
Testing
The testing documentation can be found in tests/ and continuous integration/container images in ci/.
Documentation updates
Documentation fixes or updates do not need much explanation so sticking to the code rules in the previous section is not necessary. GitHub pull requests are OK, patches could be sent to me directly and not required to be also in the mailinglist. Pointing out typos via IRC also works, although might get accidentally lost in the noise.
Documentation sources are written in RST and built by sphinx.
Third-party sources
Build dependencies are listed in INSTALL. Implementation of checksum/hash functions is provided by copies of the respective sources to avoid adding dependencies that would make deployments in rescue or limited environments harder. The implementations are portable and there are optimized versions for some architectures. Optionally it's possible to use libgcrypt, libsodium or libkcapi implementations.
- CRC32C: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
- XXHASH: https://github.com/Cyan4973/xxHash
- SHA256: https://tools.ietf.org/html/rfc4634
- BLAKE2: https://github.com/BLAKE2/BLAKE2
Some other code is borrowed from kernel, eg. the raid5 tables or data structure implementation (list, rb-tree).