mirror of
https://github.com/kdave/btrfs-progs
synced 2025-03-30 23:26:21 +00:00
dd7c458cb3
Currently fileattr commands, introduced in the send stream v2, always
fail, since we have commented the FS_IOC_SETFLAGS ioctl() call and set
'ret' to -EOPNOTSUPP, which is then overwritten to -errno, which may
have a random value since it was not initialized before. This results
in a failure like this:
ERROR: fileattr: set file attributes on p0/f1 failed: Invalid argument
The error reason may be something else, since errno is undefined at
this point.
Unfortunately we don't have a way yet to apply attributes, since the
attributes value we get from the kernel is what we store in flags field
of the inode item. This means that for example we can not just call
FS_IOC_SETFLAGS with the values we got, since they need to be converted
from BTRFS_INODE_* flags to FS_* flags
Besides that we'll have to reorder how we apply certain attributes like
FS_NOCOW_FL for example, which must happen always on an empty file and
right now we run write commands before attempting to change attributes,
as that's the order the kernel sends the operations.
So for now comment all the code, so that anyone using the v2 stream will
not have a receive failure but will get a behaviour like the v1 stream:
file attributes are ignored. This will have to be fixed later, but right
now people can't use a send stream v2 for the purpose of getting better
performance by avoid decompressing extents at the source and compression
of the data at the destination.
Link: https://lore.kernel.org/linux-btrfs/6cb11fa5-c60d-e65b-0295-301a694e66ad@inbox.ru/
Fixes:
|
||
|---|---|---|
| .. | ||
| balance.c | ||
| commands.h | ||
| device.c | ||
| filesystem-du.c | ||
| filesystem-usage.c | ||
| filesystem-usage.h | ||
| filesystem.c | ||
| inspect-dump-super.c | ||
| inspect-dump-tree.c | ||
| inspect-tree-stats.c | ||
| inspect.c | ||
| property.c | ||
| props.h | ||
| qgroup.c | ||
| qgroup.h | ||
| quota.c | ||
| receive-dump.c | ||
| receive-dump.h | ||
| receive.c | ||
| replace.c | ||
| rescue-chunk-recover.c | ||
| rescue-super-recover.c | ||
| rescue.c | ||
| rescue.h | ||
| restore.c | ||
| scrub.c | ||
| send.c | ||
| subvolume-list.c | ||
| subvolume.c | ||