RepoMirrors
/
btrfs-progs
mirror of https://github.com/kdave/btrfs-progs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

btrfs-progs: check: lowmem, verify the sequence of inline backref items 

Commit 6cf11f3e38 ("btrfs-progs: check: check order of inline extent
refs") added the ability to detect out-of-order inline extent backref
items.

Meanwhile there is no such ability in lowmem mode, this patch would
introduce such ability to lowmem mode.

Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Qu Wenruo 2023-10-22 14:10:08 +10:30 committed by David Sterba
parent ad8a831a74
commit ff9730cafa
2 changed files with 32 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
check/mode-lowmem.c
View File

@ -4234,6 +4234,7 @@ static int check_extent_item(struct btrfs_path *path)
unsigned long ptr; unsigned long ptr;
int slot = path->slots[0]; int slot = path->slots[0];
int type; int type;
int last_type = 0;
u32 nodesize = btrfs_super_nodesize(gfs_info->super_copy); u32 nodesize = btrfs_super_nodesize(gfs_info->super_copy);
u32 item_size = btrfs_item_size(eb, slot); u32 item_size = btrfs_item_size(eb, slot);
u64 flags; u64 flags;
@ -4245,6 +4246,8 @@ static int check_extent_item(struct btrfs_path *path)
u64 owner; u64 owner;
u64 owner_offset; u64 owner_offset;
u64 super_gen; u64 super_gen;
u64 seq;
u64 last_seq = U64_MAX;
int metadata = 0; int metadata = 0;
/* To handle corrupted values in skinny backref */ /* To handle corrupted values in skinny backref */
u64 level; u64 level;
@ -4342,6 +4345,32 @@ next:
iref = (struct btrfs_extent_inline_ref *)ptr; iref = (struct btrfs_extent_inline_ref *)ptr;
type = btrfs_extent_inline_ref_type(eb, iref); type = btrfs_extent_inline_ref_type(eb, iref);
offset = btrfs_extent_inline_ref_offset(eb, iref); offset = btrfs_extent_inline_ref_offset(eb, iref);
if (type == BTRFS_EXTENT_DATA_REF_KEY) {
dref = (struct btrfs_extent_data_ref *)(&iref->offset);
seq = hash_extent_data_ref(
btrfs_extent_data_ref_root(eb, dref),
btrfs_extent_data_ref_objectid(eb, dref),
btrfs_extent_data_ref_offset(eb, dref));
} else {
seq = offset;
}
/*
* The @type should be ascending, while inside the same type, the
* @seq should be descending.
*/
if (type < last_type)
tmp_err |= BACKREF_OUT_OF_ORDER;
else if (type > last_type)
last_seq = U64_MAX;
if (seq > last_seq)
tmp_err |= BACKREF_OUT_OF_ORDER;
if (tmp_err & BACKREF_OUT_OF_ORDER)
error(
"inline extent backref (type %u seq 0x%llx) of extent [%llu %u %llu] is out of order",
type, seq, key.objectid, key.type, key.offset);
switch (type) { switch (type) {
case BTRFS_TREE_BLOCK_REF_KEY: case BTRFS_TREE_BLOCK_REF_KEY:
root_objectid = offset; root_objectid = offset;
@ -4420,6 +4449,8 @@ next:
err |= tmp_err; err |= tmp_err;
ptr_offset += btrfs_extent_inline_ref_size(type); ptr_offset += btrfs_extent_inline_ref_size(type);
last_type = type;
last_seq = seq;
goto next; goto next;
out: out:

1
check/mode-lowmem.h
View File

@ -64,6 +64,7 @@
#define UNKNOWN_TYPE (1 << 6) /* Unknown type */ #define UNKNOWN_TYPE (1 << 6) /* Unknown type */
#define ACCOUNTING_MISMATCH (1 << 7) /* Used space accounting error */ #define ACCOUNTING_MISMATCH (1 << 7) /* Used space accounting error */
#define CHUNK_TYPE_MISMATCH (1 << 8) #define CHUNK_TYPE_MISMATCH (1 << 8)
#define BACKREF_OUT_OF_ORDER (1 << 9)
int check_fs_roots_lowmem(void); int check_fs_roots_lowmem(void);
int check_chunks_and_extents_lowmem(void); int check_chunks_and_extents_lowmem(void);