RepoMirrors/btrfs-progs
1
0
Fork 0
mirror of https://github.com/kdave/btrfs-progs synced 2025-05-08 02:48:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

btrfs-progs: dev stats: update option name for checking non-zero status

Browse Source 
Rename the option to -c|--check and update documentation.

Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
David Sterba 2016-12-12 18:02:19 +01:00
parent e4fbe791e4
commit d62902e95b
2 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Documentation/btrfs-device.asciidoc
View File

@ -98,7 +98,7 @@ remain as such. Reloading the kernel module will drop this information. There's
an alternative way of mounting multiple-device filesystem without the need for an alternative way of mounting multiple-device filesystem without the need for
prior scanning. See the mount option 'device'. prior scanning. See the mount option 'device'.
*stats* [-zs] <path>|<device>:: *stats* [options] <path>|<device>::
Read and print the device IO error statistics for all devices of the given Read and print the device IO error statistics for all devices of the given
filesystem identified by <path> or for a single <device>. The filesystem must filesystem identified by <path> or for a single <device>. The filesystem must
be mounted. See section *DEVICE STATS* for more information about the reported be mounted. See section *DEVICE STATS* for more information about the reported
@ -109,8 +109,10 @@ statistics and the meaning.
-z|--reset:::: -z|--reset::::
Print the stats and reset the values to zero afterwards. Print the stats and reset the values to zero afterwards.
-s:::: -c|--check::::
Set bit 6 of the return-code if any error statistics are non-zero. Check if the stats are all zeros and return 0 it it is so. Set bit 6 of the
return code if any of the statistics is no-zero. The error values is 65 if
reading stats from at least one device failed, otherwise it's 64.
*usage* [options] <path> [<path>...]:: *usage* [options] <path> [<path>...]::
Show detailed information about internal allocations in devices. Show detailed information about internal allocations in devices.

14
cmds-device.c
View File

@ -377,8 +377,8 @@ static const char * const cmd_device_stats_usage[] = {
"Show device IO error statistics for all devices of the given filesystem", "Show device IO error statistics for all devices of the given filesystem",
"identified by PATH or DEVICE. The filesystem must be mounted.", "identified by PATH or DEVICE. The filesystem must be mounted.",
"", "",
"-c|--check return non-zero if any stat counter is not zero",
"-z|--reset show current stats and reset values to zero", "-z|--reset show current stats and reset values to zero",
"-s return non-zero if any stat counter is not zero",
NULL NULL
}; };
@ -391,7 +391,7 @@ static int cmd_device_stats(int argc, char **argv)
int fdmnt; int fdmnt;
int i; int i;
int err = 0; int err = 0;
int status = 0; int check = 0;
__u64 flags = 0; __u64 flags = 0;
DIR *dirstream = NULL; DIR *dirstream = NULL;
@ -402,17 +402,17 @@ static int cmd_device_stats(int argc, char **argv)
{NULL, 0, NULL, 0} {NULL, 0, NULL, 0}
}; };
c = getopt_long(argc, argv, "zs", long_options, NULL); c = getopt_long(argc, argv, "cz", long_options, NULL);
if (c < 0) if (c < 0)
break; break;
switch (c) { switch (c) {
case 'c':
check = 1;
break;
case 'z': case 'z':
flags = BTRFS_DEV_STATS_RESET; flags = BTRFS_DEV_STATS_RESET;
break; break;
case 's':
status = 1;
break;
case '?': case '?':
default: default:
usage(cmd_device_stats_usage); usage(cmd_device_stats_usage);
@ -494,7 +494,7 @@ static int cmd_device_stats(int argc, char **argv)
dev_stats[j].name, dev_stats[j].name,
(unsigned long long) (unsigned long long)
args.values[dev_stats[j].num]); args.values[dev_stats[j].num]);
if ((status == 1) if ((check == 1)
&& (args.values[dev_stats[j].num] > 0)) && (args.values[dev_stats[j].num] > 0))
err |= 64; err |= 64;
} }