RepoMirrors/btrfs-progs
1
0
Fork 0
mirror of https://github.com/kdave/btrfs-progs synced 2025-04-30 06:57:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Btrfs-progs: fsck: fix double free memory crash

Browse Source 
Fix double free of memory if btrfs_open_devices fails:
*** Error in `btrfs': double free or corruption (fasttop): 0x000000000066e020 ***

Crash happened because when open failed on device inside
btrfs_open_devices it freed all memory by calling btrfs_close_devices but
inside disk-io.c we call btrfs_close_again it again.

Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
Signed-off-by: David Sterba <dsterba@suse.cz>
This commit is contained in:
Rakesh Pandit 2014-04-20 16:17:53 +03:00 committed by David Sterba
parent ad17d56084
commit cdee9ecc18
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
disk-io.c
View File

@ -1091,8 +1091,7 @@ static struct btrfs_fs_info *__open_ctree_fd(int fp, const char *path,
ret = btrfs_open_devices(fs_devices, oflags); ret = btrfs_open_devices(fs_devices, oflags);
if (ret) if (ret)
goto out_devices; goto out;
disk_super = fs_info->super_copy; disk_super = fs_info->super_copy;
if (!(flags & OPEN_CTREE_RECOVER_SUPER)) if (!(flags & OPEN_CTREE_RECOVER_SUPER))