RepoMirrors/btrfs-progs
1
0
Fork 0
mirror of https://github.com/kdave/btrfs-progs synced 2025-04-23 23:45:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

btrfs-progs: fix UNITS_DECIMAL and UNITS_NEGATIVE bit definitions

Browse Source 
The values of UNITS_ modes are supposed to be unique and
non-overlapping. Due to wrong definition this was not true for
UNITS_DECIMAL which set 2 bits. This breaks code that strictly depends
on the uniqueness of the bits and not on the order of processing of the
constants.

Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
David Sterba 2025-02-12 00:01:44 +01:00
parent 6f0b332de2
commit cab2eeb9ff
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
common/units.h
View File

@ -31,9 +31,9 @@
#define UNITS_TBYTES (5) #define UNITS_TBYTES (5)
#define UNITS_RAW (1U << UNITS_MODE_SHIFT) #define UNITS_RAW (1U << UNITS_MODE_SHIFT)
#define UNITS_BINARY (2U << UNITS_MODE_SHIFT) #define UNITS_BINARY (2U << UNITS_MODE_SHIFT)
#define UNITS_DECIMAL (3U << UNITS_MODE_SHIFT) #define UNITS_DECIMAL (4U << UNITS_MODE_SHIFT)
/* Interpret the u64 value as s64 */ /* Interpret the u64 value as s64 */
#define UNITS_NEGATIVE (4U << UNITS_MODE_SHIFT) #define UNITS_NEGATIVE (8U << UNITS_MODE_SHIFT)
#define UNITS_MODE_MASK ((1U << UNITS_MODE_SHIFT) - 1) #define UNITS_MODE_MASK ((1U << UNITS_MODE_SHIFT) - 1)
#define UNITS_MODE_SHIFT (8) #define UNITS_MODE_SHIFT (8)
#define UNITS_HUMAN_BINARY (UNITS_BINARY) #define UNITS_HUMAN_BINARY (UNITS_BINARY)