From bf357ff320f80eb1a47e0fd4d06be374e2f2b3fd Mon Sep 17 00:00:00 2001 From: Rakesh Pandit Date: Sat, 15 Mar 2014 14:22:37 +0200 Subject: [PATCH] Btrfs-progs: fsck: fix memory leak and unnecessary call to free Free already allocated memory to item1_data if malloc fails for item2_data in swap_values. Seems to be a typo from commit 70749a77. Signed-off-by: Rakesh Pandit Signed-off-by: David Sterba Signed-off-by: Chris Mason --- cmds-check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmds-check.c b/cmds-check.c index d1cafe1d..60708d05 100644 --- a/cmds-check.c +++ b/cmds-check.c @@ -2380,7 +2380,7 @@ static int swap_values(struct btrfs_root *root, struct btrfs_path *path, return -ENOMEM; item2_data = malloc(item2_size); if (!item2_data) { - free(item2_data); + free(item1_data); return -ENOMEM; }