RepoMirrors/btrfs-progs
1
0
Fork 0
mirror of https://github.com/kdave/btrfs-progs synced 2025-01-12 16:59:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

btrfs-progs: Fix negative eb's ref_cnt in btrfs-calc-size

Browse Source 
btrfs-calc-size show following warning:
 # btrfs-calc-size /dev/sda6
 Calculating size of root tree
 ...
 extent_io.c:582: free_extent_buffer: Assertion `eb->refs < 0` failed.
 ./btrfs-calc-size[0x41d642]
 ./btrfs-calc-size(free_extent_buffer+0x70)[0x41e1c1]
 ./btrfs-calc-size(btrfs_free_fs_root+0x11)[0x40e1e8]
 ./btrfs-calc-size[0x40e215]
 ./btrfs-calc-size(rb_free_nodes+0x1d)[0x4326fe]
 ./btrfs-calc-size(close_ctree+0x3f3)[0x40f9ea]
 ./btrfs-calc-size(main+0x200)[0x431b4e]
 /lib64/libc.so.6(__libc_start_main+0xf5)[0x3858621d65]
 ./btrfs-calc-size[0x407009]

Reason:
 path in calc_root_size() is only used to save node data,
 it don't hold ref_cnt for each eb in.
 Using btrfs_free_path() to free path will reduce these eb
 again, and cause many problems, as negative ref_cnt or
 invalid memory access.

Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Zhao Lei 2015-10-29 17:31:44 +08:00 committed by David Sterba
parent 0b69dfa410
commit ba4476bc62
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
btrfs-calc-size.c
View File

@ -417,7 +417,14 @@ out:
free(seek); free(seek);
} }
btrfs_free_path(path); /*
* We only use path to save node data in iterating,
* without holding eb's ref_cnt in path.
* Don't use btrfs_free_path() here, it will free these
* eb again, and cause many problems, as negative ref_cnt
* or invalid memory access.
*/
free(path);
return ret; return ret;
} }