RepoMirrors
/
btrfs-progs
mirror of https://github.com/kdave/btrfs-progs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

btrfs-progs: check/original: Detect invalid extent generation 

Much like what we have done in lowmem mode, also detect and report
invalid extent generation in original mode.

Unlike lowmem mode, we have extent_record::generation, which is the
higher number of generations in EXTENT_ITEM, EXTENT_DATA or tree block
header, so there is no need to check generations in different locations.

For repair, we still need to depend on --init-extent-tree, as directly
modifying extent items can easily cause conflicts with delayed refs,
thus it should be avoided.

Reviewed-by: Su Yue <Damenly_Su@gmx.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Qu Wenruo 2019-12-31 15:12:19 +08:00 committed by David Sterba
parent 918ba847bc
commit b3621da146
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
check/main.c
View File

@ -4021,10 +4021,13 @@ static void free_extent_record_cache(struct cache_tree *extent_cache)
static int maybe_free_extent_rec(struct cache_tree *extent_cache, static int maybe_free_extent_rec(struct cache_tree *extent_cache,
struct extent_record *rec) struct extent_record *rec)
{ {
u64 super_gen = btrfs_super_generation(global_info->super_copy);
if (rec->content_checked && rec->owner_ref_checked && if (rec->content_checked && rec->owner_ref_checked &&
rec->extent_item_refs == rec->refs && rec->refs > 0 && rec->extent_item_refs == rec->refs && rec->refs > 0 &&
rec->num_duplicates == 0 && !all_backpointers_checked(rec, 0) && rec->num_duplicates == 0 && !all_backpointers_checked(rec, 0) &&
!rec->bad_full_backref && !rec->crossing_stripes && !rec->bad_full_backref && !rec->crossing_stripes &&
rec->generation <= super_gen + 1 &&
!rec->wrong_chunk_type) { !rec->wrong_chunk_type) {
remove_cache_extent(extent_cache, &rec->cache); remove_cache_extent(extent_cache, &rec->cache);
free_all_extent_backrefs(rec); free_all_extent_backrefs(rec);
@ -7887,6 +7890,7 @@ static int check_extent_refs(struct btrfs_root *root,
{ {
struct extent_record *rec; struct extent_record *rec;
struct cache_extent *cache; struct cache_extent *cache;
u64 super_gen;
int ret = 0; int ret = 0;
int had_dups = 0; int had_dups = 0;
int err = 0; int err = 0;
@ -7954,6 +7958,7 @@ static int check_extent_refs(struct btrfs_root *root,
if (had_dups) if (had_dups)
return -EAGAIN; return -EAGAIN;
super_gen = btrfs_super_generation(root->fs_info->super_copy);
while (1) { while (1) {
int cur_err = 0; int cur_err = 0;
int fix = 0; int fix = 0;
@ -7969,6 +7974,13 @@ static int check_extent_refs(struct btrfs_root *root,
cur_err = 1; cur_err = 1;
} }
if (rec->generation > super_gen + 1) {
error(
"invalid generation for extent %llu, have %llu expect (0, %llu]",
rec->start, rec->generation,
super_gen + 1);
cur_err = 1;
}
if (rec->refs != rec->extent_item_refs) { if (rec->refs != rec->extent_item_refs) {
fprintf(stderr, "ref mismatch on [%llu %llu] ", fprintf(stderr, "ref mismatch on [%llu %llu] ",
(unsigned long long)rec->start, (unsigned long long)rec->start,