RepoMirrors/btrfs-progs
1
0
Fork 0
mirror of https://github.com/kdave/btrfs-progs synced 2025-05-08 10:57:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

btrfs-progs: reset errno before strtoull()

Browse Source 
strtoull may return the boundary values, if the callers could expect
that and verify it then the errno must be reset before the call.

Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
David Sterba 2023-12-01 02:10:23 +01:00
parent e9a66cde91
commit a0468efe86
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
common/parse-utils.c
View File

@ -158,6 +158,7 @@ u64 parse_size_from_string(const char *s)
error("size value '%s' is less equal than 0", s); error("size value '%s' is less equal than 0", s);
exit(1); exit(1);
} }
errno = 0;
ret = strtoull(s, &endptr, 10); ret = strtoull(s, &endptr, 10);
if (endptr == s) { if (endptr == s) {
error("size value '%s' is invalid", s); error("size value '%s' is invalid", s);

2
common/sysfs-utils.c
View File

@ -108,6 +108,7 @@ int sysfs_read_file_u64(const char *name, u64 *value)
if (ret < 0) if (ret < 0)
goto out; goto out;
/* Raw value in any numeric format should work, followed by a newline. */ /* Raw value in any numeric format should work, followed by a newline. */
errno = 0;
*value = strtoull(str, NULL, 0); *value = strtoull(str, NULL, 0);
out: out:
close(fd); close(fd);
@ -127,6 +128,7 @@ int sysfs_read_fsid_file_u64(int fd, const char *name, u64 *value)
if (ret < 0) if (ret < 0)
goto out; goto out;
/* Raw value in any numeric format should work, followed by a newline. */ /* Raw value in any numeric format should work, followed by a newline. */
errno = 0;
*value = strtoull(str, NULL, 0); *value = strtoull(str, NULL, 0);
out: out:
close(fd); close(fd);