RepoMirrors
/
btrfs-progs
mirror of https://github.com/kdave/btrfs-progs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

btrfs-progs: don't leak fd in test_dev_for_mkfs() error paths 

Close fd before we return on error paths.

Resolves-Coverity-CID: 1125939
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Chris Mason <chris.mason@fusionio.com>
This commit is contained in:
Eric Sandeen 2013-11-06 17:15:44 -06:00 committed by Chris Mason
parent 12c3c9509b
commit 9dc137918f
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
utils.c
View File

@ -1928,10 +1928,12 @@ int test_dev_for_mkfs(char *file, int force_overwrite, char *estr)
if (fstat(fd, &st)) { if (fstat(fd, &st)) {
snprintf(estr, sz, "unable to stat %s: %s\n", file, snprintf(estr, sz, "unable to stat %s: %s\n", file,
strerror(errno)); strerror(errno));
close(fd);
return 1; return 1;
} }
if (!S_ISBLK(st.st_mode)) { if (!S_ISBLK(st.st_mode)) {
fprintf(stderr, "'%s' is not a block device\n", file); fprintf(stderr, "'%s' is not a block device\n", file);
close(fd);
return 1; return 1;
} }
close(fd); close(fd);