From 701c7d58db9a8f049ce5990a071fca8c56b93e04 Mon Sep 17 00:00:00 2001 From: Qu Wenruo Date: Wed, 18 Aug 2021 14:44:19 +0800 Subject: [PATCH] btrfs-progs: tests: don't check subpage related warnings for simple fsck tests For fsck tests, we check the subpage warnings for each type 1 test, but such type 1 tests are mostly read-only tests, and one of the test will trigger new subpage related warnings (fsck/018). For subpage related warnings, what we really care are write operations, including mkfs, btrfs-convert and repair, not those read-only tests. So skip the subpage warning check for fsck type 1 tests to prevent false alert of later more strict subpage warnings. Signed-off-by: Qu Wenruo Signed-off-by: David Sterba --- tests/fsck-tests.sh | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/fsck-tests.sh b/tests/fsck-tests.sh index ed18136f..d7150ad7 100755 --- a/tests/fsck-tests.sh +++ b/tests/fsck-tests.sh @@ -64,7 +64,14 @@ run_one_test() { fi _fail "test failed for case $(basename $testname)" fi - check_test_results "$RESULTS" "$testname" + # These tests have overriden check_image() and their images may + # have intentional unaligned metadata to trigger subpage + # warnings (like fsck/018), skip the check for their subpage + # warnings. + # + # We care about subpage related warnings for write operations + # (mkfs/convert/repair), not those read-only checks on crafted + # images. else # Type 1 check_all_images