RepoMirrors/btrfs-progs
1
0
Fork 0
mirror of https://github.com/kdave/btrfs-progs synced 2025-02-12 15:47:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

btrfs-progs: check: Fix lowmem mode stack overflow caused by fsck/023

Browse Source 
Lowmem mode fsck will overflow its stack since it will do infinite
backref check for tree reloc root.
We should not check backref if it's pointing to itself for tree reloc
root.

Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Qu Wenruo 2016-12-05 17:07:54 +08:00 committed by David Sterba
parent 0d8601ab6c
commit 54c8f9152f
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
cmds-check.c
View File

@ -9975,10 +9975,15 @@ static int check_tree_block_ref(struct btrfs_root *root,
u32 nodesize = root->nodesize;
u32 item_size;
u64 offset;
int tree_reloc_root = 0;
int found_ref = 0;
int err = 0;
int ret;
if (root->root_key.objectid == BTRFS_TREE_RELOC_OBJECTID &&
btrfs_header_bytenr(root->node) == bytenr)
tree_reloc_root = 1;
btrfs_init_path(&path);
key.objectid = bytenr;
if (btrfs_fs_incompat(root->fs_info, SKINNY_METADATA))
@ -10066,9 +10071,16 @@ static int check_tree_block_ref(struct btrfs_root *root,
(offset == root->objectid || offset == owner)) {
found_ref = 1;
} else if (type == BTRFS_SHARED_BLOCK_REF_KEY) {
/*
* Backref of tree reloc root points to itself, no need
* to check backref any more.
*/
if (tree_reloc_root)
found_ref = 1;
else
/* Check if the backref points to valid referencer */
found_ref = !check_tree_block_ref(root, NULL, offset,
level + 1, owner);
found_ref = !check_tree_block_ref(root, NULL,
offset, level + 1, owner);
}
if (found_ref)