RepoMirrors/btrfs-progs
1
0
Fork 0
mirror of https://github.com/kdave/btrfs-progs synced 2025-02-28 07:50:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

btrfs-progs: mkfs/rootdir: Don't follow symbolic link when calcuating size

Browse Source 
[BUG]
If we have a symbolic link in rootdir pointing to non-existing location,
mkfs.btrfs --rootdir will just fail:
------
$ mkfs.btrfs  -f --rootdir /tmp/rootdir/ /dev/data/btrfs
btrfs-progs v4.15.1
See http://btrfs.wiki.kernel.org for more information.

ERROR: ftw subdir walk of /tmp/rootdir/ failed: No such file or directory
------

[CAUSE]
Commit 599a0abed5 ("btrfs-progs: mkfs/rootdir: Use over-reserve method
to make size estimate easier") add extra ftw walk to estimate the
filesystem size.

Such default ftw walk will follow symbolic link and gives ENOENT error.

[FIX]
Use nftw() to specify FTW_PHYS so we won't follow symbolic link for size
calculation.

Issue: #109
Reported-by: Alexander Kanavin <alexander.kanavin@intel.com>
Fixes: 599a0abed5 ("btrfs-progs: mkfs/rootdir: Use over-reserve method to make size estimate easier")
Signed-off-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Qu Wenruo 2018-03-28 14:39:09 +08:00 committed by David Sterba
parent 3fd6a955f9
commit 4e6e5804f2
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
mkfs/rootdir.c
View File

@ -696,7 +696,7 @@ out:
} }
static int ftw_add_entry_size(const char *fpath, const struct stat *st, static int ftw_add_entry_size(const char *fpath, const struct stat *st,
int type) int type, struct FTW *ftwbuf)
{ {
/* /*
* Failed to read the directory, mostly due to EPERM. Abort ASAP, so * Failed to read the directory, mostly due to EPERM. Abort ASAP, so
@ -731,7 +731,12 @@ u64 btrfs_mkfs_size_dir(const char *dir_name, u32 sectorsize, u64 min_dev_size,
fs_block_size = sectorsize; fs_block_size = sectorsize;
ftw_data_size = 0; ftw_data_size = 0;
ftw_meta_nr_inode = 0; ftw_meta_nr_inode = 0;
ret = ftw(dir_name, ftw_add_entry_size, 10);
/*
* Symbolic link is not followed when creating files, so no need to
* follow them here.
*/
ret = nftw(dir_name, ftw_add_entry_size, 10, FTW_PHYS);
if (ret < 0) { if (ret < 0) {
error("ftw subdir walk of %s failed: %s", dir_name, error("ftw subdir walk of %s failed: %s", dir_name,
strerror(errno)); strerror(errno));