RepoMirrors/btrfs-progs
1
0
Fork 0
mirror of https://github.com/kdave/btrfs-progs synced 2025-04-25 04:27:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

btrfs-progs: check: Fix data csum check return value

Browse Source 
When --check-data-csum option found csum mismatch, btrfs check still
return 0.

Fix it so log-replay could automatically pause when it finds csum error.

Signed-off-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Qu Wenruo 2018-02-27 17:12:57 +08:00 committed by David Sterba
parent 9be7988677
commit 40b6bc1cb6
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
check/main.c
View File

@ -5381,6 +5381,13 @@ static int check_space_cache(struct btrfs_root *root)
return error ? -EINVAL : 0; return error ? -EINVAL : 0;
} }
/*
* Check data checksum for [@bytenr, @bytenr + @num_bytes).
*
* Return <0 for fatal error (fails to read checksum/data or allocate memory).
* Return >0 for csum mismatch for any copy.
* Return 0 if everything is OK.
*/
static int check_extent_csums(struct btrfs_root *root, u64 bytenr, static int check_extent_csums(struct btrfs_root *root, u64 bytenr,
u64 num_bytes, unsigned long leaf_offset, u64 num_bytes, unsigned long leaf_offset,
struct extent_buffer *eb) struct extent_buffer *eb)
@ -5398,6 +5405,7 @@ static int check_extent_csums(struct btrfs_root *root, u64 bytenr,
int ret = 0; int ret = 0;
int mirror; int mirror;
int num_copies; int num_copies;
bool csum_mismatch = false;
if (num_bytes % fs_info->sectorsize) if (num_bytes % fs_info->sectorsize)
return -EINVAL; return -EINVAL;
@ -5435,11 +5443,13 @@ static int check_extent_csums(struct btrfs_root *root, u64 bytenr,
tmp / fs_info->sectorsize * csum_size; tmp / fs_info->sectorsize * csum_size;
read_extent_buffer(eb, (char *)&csum_expected, read_extent_buffer(eb, (char *)&csum_expected,
csum_offset, csum_size); csum_offset, csum_size);
if (csum != csum_expected) if (csum != csum_expected) {
csum_mismatch = true;
fprintf(stderr, fprintf(stderr,
"mirror %d bytenr %llu csum %u expected csum %u\n", "mirror %d bytenr %llu csum %u expected csum %u\n",
mirror, bytenr + tmp, mirror, bytenr + tmp,
csum, csum_expected); csum, csum_expected);
}
data_checked += fs_info->sectorsize; data_checked += fs_info->sectorsize;
} }
} }
@ -5447,6 +5457,8 @@ static int check_extent_csums(struct btrfs_root *root, u64 bytenr,
} }
out: out:
free(data); free(data);
if (!ret && csum_mismatch)
ret = 1;
return ret; return ret;
} }
@ -5666,6 +5678,8 @@ static int check_csums(struct btrfs_root *root)
*/ */
if (ret < 0) if (ret < 0)
break; break;
if (ret > 0)
errors++;
skip_csum_check: skip_csum_check:
if (!num_bytes) { if (!num_bytes) {
offset = key.offset; offset = key.offset;