From 407f928cd2ae67a93a7ed618a7776cdacc8f6834 Mon Sep 17 00:00:00 2001
From: David Sterba <dsterba@suse.com>
Date: Tue, 12 Jan 2016 14:25:23 +0100
Subject: [PATCH] btrfs-progs: add function attributes for the printf-like
Reported by gcc -Wsuggest-attribute=format .
Signed-off-by: David Sterba <dsterba@suse.com>
---
string-table.c | 1 +
utils.h | 4 ++++
2 files changed, 5 insertions(+)
diff --git a/string-table.c b/string-table.c
index fc9d51ee..5eda1ac5 100644
--- a/string-table.c
+++ b/string-table.c
@@ -69,6 +69,7 @@ char *table_vprintf(struct string_table *tab, int column, int row,
* This function is like a printf, but store the results in a cell of
* the table.
*/
+__attribute__ ((format (printf, 4, 5)))
char *table_printf(struct string_table *tab, int column, int row,
char *fmt, ...)
{
diff --git a/utils.h b/utils.h
index 493c2e42..e522a8c3 100644
--- a/utils.h
+++ b/utils.h
@@ -276,6 +276,7 @@ const char *get_argv0_buf(void);
unsigned int get_unit_mode_from_arg(int *argc, char *argv[], int df_mode);
int string_is_numerical(const char *str);
+__attribute__ ((format (printf, 1, 2)))
static inline void warning(const char *fmt, ...)
{
va_list args;
@@ -287,6 +288,7 @@ static inline void warning(const char *fmt, ...)
fputc('\n', stderr);
}
+__attribute__ ((format (printf, 1, 2)))
static inline void error(const char *fmt, ...)
{
va_list args;
@@ -298,6 +300,7 @@ static inline void error(const char *fmt, ...)
fputc('\n', stderr);
}
+__attribute__ ((format (printf, 2, 3)))
static inline int warning_on(int condition, const char *fmt, ...)
{
va_list args;
@@ -314,6 +317,7 @@ static inline int warning_on(int condition, const char *fmt, ...)
return 1;
}
+__attribute__ ((format (printf, 2, 3)))
static inline int error_on(int condition, const char *fmt, ...)
{
va_list args;