RepoMirrors/btrfs-progs
1
0
Fork 0
mirror of https://github.com/kdave/btrfs-progs synced 2025-04-26 04:57:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

btrfs-progs: check: lowmem: remove parameter @trans of repair_tree_back_ref

Browse Source 
This patch removes parameter @trans of repair_tree_back_ref().
It calls try_avoid_extents_overwrite() and starts a transaction by
itself.

Note: This patch and next patches cause error in lowmem repair like:
"Error: Commit_root already set when starting transaction".
Such error will disappear after removing @trans finished.

Signed-off-by: Su Yue <suy.fnst@cn.fujitsu.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Su Yue 2018-05-08 16:30:08 +08:00 committed by David Sterba
parent 4c2b21acaa
commit 32705f2307
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
check/mode-lowmem.c
View File

@ -544,11 +544,11 @@ static int end_avoid_extents_overwrite(struct btrfs_fs_info *fs_info)
* *
* Returns error bits after repair. * Returns error bits after repair.
*/ */
static int repair_tree_block_ref(struct btrfs_trans_handle *trans, static int repair_tree_block_ref(struct btrfs_root *root,
struct btrfs_root *root,
struct extent_buffer *node, struct extent_buffer *node,
struct node_refs *nrefs, int level, int err) struct node_refs *nrefs, int level, int err)
{ {
struct btrfs_trans_handle *trans = NULL;
struct btrfs_fs_info *fs_info = root->fs_info; struct btrfs_fs_info *fs_info = root->fs_info;
struct btrfs_root *extent_root = fs_info->extent_root; struct btrfs_root *extent_root = fs_info->extent_root;
struct btrfs_path path; struct btrfs_path path;
@ -598,6 +598,16 @@ static int repair_tree_block_ref(struct btrfs_trans_handle *trans,
if (nrefs->full_backref[level] != 0) if (nrefs->full_backref[level] != 0)
flags |= BTRFS_BLOCK_FLAG_FULL_BACKREF; flags |= BTRFS_BLOCK_FLAG_FULL_BACKREF;
ret = avoid_extents_overwrite(root->fs_info);
if (ret)
goto out;
trans = btrfs_start_transaction(extent_root, 1);
if (IS_ERR(trans)) {
ret = PTR_ERR(trans);
trans = NULL;
error("fail to start transaction %s", strerror(-ret));
goto out;
}
/* insert an extent item */ /* insert an extent item */
if (insert_extent) { if (insert_extent) {
struct btrfs_disk_key copy_key; struct btrfs_disk_key copy_key;
@ -663,6 +673,8 @@ static int repair_tree_block_ref(struct btrfs_trans_handle *trans,
nrefs->refs[level]++; nrefs->refs[level]++;
out: out:
if (trans)
btrfs_commit_transaction(trans, extent_root);
btrfs_release_path(&path); btrfs_release_path(&path);
if (ret) { if (ret) {
error( error(
@ -4365,7 +4377,7 @@ static int walk_down_tree(struct btrfs_trans_handle *trans,
btrfs_header_owner(cur), nrefs); btrfs_header_owner(cur), nrefs);
if (repair && ret) if (repair && ret)
ret = repair_tree_block_ref(trans, root, ret = repair_tree_block_ref(root,
path->nodes[*level], nrefs, *level, ret); path->nodes[*level], nrefs, *level, ret);
err |= ret; err |= ret;