RepoMirrors/btrfs-progs
1
0
Fork 0
mirror of https://github.com/kdave/btrfs-progs synced 2025-05-16 23:08:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

btrfs-progs: tests: mkfs/018, fix check for truncate command failure

Browse Source 
Commit 31f477ee ("btrfs-progs: mkfs-tests: skip test if truncate fails
with EFBIG") tried to detect a failure in truncate command by checking
the $? expecting it to be an errno, when it actually returns 0 or 1.

To fix this test just check if the command failed (returned 1) and look
for the output, skipping the test if the OS cannot create a 6E file.

Fixes: #241
Tested-by: Erhard Furtner <erhard_f@mailbox.org>
Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Marcos Paulo de Souza 2020-04-08 09:37:28 -03:00 committed by David Sterba
parent 24dcafc491
commit 2f8aac5375
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tests/mkfs-tests/018-multidevice-overflow/test.sh
View File

@ -15,14 +15,15 @@ run_check_mkfs_test_dev
run_check_mount_test_dev
# truncate can fail with EFBIG if the OS cannot create a 6EiB file
run_mayfail $SUDO_HELPER truncate -s 6E "$TEST_MNT/img1"
out=$(run_mayfail_stdout $SUDO_HELPER truncate -s 6E "$TEST_MNT/img1" 2>&1)
ret=$?
if [ $ret == 27 ]; then
_not_run "Current kernel could not create a 6E file"
fi
if [ $ret -gt 0 ]; then
_fail "truncate -s 6E failed: $ret"
if [ $ret -ne 0 ]; then
run_check_umount_test_dev
if [[ "$out" == *"File too large"* ]]; then
_not_run "current kernel could not create a 6EiB file"
fi
_fail "command 'truncate -s 6E' failed: $out"
fi
run_check $SUDO_HELPER truncate -s 6E "$TEST_MNT/img2"