RepoMirrors/btrfs-progs
1
0
Fork 0
mirror of https://github.com/kdave/btrfs-progs synced 2025-04-20 14:05:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

btrfs-progs: balance convert: add a warning and countdown for RAID56 conversion

Browse Source 
Similar to the mkfs warning, add a warning to btrfs balance convert
options, with a countdown to allow the user to have time to cancel the
operation.

Issue: #265
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Josef Bacik 2020-08-25 13:13:29 -04:00 committed by David Sterba
parent 73487311e9
commit 1ed5db8db4
1 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
cmds/balance.c
View File

@ -526,6 +526,7 @@ static int cmd_balance_start(const struct cmd_struct *cmd,
int background = 0; int background = 0;
bool enqueue = false; bool enqueue = false;
unsigned start_flags = 0; unsigned start_flags = 0;
bool warned = false;
int i; int i;
memset(&args, 0, sizeof(args)); memset(&args, 0, sizeof(args));
@ -632,11 +633,37 @@ static int cmd_balance_start(const struct cmd_struct *cmd,
/* soft makes sense only when convert for corresponding type is set */ /* soft makes sense only when convert for corresponding type is set */
for (i = 0; ptrs[i]; i++) { for (i = 0; ptrs[i]; i++) {
int delay = 10;
if ((ptrs[i]->flags & BTRFS_BALANCE_ARGS_SOFT) && if ((ptrs[i]->flags & BTRFS_BALANCE_ARGS_SOFT) &&
!(ptrs[i]->flags & BTRFS_BALANCE_ARGS_CONVERT)) { !(ptrs[i]->flags & BTRFS_BALANCE_ARGS_CONVERT)) {
error("'soft' option can be used only when converting profiles"); error("'soft' option can be used only when converting profiles");
return 1; return 1;
} }
if (!(ptrs[i]->flags & BTRFS_BALANCE_ARGS_CONVERT))
continue;
if (!(ptrs[i]->flags & (BTRFS_BLOCK_GROUP_RAID6 |
BTRFS_BLOCK_GROUP_RAID5)))
continue;
if (warned)
continue;
warned = true;
printf("WARNING:\n\n");
printf("\tRAID5/6 support has known problems and is strongly discouraged\n");
printf("\tto be used besides testing or evaluation. It is recommended that\n");
printf("\tyou use one of the other RAID profiles.\n");
printf("\tThe operation will continue in %d seconds.\n", delay);
printf("\tUse Ctrl-C to stop.\n");
while (delay) {
printf("%2d", delay--);
fflush(stdout);
sleep(1);
}
printf("\nStarting conversion to RAID5/6.\n");
} }
if (!(start_flags & BALANCE_START_FILTERS) && !(start_flags & BALANCE_START_NOWARN)) { if (!(start_flags & BALANCE_START_FILTERS) && !(start_flags & BALANCE_START_NOWARN)) {