2008-11-18 15:40:06 +00:00
|
|
|
/*
|
|
|
|
* Copyright (C) 2008 Oracle. All rights reserved.
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU General Public
|
|
|
|
* License v2 as published by the Free Software Foundation.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public
|
|
|
|
* License along with this program; if not, write to the
|
|
|
|
* Free Software Foundation, Inc., 59 Temple Place - Suite 330,
|
|
|
|
* Boston, MA 021110-1307, USA.
|
|
|
|
*/
|
|
|
|
|
2022-09-14 15:06:52 +00:00
|
|
|
#include "kerncompat.h"
|
2008-11-18 15:40:06 +00:00
|
|
|
#include <fcntl.h>
|
|
|
|
#include <unistd.h>
|
2015-06-10 22:04:19 +00:00
|
|
|
#include <getopt.h>
|
2022-09-15 11:10:53 +00:00
|
|
|
#include <errno.h>
|
|
|
|
#include <stdbool.h>
|
2022-09-14 15:06:52 +00:00
|
|
|
#include <uuid/uuid.h>
|
2023-08-28 20:12:13 +00:00
|
|
|
#include "kernel-shared/accessors.h"
|
2020-08-18 13:56:04 +00:00
|
|
|
#include "kernel-shared/ctree.h"
|
2020-08-18 13:56:04 +00:00
|
|
|
#include "kernel-shared/disk-io.h"
|
2020-08-18 13:56:04 +00:00
|
|
|
#include "kernel-shared/transaction.h"
|
2020-08-18 13:56:04 +00:00
|
|
|
#include "kernel-shared/volumes.h"
|
2023-05-02 01:01:45 +00:00
|
|
|
#include "kernel-shared/free-space-tree.h"
|
btrfs-progs: tune: properly open zoned devices for RW
[BUG]
There is a report that, for zoned devices btrfstune is unable to convert
it to block group tree.
# btrfstune /dev/nullb0 --convert-to-block-group-tree
Error reading 1342193664, -1
Error reading 1342193664, -1
ERROR: cannot read chunk root
ERROR: open ctree failed
[CAUSE]
For read-write opened zoned devices, all the read/write has to be
aligned to its sector size.
However btrfs stores its metadata by extent_buffer::data[], which has
all the structures before it, thus never aligned to zoned device sector
size.
Normally we would require btrfs_pread() and btrfs_pwrite() to do the
extra alignment, but during open_ctree(), we are not aware if a device
is zoned or not.
Thus we rely on if the fd is opened with O_DIRECT flag, if the fd has
O_DIRECT, then we would temporarily set fs_info->zoned for chunk tree
read.
Unforunately not all open_ctree_fd() callers have the flags set
properly, and btrfstune is one of the missing call site.
This makes all the read not properly aligned and cause read failure.
[FIX]
Just manually check if the target device is a zoned one, and set
O_DIRECT accordingly.
Issue: #765
Pull-request: #767
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Naohiro Aota <naohiro.aota@wdc.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
2024-03-26 00:22:44 +00:00
|
|
|
#include "kernel-shared/zoned.h"
|
2022-09-14 15:06:52 +00:00
|
|
|
#include "common/utils.h"
|
2021-04-29 17:52:15 +00:00
|
|
|
#include "common/open-utils.h"
|
2021-09-21 13:38:19 +00:00
|
|
|
#include "common/device-scan.h"
|
2022-09-15 11:10:53 +00:00
|
|
|
#include "common/messages.h"
|
2023-08-28 20:12:13 +00:00
|
|
|
#include "common/parse-utils.h"
|
2022-09-15 21:15:17 +00:00
|
|
|
#include "common/string-utils.h"
|
2019-06-19 23:46:21 +00:00
|
|
|
#include "common/help.h"
|
2015-06-21 16:23:19 +00:00
|
|
|
#include "common/box.h"
|
2023-10-09 04:46:59 +00:00
|
|
|
#include "common/clear-cache.h"
|
2023-01-11 17:49:52 +00:00
|
|
|
#include "cmds/commands.h"
|
2023-01-18 14:48:21 +00:00
|
|
|
#include "tune/tune.h"
|
2008-11-18 15:40:06 +00:00
|
|
|
|
|
|
|
static char *device;
|
2015-01-19 07:27:30 +00:00
|
|
|
static int force = 0;
|
2008-11-18 15:40:06 +00:00
|
|
|
|
2015-06-02 16:24:33 +00:00
|
|
|
static int set_super_incompat_flags(struct btrfs_root *root, u64 flags)
|
2013-03-15 19:32:16 +00:00
|
|
|
{
|
|
|
|
struct btrfs_trans_handle *trans;
|
|
|
|
struct btrfs_super_block *disk_super;
|
|
|
|
u64 super_flags;
|
2015-06-02 16:24:33 +00:00
|
|
|
int ret;
|
2013-03-15 19:32:16 +00:00
|
|
|
|
2013-04-04 13:57:50 +00:00
|
|
|
disk_super = root->fs_info->super_copy;
|
2013-03-15 19:32:16 +00:00
|
|
|
super_flags = btrfs_super_incompat_flags(disk_super);
|
2015-06-02 16:24:33 +00:00
|
|
|
super_flags |= flags;
|
2013-03-15 19:32:16 +00:00
|
|
|
trans = btrfs_start_transaction(root, 1);
|
2017-08-28 14:48:16 +00:00
|
|
|
BUG_ON(IS_ERR(trans));
|
2013-03-15 19:32:16 +00:00
|
|
|
btrfs_set_super_incompat_flags(disk_super, super_flags);
|
2015-06-02 16:24:33 +00:00
|
|
|
ret = btrfs_commit_transaction(trans, root);
|
2013-03-15 19:32:16 +00:00
|
|
|
|
2015-06-02 16:24:33 +00:00
|
|
|
return ret;
|
2013-03-15 19:32:16 +00:00
|
|
|
}
|
|
|
|
|
2023-05-02 01:01:45 +00:00
|
|
|
static int convert_to_fst(struct btrfs_fs_info *fs_info)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
/* We may have invalid old v2 cache, clear them first. */
|
|
|
|
if (btrfs_fs_compat_ro(fs_info, FREE_SPACE_TREE)) {
|
|
|
|
ret = btrfs_clear_free_space_tree(fs_info);
|
|
|
|
if (ret < 0) {
|
|
|
|
errno = -ret;
|
|
|
|
error("failed to clear stale v2 free space cache: %m");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
ret = btrfs_clear_v1_cache(fs_info);
|
|
|
|
if (ret < 0) {
|
|
|
|
errno = -ret;
|
|
|
|
error("failed to clear v1 free space cache: %m");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = btrfs_create_free_space_tree(fs_info);
|
|
|
|
if (ret < 0) {
|
|
|
|
errno = -ret;
|
|
|
|
error("failed to create free space tree: %m");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
pr_verbose(LOG_DEFAULT, "Converted to free space tree feature\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2023-01-11 17:49:52 +00:00
|
|
|
static const char * const tune_usage[] = {
|
|
|
|
"btrfstune [options] device",
|
|
|
|
"Tune settings of filesystem features on an unmounted device",
|
|
|
|
"",
|
|
|
|
"Options:",
|
|
|
|
"Change feature status:",
|
|
|
|
OPTLINE("-r", "enable extended inode refs (mkfs: extref, for hardlink limits)"),
|
|
|
|
OPTLINE("-x", "enable skinny metadata extent refs (mkfs: skinny-metadata)"),
|
|
|
|
OPTLINE("-n", "enable no-holes feature (mkfs: no-holes, more efficient sparse file representation)"),
|
|
|
|
OPTLINE("-S <0|1>", "set/unset seeding status of a device"),
|
2023-09-27 17:46:47 +00:00
|
|
|
OPTLINE("-q", "enable simple quotas on the file system. (mkfs: squota)"),
|
2023-04-27 12:21:24 +00:00
|
|
|
OPTLINE("--convert-to-block-group-tree", "convert filesystem to track block groups in "
|
|
|
|
"the separate block-group-tree instead of extent tree (sets the incompat bit)"),
|
|
|
|
OPTLINE("--convert-from-block-group-tree",
|
|
|
|
"convert the block group tree back to extent tree (remove the incompat bit)"),
|
2023-05-02 01:01:45 +00:00
|
|
|
OPTLINE("--convert-to-free-space-tree", "convert filesystem to use free space tree (v2 cache)"),
|
2023-01-11 17:49:52 +00:00
|
|
|
"",
|
|
|
|
"UUID changes:",
|
|
|
|
OPTLINE("-u", "rewrite fsid, use a random one"),
|
|
|
|
OPTLINE("-U UUID", "rewrite fsid to UUID"),
|
2024-05-16 04:19:03 +00:00
|
|
|
OPTLINE("-m", "change fsid to a random UUID, copy original fsid into "
|
|
|
|
"metadata_uuid if it's not NULL, this is an incompat change "
|
|
|
|
"(more lightweight than -u|-U)"),
|
|
|
|
OPTLINE("-M UUID", "change fsid to UUID, copy original fsid into "
|
|
|
|
"metadata_uuid if it's not NULL, this is an incompat change "
|
|
|
|
"(more lightweight than -u|-U)"),
|
2023-01-11 17:49:52 +00:00
|
|
|
"",
|
|
|
|
"General:",
|
|
|
|
OPTLINE("-f", "allow dangerous operations, make sure that you are aware of the dangers"),
|
|
|
|
OPTLINE("--help", "print this help"),
|
2022-05-10 12:19:57 +00:00
|
|
|
#if EXPERIMENTAL
|
2023-01-11 17:49:52 +00:00
|
|
|
"",
|
|
|
|
"EXPERIMENTAL FEATURES:",
|
|
|
|
OPTLINE("--csum CSUM", "switch checksum for data and metadata to CSUM"),
|
2021-02-07 18:23:44 +00:00
|
|
|
#endif
|
2023-01-11 17:49:52 +00:00
|
|
|
NULL
|
|
|
|
};
|
|
|
|
|
2023-08-23 11:11:05 +00:00
|
|
|
enum btrfstune_group_enum {
|
|
|
|
/* Extent/block group tree feature. */
|
|
|
|
EXTENT_TREE,
|
|
|
|
|
|
|
|
/* V1/v2 free space cache. */
|
|
|
|
SPACE_CACHE,
|
|
|
|
|
|
|
|
/* Metadata UUID. */
|
|
|
|
METADATA_UUID,
|
|
|
|
|
|
|
|
/* FSID change. */
|
|
|
|
FSID_CHANGE,
|
|
|
|
|
|
|
|
/* Seed device. */
|
|
|
|
SEED,
|
|
|
|
|
|
|
|
/* Csum conversion */
|
|
|
|
CSUM_CHANGE,
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Legacy features (which later become default), including:
|
|
|
|
* - no-holes
|
|
|
|
* - extref
|
|
|
|
* - skinny-metadata
|
|
|
|
*/
|
|
|
|
LEGACY,
|
|
|
|
|
2023-09-27 17:46:47 +00:00
|
|
|
/* Qgroup options */
|
|
|
|
QGROUP,
|
|
|
|
|
2023-08-23 11:11:05 +00:00
|
|
|
BTRFSTUNE_NR_GROUPS,
|
|
|
|
};
|
|
|
|
|
|
|
|
static bool btrfstune_cmd_groups[BTRFSTUNE_NR_GROUPS] = { 0 };
|
|
|
|
|
2024-06-28 21:42:16 +00:00
|
|
|
static unsigned int btrfstune_count_set_groups(void)
|
2023-08-23 11:11:05 +00:00
|
|
|
{
|
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
for (int i = 0; i < BTRFSTUNE_NR_GROUPS; i++) {
|
|
|
|
if (btrfstune_cmd_groups[i])
|
|
|
|
ret++;
|
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2023-01-11 17:49:52 +00:00
|
|
|
static const struct cmd_struct tune_cmd = {
|
|
|
|
.usagestr = tune_usage
|
|
|
|
};
|
|
|
|
|
2015-06-21 16:23:19 +00:00
|
|
|
int BOX_MAIN(btrfstune)(int argc, char *argv[])
|
2008-11-18 15:40:06 +00:00
|
|
|
{
|
|
|
|
struct btrfs_root *root;
|
2023-08-14 15:27:58 +00:00
|
|
|
struct btrfs_fs_info *fs_info;
|
2016-08-19 14:20:36 +00:00
|
|
|
unsigned ctree_flags = OPEN_CTREE_WRITES;
|
2008-11-18 15:40:06 +00:00
|
|
|
int seeding_flag = 0;
|
2014-02-20 01:30:52 +00:00
|
|
|
u64 seeding_value = 0;
|
2015-05-15 06:28:25 +00:00
|
|
|
int random_fsid = 0;
|
2018-10-11 15:04:00 +00:00
|
|
|
int change_metadata_uuid = 0;
|
2023-04-18 22:41:14 +00:00
|
|
|
bool to_extent_tree = false;
|
2022-08-09 06:03:54 +00:00
|
|
|
bool to_bg_tree = false;
|
2023-05-02 01:01:45 +00:00
|
|
|
bool to_fst = false;
|
2021-02-07 18:23:44 +00:00
|
|
|
int csum_type = -1;
|
2015-05-15 06:28:25 +00:00
|
|
|
char *new_fsid_str = NULL;
|
2008-11-18 15:40:06 +00:00
|
|
|
int ret;
|
2015-06-02 16:24:33 +00:00
|
|
|
u64 super_flags = 0;
|
2023-09-27 17:46:47 +00:00
|
|
|
int quota = 0;
|
2018-06-18 15:56:22 +00:00
|
|
|
int fd = -1;
|
btrfs-progs: tune: properly open zoned devices for RW
[BUG]
There is a report that, for zoned devices btrfstune is unable to convert
it to block group tree.
# btrfstune /dev/nullb0 --convert-to-block-group-tree
Error reading 1342193664, -1
Error reading 1342193664, -1
ERROR: cannot read chunk root
ERROR: open ctree failed
[CAUSE]
For read-write opened zoned devices, all the read/write has to be
aligned to its sector size.
However btrfs stores its metadata by extent_buffer::data[], which has
all the structures before it, thus never aligned to zoned device sector
size.
Normally we would require btrfs_pread() and btrfs_pwrite() to do the
extra alignment, but during open_ctree(), we are not aware if a device
is zoned or not.
Thus we rely on if the fd is opened with O_DIRECT flag, if the fd has
O_DIRECT, then we would temporarily set fs_info->zoned for chunk tree
read.
Unforunately not all open_ctree_fd() callers have the flags set
properly, and btrfstune is one of the missing call site.
This makes all the read not properly aligned and cause read failure.
[FIX]
Just manually check if the target device is a zoned one, and set
O_DIRECT accordingly.
Issue: #765
Pull-request: #767
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Naohiro Aota <naohiro.aota@wdc.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
2024-03-26 00:22:44 +00:00
|
|
|
int oflags = O_RDWR;
|
2008-11-18 15:40:06 +00:00
|
|
|
|
2023-02-15 18:06:24 +00:00
|
|
|
btrfs_config_init();
|
|
|
|
|
2008-11-18 15:40:06 +00:00
|
|
|
while(1) {
|
2023-04-11 02:31:06 +00:00
|
|
|
enum { GETOPT_VAL_CSUM = GETOPT_VAL_FIRST,
|
2023-04-18 22:41:14 +00:00
|
|
|
GETOPT_VAL_ENABLE_BLOCK_GROUP_TREE,
|
2023-05-02 01:01:45 +00:00
|
|
|
GETOPT_VAL_DISABLE_BLOCK_GROUP_TREE,
|
2023-10-13 20:44:41 +00:00
|
|
|
GETOPT_VAL_ENABLE_FREE_SPACE_TREE,
|
|
|
|
GETOPT_VAL_ENABLE_SIMPLE_QUOTA,
|
|
|
|
|
|
|
|
};
|
2015-06-10 22:04:19 +00:00
|
|
|
static const struct option long_options[] = {
|
|
|
|
{ "help", no_argument, NULL, GETOPT_VAL_HELP},
|
2023-04-27 12:21:24 +00:00
|
|
|
{ "convert-to-block-group-tree", no_argument, NULL,
|
2023-04-11 02:31:06 +00:00
|
|
|
GETOPT_VAL_ENABLE_BLOCK_GROUP_TREE},
|
2023-04-27 12:21:24 +00:00
|
|
|
{ "convert-from-block-group-tree", no_argument, NULL,
|
2023-04-18 22:41:14 +00:00
|
|
|
GETOPT_VAL_DISABLE_BLOCK_GROUP_TREE},
|
2023-05-02 01:01:45 +00:00
|
|
|
{ "convert-to-free-space-tree", no_argument, NULL,
|
|
|
|
GETOPT_VAL_ENABLE_FREE_SPACE_TREE},
|
2023-10-13 20:44:41 +00:00
|
|
|
{ "enable-simple-quota", no_argument, NULL,
|
|
|
|
GETOPT_VAL_ENABLE_SIMPLE_QUOTA },
|
2022-05-10 12:19:57 +00:00
|
|
|
#if EXPERIMENTAL
|
2021-02-07 18:23:44 +00:00
|
|
|
{ "csum", required_argument, NULL, GETOPT_VAL_CSUM },
|
|
|
|
#endif
|
2015-06-10 22:04:19 +00:00
|
|
|
{ NULL, 0, NULL, 0 }
|
|
|
|
};
|
2023-10-13 20:44:41 +00:00
|
|
|
int c = getopt_long(argc, argv, "S:rxfuU:nmM:", long_options, NULL);
|
2015-06-10 22:04:19 +00:00
|
|
|
|
2008-11-18 15:40:06 +00:00
|
|
|
if (c < 0)
|
|
|
|
break;
|
|
|
|
switch(c) {
|
|
|
|
case 'S':
|
|
|
|
seeding_flag = 1;
|
2014-02-20 01:30:52 +00:00
|
|
|
seeding_value = arg_strtou64(optarg);
|
2023-08-23 11:11:05 +00:00
|
|
|
btrfstune_cmd_groups[SEED] = true;
|
2008-11-18 15:40:06 +00:00
|
|
|
break;
|
2013-01-31 18:57:53 +00:00
|
|
|
case 'r':
|
2015-06-02 16:24:33 +00:00
|
|
|
super_flags |= BTRFS_FEATURE_INCOMPAT_EXTENDED_IREF;
|
2023-08-23 11:11:05 +00:00
|
|
|
btrfstune_cmd_groups[LEGACY] = true;
|
2013-01-31 18:57:53 +00:00
|
|
|
break;
|
2013-03-15 19:32:16 +00:00
|
|
|
case 'x':
|
2015-06-02 16:24:33 +00:00
|
|
|
super_flags |= BTRFS_FEATURE_INCOMPAT_SKINNY_METADATA;
|
2023-08-23 11:11:05 +00:00
|
|
|
btrfstune_cmd_groups[LEGACY] = true;
|
2013-03-15 19:32:16 +00:00
|
|
|
break;
|
2015-06-02 16:41:01 +00:00
|
|
|
case 'n':
|
|
|
|
super_flags |= BTRFS_FEATURE_INCOMPAT_NO_HOLES;
|
2023-08-23 11:11:05 +00:00
|
|
|
btrfstune_cmd_groups[LEGACY] = true;
|
2015-06-02 16:41:01 +00:00
|
|
|
break;
|
2014-07-07 01:54:52 +00:00
|
|
|
case 'f':
|
|
|
|
force = 1;
|
|
|
|
break;
|
2015-05-15 06:28:25 +00:00
|
|
|
case 'U':
|
|
|
|
ctree_flags |= OPEN_CTREE_IGNORE_FSID_MISMATCH;
|
|
|
|
new_fsid_str = optarg;
|
2023-08-23 11:11:05 +00:00
|
|
|
btrfstune_cmd_groups[FSID_CHANGE] = true;
|
2015-05-15 06:28:25 +00:00
|
|
|
break;
|
|
|
|
case 'u':
|
|
|
|
ctree_flags |= OPEN_CTREE_IGNORE_FSID_MISMATCH;
|
|
|
|
random_fsid = 1;
|
2023-08-23 11:11:05 +00:00
|
|
|
btrfstune_cmd_groups[FSID_CHANGE] = true;
|
2015-05-15 06:28:25 +00:00
|
|
|
break;
|
2018-10-11 15:04:00 +00:00
|
|
|
case 'M':
|
|
|
|
ctree_flags |= OPEN_CTREE_IGNORE_FSID_MISMATCH;
|
|
|
|
change_metadata_uuid = 1;
|
|
|
|
new_fsid_str = optarg;
|
2023-08-23 11:11:05 +00:00
|
|
|
btrfstune_cmd_groups[METADATA_UUID] = true;
|
2018-10-11 15:04:00 +00:00
|
|
|
break;
|
|
|
|
case 'm':
|
|
|
|
ctree_flags |= OPEN_CTREE_IGNORE_FSID_MISMATCH;
|
|
|
|
change_metadata_uuid = 1;
|
2023-08-23 11:11:05 +00:00
|
|
|
btrfstune_cmd_groups[METADATA_UUID] = true;
|
2018-10-11 15:04:00 +00:00
|
|
|
break;
|
2023-04-11 02:31:06 +00:00
|
|
|
case GETOPT_VAL_ENABLE_BLOCK_GROUP_TREE:
|
|
|
|
to_bg_tree = true;
|
2023-08-23 11:11:05 +00:00
|
|
|
btrfstune_cmd_groups[EXTENT_TREE] = true;
|
2023-04-11 02:31:06 +00:00
|
|
|
break;
|
2023-04-18 22:41:14 +00:00
|
|
|
case GETOPT_VAL_DISABLE_BLOCK_GROUP_TREE:
|
|
|
|
to_extent_tree = true;
|
2023-08-23 11:11:05 +00:00
|
|
|
btrfstune_cmd_groups[EXTENT_TREE] = true;
|
2023-04-18 22:41:14 +00:00
|
|
|
break;
|
2023-05-02 01:01:45 +00:00
|
|
|
case GETOPT_VAL_ENABLE_FREE_SPACE_TREE:
|
|
|
|
to_fst = true;
|
2023-08-23 11:11:05 +00:00
|
|
|
btrfstune_cmd_groups[SPACE_CACHE] = true;
|
2023-05-02 01:01:45 +00:00
|
|
|
break;
|
2023-10-13 20:44:41 +00:00
|
|
|
case GETOPT_VAL_ENABLE_SIMPLE_QUOTA:
|
|
|
|
quota = 1;
|
|
|
|
btrfstune_cmd_groups[QGROUP] = true;
|
|
|
|
break;
|
2022-05-10 12:19:57 +00:00
|
|
|
#if EXPERIMENTAL
|
2021-02-07 18:23:44 +00:00
|
|
|
case GETOPT_VAL_CSUM:
|
2022-10-20 14:36:10 +00:00
|
|
|
btrfs_warn_experimental(
|
|
|
|
"Switching checksums is experimental, do not use for valuable data!");
|
2021-02-07 18:23:44 +00:00
|
|
|
ctree_flags |= OPEN_CTREE_SKIP_CSUM_CHECK;
|
|
|
|
csum_type = parse_csum_type(optarg);
|
2023-08-23 11:11:05 +00:00
|
|
|
btrfstune_cmd_groups[CSUM_CHANGE] = true;
|
2021-02-07 18:23:44 +00:00
|
|
|
break;
|
|
|
|
#endif
|
2015-06-10 22:04:19 +00:00
|
|
|
case GETOPT_VAL_HELP:
|
2008-11-18 15:40:06 +00:00
|
|
|
default:
|
2023-02-21 23:28:06 +00:00
|
|
|
usage(&tune_cmd, c != GETOPT_VAL_HELP);
|
2008-11-18 15:40:06 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-07-16 03:59:46 +00:00
|
|
|
set_argv0(argv);
|
2008-11-18 15:40:06 +00:00
|
|
|
device = argv[optind];
|
2023-08-02 23:29:46 +00:00
|
|
|
if (check_argc_exact(argc - optind, 1)) {
|
|
|
|
ret = 1;
|
|
|
|
goto free_out;
|
|
|
|
}
|
2008-11-18 15:40:06 +00:00
|
|
|
|
2023-08-23 11:11:05 +00:00
|
|
|
if (btrfstune_count_set_groups() == 0) {
|
|
|
|
error("at least one option should be specified");
|
|
|
|
usage(&tune_cmd, 1);
|
2023-08-02 23:29:46 +00:00
|
|
|
ret = 1;
|
|
|
|
goto free_out;
|
2015-05-15 06:28:25 +00:00
|
|
|
}
|
2023-08-23 11:11:05 +00:00
|
|
|
if (btrfstune_count_set_groups() > 1) {
|
|
|
|
error("too many conflicting options specified");
|
2023-02-21 23:28:06 +00:00
|
|
|
usage(&tune_cmd, 1);
|
2023-08-02 23:29:46 +00:00
|
|
|
ret = 1;
|
|
|
|
goto free_out;
|
2013-12-18 03:52:45 +00:00
|
|
|
}
|
2023-08-23 11:11:05 +00:00
|
|
|
if (random_fsid && new_fsid_str) {
|
|
|
|
error("random fsid can't be used with specified fsid");
|
|
|
|
ret = 1;
|
|
|
|
goto free_out;
|
|
|
|
}
|
2015-05-15 06:28:25 +00:00
|
|
|
if (new_fsid_str) {
|
|
|
|
uuid_t tmp;
|
|
|
|
|
|
|
|
ret = uuid_parse(new_fsid_str, tmp);
|
|
|
|
if (ret < 0) {
|
2016-09-30 11:00:24 +00:00
|
|
|
error("could not parse UUID: %s", new_fsid_str);
|
2023-08-02 23:29:46 +00:00
|
|
|
ret = 1;
|
|
|
|
goto free_out;
|
2015-05-15 06:28:25 +00:00
|
|
|
}
|
|
|
|
if (!test_uuid_unique(new_fsid_str)) {
|
2016-09-30 11:00:24 +00:00
|
|
|
error("fsid %s is not unique", new_fsid_str);
|
2023-08-02 23:29:46 +00:00
|
|
|
ret = 1;
|
|
|
|
goto free_out;
|
2015-05-15 06:28:25 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
btrfs-progs: tune: properly open zoned devices for RW
[BUG]
There is a report that, for zoned devices btrfstune is unable to convert
it to block group tree.
# btrfstune /dev/nullb0 --convert-to-block-group-tree
Error reading 1342193664, -1
Error reading 1342193664, -1
ERROR: cannot read chunk root
ERROR: open ctree failed
[CAUSE]
For read-write opened zoned devices, all the read/write has to be
aligned to its sector size.
However btrfs stores its metadata by extent_buffer::data[], which has
all the structures before it, thus never aligned to zoned device sector
size.
Normally we would require btrfs_pread() and btrfs_pwrite() to do the
extra alignment, but during open_ctree(), we are not aware if a device
is zoned or not.
Thus we rely on if the fd is opened with O_DIRECT flag, if the fd has
O_DIRECT, then we would temporarily set fs_info->zoned for chunk tree
read.
Unforunately not all open_ctree_fd() callers have the flags set
properly, and btrfstune is one of the missing call site.
This makes all the read not properly aligned and cause read failure.
[FIX]
Just manually check if the target device is a zoned one, and set
O_DIRECT accordingly.
Issue: #765
Pull-request: #767
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Naohiro Aota <naohiro.aota@wdc.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
2024-03-26 00:22:44 +00:00
|
|
|
if (zoned_model(device) == ZONED_HOST_MANAGED)
|
|
|
|
oflags |= O_DIRECT;
|
|
|
|
fd = open(device, oflags);
|
2018-06-18 15:56:22 +00:00
|
|
|
if (fd < 0) {
|
|
|
|
error("mount check: cannot open %s: %m", device);
|
2023-08-02 23:29:46 +00:00
|
|
|
ret = 1;
|
|
|
|
goto free_out;
|
2018-06-18 15:56:22 +00:00
|
|
|
}
|
|
|
|
|
2018-06-18 16:15:12 +00:00
|
|
|
ret = check_mounted_where(fd, device, NULL, 0, NULL,
|
2023-06-13 10:26:57 +00:00
|
|
|
SBREAD_IGNORE_FSID_MISMATCH, false);
|
2014-02-20 02:49:03 +00:00
|
|
|
if (ret < 0) {
|
2018-10-25 12:10:54 +00:00
|
|
|
errno = -ret;
|
|
|
|
error("could not check mount status of %s: %m", device);
|
2018-06-18 15:56:22 +00:00
|
|
|
close(fd);
|
2023-08-02 23:29:46 +00:00
|
|
|
ret = 1;
|
|
|
|
goto free_out;
|
2014-02-20 02:49:03 +00:00
|
|
|
} else if (ret) {
|
2016-09-30 11:00:24 +00:00
|
|
|
error("%s is mounted", device);
|
2018-06-18 15:56:22 +00:00
|
|
|
close(fd);
|
2023-08-02 23:29:46 +00:00
|
|
|
ret = 1;
|
|
|
|
goto free_out;
|
2008-11-18 15:40:06 +00:00
|
|
|
}
|
|
|
|
|
2023-09-15 04:08:56 +00:00
|
|
|
/*
|
|
|
|
* For fsid changes we must use the latest device (not necessarily the
|
|
|
|
* one specified on command line so the matching of the device
|
|
|
|
* belonging to the filesystem works.
|
|
|
|
*/
|
|
|
|
if (change_metadata_uuid || random_fsid || new_fsid_str)
|
|
|
|
ctree_flags |= OPEN_CTREE_USE_LATEST_BDEV;
|
|
|
|
|
2018-06-18 15:56:22 +00:00
|
|
|
root = open_ctree_fd(fd, device, 0, ctree_flags);
|
2008-11-18 15:40:06 +00:00
|
|
|
|
2013-01-21 15:57:25 +00:00
|
|
|
if (!root) {
|
2016-09-30 11:00:24 +00:00
|
|
|
error("open ctree failed");
|
2023-08-02 23:29:46 +00:00
|
|
|
ret = 1;
|
|
|
|
goto free_out;
|
2013-01-21 15:57:25 +00:00
|
|
|
}
|
2023-08-14 15:27:58 +00:00
|
|
|
fs_info = root->fs_info;
|
2013-01-21 15:57:25 +00:00
|
|
|
|
2023-08-02 23:29:41 +00:00
|
|
|
/*
|
|
|
|
* As we increment the generation number here, it is unlikely that the
|
|
|
|
* missing device will have a higher generation number, and the kernel
|
|
|
|
* won't use its super block for any further commits, even if it is not
|
|
|
|
* missing during mount.
|
|
|
|
*
|
|
|
|
* So, we allow all operations except for -m, -M, -u, and -U, as these
|
|
|
|
* operations also change the fsid/metadata_uuid, which are key
|
|
|
|
* parameters for assembling the devices and need to be consistent on
|
|
|
|
* all the partner devices.
|
|
|
|
*/
|
|
|
|
if ((change_metadata_uuid || random_fsid || new_fsid_str) &&
|
2023-08-14 15:27:58 +00:00
|
|
|
fs_info->fs_devices->missing_devices > 0) {
|
2023-08-02 23:29:41 +00:00
|
|
|
error("missing %lld device(s), failing the command",
|
2023-08-14 15:27:58 +00:00
|
|
|
fs_info->fs_devices->missing_devices);
|
2023-08-02 23:29:41 +00:00
|
|
|
ret = 1;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2023-04-18 22:41:14 +00:00
|
|
|
if (to_bg_tree) {
|
|
|
|
if (to_extent_tree) {
|
2023-04-27 12:21:24 +00:00
|
|
|
error("option --convert-to-block-group-tree conflicts with --convert-from-block-group-tree");
|
2023-08-23 11:11:05 +00:00
|
|
|
ret = -EINVAL;
|
2023-04-18 22:41:14 +00:00
|
|
|
goto out;
|
|
|
|
}
|
2023-08-14 15:27:58 +00:00
|
|
|
if (btrfs_fs_compat_ro(fs_info, BLOCK_GROUP_TREE)) {
|
2022-08-09 06:03:54 +00:00
|
|
|
error("the filesystem already has block group tree feature");
|
2023-08-23 11:11:05 +00:00
|
|
|
ret = -EINVAL;
|
2022-08-09 06:03:54 +00:00
|
|
|
goto out;
|
|
|
|
}
|
2023-08-14 15:27:58 +00:00
|
|
|
if (!btrfs_fs_compat_ro(fs_info, FREE_SPACE_TREE_VALID)) {
|
2022-08-09 06:03:54 +00:00
|
|
|
error("the filesystem doesn't have space cache v2, needs to be mounted with \"-o space_cache=v2\" first");
|
2023-08-23 11:11:05 +00:00
|
|
|
ret = -EINVAL;
|
2022-08-09 06:03:54 +00:00
|
|
|
goto out;
|
|
|
|
}
|
2023-08-14 15:27:58 +00:00
|
|
|
ret = convert_to_bg_tree(fs_info);
|
2022-08-09 06:03:54 +00:00
|
|
|
if (ret < 0) {
|
|
|
|
error("failed to convert the filesystem to block group tree feature");
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
goto out;
|
|
|
|
}
|
2023-05-02 01:01:45 +00:00
|
|
|
if (to_fst) {
|
2023-08-14 15:27:58 +00:00
|
|
|
if (btrfs_fs_compat_ro(fs_info, FREE_SPACE_TREE_VALID)) {
|
2023-05-02 01:01:45 +00:00
|
|
|
error("filesystem already has free-space-tree feature");
|
2023-08-23 11:11:05 +00:00
|
|
|
ret = -EINVAL;
|
2023-05-02 01:01:45 +00:00
|
|
|
goto out;
|
|
|
|
}
|
2023-08-14 15:27:58 +00:00
|
|
|
ret = convert_to_fst(fs_info);
|
2023-05-02 01:01:45 +00:00
|
|
|
if (ret < 0)
|
|
|
|
error("failed to convert the filesystem to free-space-tree feature");
|
|
|
|
goto out;
|
|
|
|
}
|
2023-04-18 22:41:14 +00:00
|
|
|
if (to_extent_tree) {
|
|
|
|
if (to_bg_tree) {
|
2023-04-27 12:21:24 +00:00
|
|
|
error("option --convert-to-block-group-tree conflicts with --convert-from-block-group-tree");
|
2023-08-23 11:11:05 +00:00
|
|
|
ret = -EINVAL;
|
2023-04-18 22:41:14 +00:00
|
|
|
goto out;
|
|
|
|
}
|
2023-08-14 15:27:58 +00:00
|
|
|
if (!btrfs_fs_compat_ro(fs_info, BLOCK_GROUP_TREE)) {
|
2023-04-18 22:41:14 +00:00
|
|
|
error("filesystem doesn't have block-group-tree feature");
|
2023-08-23 11:11:05 +00:00
|
|
|
ret = -EINVAL;
|
2023-04-18 22:41:14 +00:00
|
|
|
goto out;
|
|
|
|
}
|
2023-08-14 15:27:58 +00:00
|
|
|
ret = convert_to_extent_tree(fs_info);
|
2023-04-18 22:41:14 +00:00
|
|
|
if (ret < 0) {
|
|
|
|
error("failed to convert the filesystem from block group tree feature");
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
goto out;
|
|
|
|
}
|
2008-11-18 15:40:06 +00:00
|
|
|
if (seeding_flag) {
|
2023-08-14 15:27:58 +00:00
|
|
|
if (btrfs_fs_incompat(fs_info, METADATA_UUID)) {
|
2022-09-19 10:17:19 +00:00
|
|
|
error("SEED flag cannot be changed on a metadata-uuid changed fs");
|
2023-08-23 11:11:05 +00:00
|
|
|
ret = -EINVAL;
|
2018-10-11 15:04:00 +00:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2014-07-07 01:54:52 +00:00
|
|
|
if (!seeding_value && !force) {
|
2016-09-30 11:00:24 +00:00
|
|
|
warning(
|
|
|
|
"this is dangerous, clearing the seeding flag may cause the derived device not to be mountable!");
|
2014-07-07 01:54:52 +00:00
|
|
|
ret = ask_user("We are going to clear the seeding flag, are you sure?");
|
|
|
|
if (!ret) {
|
2022-09-19 10:17:19 +00:00
|
|
|
error("clear seeding flag canceled");
|
2023-08-23 11:11:05 +00:00
|
|
|
ret = -EINVAL;
|
2015-05-15 06:28:25 +00:00
|
|
|
goto out;
|
2014-07-07 01:54:52 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-01-18 14:48:21 +00:00
|
|
|
ret = update_seeding_flag(root, device, seeding_value, force);
|
2023-08-23 11:11:05 +00:00
|
|
|
goto out;
|
2008-11-18 15:40:06 +00:00
|
|
|
}
|
|
|
|
|
2015-06-02 16:24:33 +00:00
|
|
|
if (super_flags) {
|
|
|
|
ret = set_super_incompat_flags(root, super_flags);
|
2023-08-23 11:11:05 +00:00
|
|
|
goto out;
|
2013-03-15 19:32:16 +00:00
|
|
|
}
|
|
|
|
|
2021-02-07 18:23:44 +00:00
|
|
|
if (csum_type != -1) {
|
2023-02-15 18:06:24 +00:00
|
|
|
pr_verbose(LOG_DEFAULT, "Proceed to switch checksums\n");
|
2023-08-14 15:27:58 +00:00
|
|
|
ret = btrfs_change_csum_type(fs_info, csum_type);
|
2023-08-23 11:11:05 +00:00
|
|
|
goto out;
|
2021-02-07 18:23:44 +00:00
|
|
|
}
|
|
|
|
|
2018-10-11 15:04:00 +00:00
|
|
|
if (change_metadata_uuid) {
|
|
|
|
if (seeding_flag) {
|
2022-09-19 10:17:19 +00:00
|
|
|
error("not allowed to set both seeding flag and uuid metadata");
|
2023-08-23 11:11:05 +00:00
|
|
|
ret = -EINVAL;
|
2018-10-11 15:04:00 +00:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (new_fsid_str)
|
|
|
|
ret = set_metadata_uuid(root, new_fsid_str);
|
|
|
|
else
|
|
|
|
ret = set_metadata_uuid(root, NULL);
|
|
|
|
|
btrfs-progs: register device after successfully changing the fsid
Testing with the fstests config option POST_MKFS_CMD="btrfstune -m"
reported failure, as shown below:
./check btrfs/003
[111.635618] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 1 transid 6 /dev/sdb2 scanned by systemd-udevd (1117)
[111.642199] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 2 transid 6 /dev/sdb3 scanned by systemd-udevd (1114)
[111.660882] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 3 transid 6 /dev/sdb5 scanned by systemd-udevd (1116)
[111.672623] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 4 transid 6 /dev/sdb6 scanned by systemd-udevd (993)
[111.701301] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 6 transid 6 /dev/sdb8 scanned by systemd-udevd (1080)
[111.706513] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 5 transid 6 /dev/sdb7 scanned by systemd-udevd (1117)
[111.716532] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 7 transid 6 /dev/sdb9 scanned by systemd-udevd (1114)
[111.721253] BTRFS: device fsid a6599a65-8b6d-4156-bb55-0a3a2f0eae9d devid 8 transid 6 /dev/sdb10 scanned by mkfs.btrfs (1504)
[112.405186] BTRFS: device fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e devid 4 transid 8 /dev/sdb6 scanned by systemd-udevd (1117)
[112.422104] BTRFS: device fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e devid 6 transid 8 /dev/sdb8 scanned by systemd-udevd (1523)
[112.448355] BTRFS: device fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e devid 1 transid 8 /dev/sdb2 scanned by systemd-udevd (1115)
[112.456126] BTRFS error: device /dev/sdb3 belongs to fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e, and the fs is already mounted
[112.461299] BTRFS error: device /dev/sdb7 belongs to fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e, and the fs is already mounted
[112.465690] BTRFS info (device sdb2): using crc32c (crc32c-generic) checksum algorithm
[112.468758] BTRFS info (device sdb2): using free space tree
[112.471318] BTRFS error: device /dev/sdb9 belongs to fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e, and the fs is already mounted
[112.475962] BTRFS error: device /dev/sdb10 belongs to fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e, and the fs is already mounted
[112.481934] BTRFS error: device /dev/sdb5 belongs to fsid 1b3bacbf-14db-49c9-a3ef-547998aacc4e, and the fs is already mounted
[112.494614] BTRFS error (device sdb2): devid 2 uuid 99a57db7-2ef6-4240-a700-07ee7e64fb36 is missing
[112.497834] BTRFS error (device sdb2): failed to read chunk tree: -2
[112.507705] BTRFS error (device sdb2): open_ctree failed
The original fsid created by mkfs was a6599a65-8b6d-4156-bb55-0a3a2f0eae9d,
and the fsid created by the btrfstune -m option was
1b3bacbf-14db-49c9-a3ef-547998aacc4e.
During mount (after btrfstune -m), only 3 out of 8 devices were scanned
by systemd, while the rest were still being discovered. Consequently, the
mount command raced to find the missing devices. Since the mount command
in the kernel sets the flag fsdevices::opened, any further new alloc_device()
were blocked, resulting in the error "the fs is already mounted."
It is a good idea to register all devices after changing the fsid.
The previous registrations are already stale after changing the fsid.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>
2023-07-27 09:06:21 +00:00
|
|
|
btrfs_register_all_devices();
|
2023-08-23 11:11:05 +00:00
|
|
|
goto out;
|
2018-10-11 15:04:00 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (random_fsid || (new_fsid_str && !change_metadata_uuid)) {
|
2023-08-14 15:27:58 +00:00
|
|
|
if (fs_info->fs_devices->active_metadata_uuid) {
|
2022-09-19 10:17:19 +00:00
|
|
|
error(
|
2018-10-11 15:04:00 +00:00
|
|
|
"Cannot rewrite fsid while METADATA_UUID flag is active. \n"
|
2022-09-19 10:17:19 +00:00
|
|
|
"Ensure fsid and metadata_uuid match before retrying.");
|
2023-08-23 11:11:05 +00:00
|
|
|
ret = -EINVAL;
|
2018-10-11 15:04:00 +00:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2015-05-15 06:28:25 +00:00
|
|
|
if (!force) {
|
2016-09-30 11:00:24 +00:00
|
|
|
warning(
|
2018-06-18 16:15:12 +00:00
|
|
|
"it's recommended to run 'btrfs check --readonly' before this operation.\n"
|
|
|
|
"\tThe whole operation must finish before the filesystem can be mounted again.\n"
|
|
|
|
"\tIf cancelled or interrupted, run 'btrfstune -u' to restart.");
|
2015-05-15 06:28:25 +00:00
|
|
|
ret = ask_user("We are going to change UUID, are your sure?");
|
|
|
|
if (!ret) {
|
2022-09-19 10:17:19 +00:00
|
|
|
error("UUID change canceled");
|
2023-08-23 11:11:05 +00:00
|
|
|
ret = -EINVAL;
|
2015-05-15 06:28:25 +00:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
}
|
2023-08-14 15:27:58 +00:00
|
|
|
ret = change_uuid(fs_info, new_fsid_str);
|
2023-08-23 11:11:05 +00:00
|
|
|
goto out;
|
2015-05-15 06:28:25 +00:00
|
|
|
}
|
2023-09-27 17:46:47 +00:00
|
|
|
|
|
|
|
if (quota) {
|
|
|
|
ret = enable_quota(root->fs_info, true);
|
|
|
|
if (ret)
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2023-08-23 11:11:05 +00:00
|
|
|
out:
|
|
|
|
if (ret < 0) {
|
2023-08-14 15:27:58 +00:00
|
|
|
fs_info->readonly = 1;
|
2008-11-18 15:40:06 +00:00
|
|
|
ret = 1;
|
2016-09-30 11:00:24 +00:00
|
|
|
error("btrfstune failed");
|
2008-11-18 15:40:06 +00:00
|
|
|
}
|
|
|
|
close_ctree(root);
|
2015-10-26 10:28:20 +00:00
|
|
|
btrfs_close_all_devices();
|
2024-02-02 00:59:20 +00:00
|
|
|
close(fd);
|
2008-11-18 15:40:06 +00:00
|
|
|
|
2023-08-02 23:29:46 +00:00
|
|
|
free_out:
|
2008-11-18 15:40:06 +00:00
|
|
|
return ret;
|
|
|
|
}
|