Get rid of _DEFAULT_SOURCE #defines, set this in cmake and also use

secure_getenv where it makes sense.

CMakeLists.txt

@@ -9,8 +9,8 @@ INCLUDE(CTest)
 INCLUDE(GetGitRevisionDescription)
 get_git_head_revision(GIT_REFSPEC GIT_SHA1)
 
-# C99
-ADD_DEFINITIONS(-std=c99)
+# C99 and _GNU_SOURCE for secure_getenv
+ADD_DEFINITIONS(-std=c99 -D_GNU_SOURCE)
 
 # Compile library
 ADD_SUBDIRECTORY(lib)

client/bemenu-run.c

@@ -1,4 +1,3 @@
-#define _DEFAULT_SOURCE
 #include <stdlib.h>
 #include <stdio.h>
 #include <string.h>

client/common/common.c

@@ -1,4 +1,3 @@
-#define _DEFAULT_SOURCE
 #include "common.h"
 #include <stdlib.h>
 #include <string.h>

lib/library.c

@@ -123,12 +123,12 @@ bm_init(void)
         return true;
 
     static const char *rpath = INSTALL_PREFIX "/lib/bemenu";
-    const char *path = getenv("BEMENU_RENDERER");
+    const char *path = secure_getenv("BEMENU_RENDERER");
 
     if (path)
         return load_to_list(path);
 
-    path = getenv("BEMENU_RENDERERS");
+    path = secure_getenv("BEMENU_RENDERERS");
 
     if (!path || access(path, R_OK) == -1)
         path = rpath;

lib/renderers/curses/curses.c

@@ -1,6 +1,3 @@
-#define _DEFAULT_SOURCE
-#define _XOPEN_SOURCE_EXTENDED
-
 #include "internal.h"
 #include "version.h"
 

lib/renderers/wayland/registry.c

@@ -1,4 +1,3 @@
-#define _DEFAULT_SOURCE
 #include "wayland.h"
 
 #include <unistd.h>

lib/renderers/wayland/wayland.c

@@ -1,4 +1,3 @@
-#define _DEFAULT_SOURCE
 #include "internal.h"
 #include "version.h"
 #include "wayland.h"

lib/renderers/wayland/window.c

@@ -1,4 +1,3 @@
-#define _DEFAULT_SOURCE
 #include "internal.h"
 #include "wayland.h"
 

lib/renderers/x11/x11.c

@@ -1,4 +1,3 @@
-#define _DEFAULT_SOURCE
 #include "internal.h"
 #include "version.h"
 #include "x11.h"

test/bm_menu_new.c

@@ -1,4 +1,3 @@
-#define _DEFAULT_SOURCE
 #include <stdlib.h>
 #include <unistd.h>
 #include <stdio.h>