alertmanager/cli
George Robinson 848e2191d9
Support UTF-8 label matchers: Add metrics to matchers compat package (#3658)
* Add metrics to matchers compat package

This commit adds the following metrics to the compat package:

  alertmanager_matchers_parse
  alertmanager_matchers_disagree
  alertmanager_matchers_incompatible
  alertmanager_matchers_invalid

With a label called origin to differentiate the different sources
of inputs: the configuration file, the API, and amtool.

The disagree_total metric is incremented when an input is invalid
in both parsers, but results in different parsed representations,
then there is disagreement. This should not happen, and suggests
their is either a bug in one of the parsers or a mistake in the
backwards compatible guarantees of the matchers/parse parser.

The incompatible_total metric is incremented when an input is valid
in pkg/labels, but not the UTF-8 parser in matchers/parse. In such
case, the matcher should be updated to be compatible. This often
means adding double quotes around the right hand side of the matcher.
For example, foo="bar".

The invalid_total metric is incremented when an input is invalid
in both parsers. This was never a valid input.

The tests have been updated to check the metrics are incremented
as expected.

Signed-off-by: George Robinson <george.robinson@grafana.com>

---------

Signed-off-by: George Robinson <george.robinson@grafana.com>
2024-01-05 10:21:20 +00:00
..
config Update gopkg.in/alecthomas/kingpin.v2 to github.com/alecthomas/kingpin/v2 2023-03-08 15:02:24 +01:00
format Update gopkg.in/alecthomas/kingpin.v2 to github.com/alecthomas/kingpin/v2 2023-03-08 15:02:24 +01:00
testdata *: bump to Go 1.17 (#2792) 2021-12-22 14:03:53 +01:00
alert_add.go Support UTF-8 label matchers: Add metrics to matchers compat package (#3658) 2024-01-05 10:21:20 +00:00
alert_query.go Support UTF-8 label matchers: Add metrics to matchers compat package (#3658) 2024-01-05 10:21:20 +00:00
alert.go Update gopkg.in/alecthomas/kingpin.v2 to github.com/alecthomas/kingpin/v2 2023-03-08 15:02:24 +01:00
check_config_test.go *: add missing license headers 2018-05-14 17:37:13 +02:00
check_config.go Update gopkg.in/alecthomas/kingpin.v2 to github.com/alecthomas/kingpin/v2 2023-03-08 15:02:24 +01:00
cluster.go Update gopkg.in/alecthomas/kingpin.v2 to github.com/alecthomas/kingpin/v2 2023-03-08 15:02:24 +01:00
config.go Update gopkg.in/alecthomas/kingpin.v2 to github.com/alecthomas/kingpin/v2 2023-03-08 15:02:24 +01:00
root.go Support UTF-8 label matchers: Add metrics to matchers compat package (#3658) 2024-01-05 10:21:20 +00:00
routing.go Update gopkg.in/alecthomas/kingpin.v2 to github.com/alecthomas/kingpin/v2 2023-03-08 15:02:24 +01:00
silence_add.go Support UTF-8 label matchers: Add metrics to matchers compat package (#3658) 2024-01-05 10:21:20 +00:00
silence_expire.go Update gopkg.in/alecthomas/kingpin.v2 to github.com/alecthomas/kingpin/v2 2023-03-08 15:02:24 +01:00
silence_import.go use Go standard errors 2023-12-08 16:44:13 +01:00
silence_query.go Support UTF-8 label matchers: Add metrics to matchers compat package (#3658) 2024-01-05 10:21:20 +00:00
silence_update.go use Go standard errors 2023-12-08 16:44:13 +01:00
silence.go Update gopkg.in/alecthomas/kingpin.v2 to github.com/alecthomas/kingpin/v2 2023-03-08 15:02:24 +01:00
template_render.go Update gopkg.in/alecthomas/kingpin.v2 to github.com/alecthomas/kingpin/v2 2023-03-08 15:02:24 +01:00
template.go Update gopkg.in/alecthomas/kingpin.v2 to github.com/alecthomas/kingpin/v2 2023-03-08 15:02:24 +01:00
test_routing_test.go Update golangci-lint and fix complaints (#2853) 2022-03-25 17:59:51 +01:00
test_routing.go Support UTF-8 label matchers: Add metrics to matchers compat package (#3658) 2024-01-05 10:21:20 +00:00
utils.go Support UTF-8 label matchers: Add compat package with feature flag and use in amtool (#3483) 2023-10-19 12:00:01 +01:00