mirror of
https://github.com/prometheus/alertmanager
synced 2025-02-08 06:27:25 +00:00
f6b942cf9b
* chore!: adopt log/slog, drop go-kit/log The bulk of this change set was automated by the following script which is being used to aid in converting the various exporters/projects to use slog: https://gist.github.com/tjhop/49f96fb7ebbe55b12deee0b0312d8434 This commit includes several changes: - bump exporter-tookit to v0.13.1 for log/slog support - updates golangci-lint deprecated configs - enables sloglint linter - removes old go-kit/log linter configs - introduce some `if logger == nil { $newLogger }` additions to prevent nil references - converts cluster membership config to use a stdlib compatible slog adapter, rather than creating a custom io.Writer for use as the membership `logOutput` config Signed-off-by: TJ Hoplock <t.hoplock@gmail.com> * chore: address PR feedback Signed-off-by: TJ Hoplock <t.hoplock@gmail.com> --------- Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
98 lines
2.5 KiB
YAML
98 lines
2.5 KiB
YAML
output:
|
|
sort-results: true
|
|
|
|
linters:
|
|
enable:
|
|
- depguard
|
|
- errorlint
|
|
- godot
|
|
- gofumpt
|
|
- goimports
|
|
- misspell
|
|
- revive
|
|
- testifylint
|
|
- sloglint
|
|
|
|
issues:
|
|
max-issues-per-linter: 0
|
|
max-same-issues: 0
|
|
exclude-rules:
|
|
- path: _test.go
|
|
linters:
|
|
- errcheck
|
|
exclude-files:
|
|
# Skip autogenerated files.
|
|
- ^.*\.(pb|y)\.go$
|
|
timeout: 5m
|
|
|
|
linters-settings:
|
|
depguard:
|
|
rules:
|
|
main:
|
|
deny:
|
|
- pkg: sync/atomic
|
|
desc: "Use go.uber.org/atomic instead of sync/atomic"
|
|
- pkg: github.com/stretchr/testify/assert
|
|
desc: "Use github.com/stretchr/testify/require instead of github.com/stretchr/testify/assert"
|
|
- pkg: github.com/go-kit/kit/log
|
|
desc: "Use github.com/go-kit/log instead of github.com/go-kit/kit/log"
|
|
- pkg: github.com/pkg/errors
|
|
desc: "Use errors or fmt instead of github.com/pkg/errors"
|
|
errcheck:
|
|
exclude-functions:
|
|
# Don't flag lines such as "io.Copy(io.Discard, resp.Body)".
|
|
- io.Copy
|
|
# The next two are used in HTTP handlers, any error is handled by the server itself.
|
|
- io.WriteString
|
|
- (net/http.ResponseWriter).Write
|
|
# No need to check for errors on server's shutdown.
|
|
- (*net/http.Server).Shutdown
|
|
# Never check for rollback errors as Rollback() is called when a previous error was detected.
|
|
- (github.com/prometheus/prometheus/storage.Appender).Rollback
|
|
godot:
|
|
scope: toplevel
|
|
exclude:
|
|
- "^ ?This file is safe to edit"
|
|
- "^ ?scheme value"
|
|
period: true
|
|
capital: true
|
|
goimports:
|
|
local-prefixes: github.com/prometheus/alertmanager
|
|
gofumpt:
|
|
extra-rules: true
|
|
revive:
|
|
rules:
|
|
- name: exported
|
|
arguments: ["disableStutteringCheck"]
|
|
- name: blank-imports
|
|
- name: context-as-argument
|
|
- name: error-return
|
|
- name: error-strings
|
|
- name: error-naming
|
|
- name: if-return
|
|
- name: increment-decrement
|
|
- name: var-naming
|
|
- name: var-declaration
|
|
- name: package-comments
|
|
- name: range
|
|
- name: receiver-naming
|
|
- name: time-naming
|
|
- name: unexported-return
|
|
- name: indent-error-flow
|
|
- name: errorf
|
|
testifylint:
|
|
disable:
|
|
- float-compare
|
|
- go-require
|
|
enable:
|
|
- bool-compare
|
|
- compares
|
|
- empty
|
|
- error-is-as
|
|
- error-nil
|
|
- expected-actual
|
|
- len
|
|
- require-error
|
|
- suite-dont-use-pkg
|
|
- suite-extra-assert-call
|