mirror of
https://github.com/prometheus/alertmanager
synced 2024-12-12 09:26:17 +00:00
ca5089d33e
* Rename feature flags and make package public This commit renames the feature flags "classic-matchers-parsing" and "utf8-matchers-parsing" to "classic-matchers" and "utf8-matchers". This better represents their use, for example, when validating both alerts and silences created via the API. It also makes the feature flags package public for two reasons: 1. AllowedFlags is a public variable 2. We would rather use these consts in Mimir then have to hardcode the strings ourselves, and be subject to breaking changes in future Signed-off-by: George Robinson <george.robinson@grafana.com> --------- Signed-off-by: George Robinson <george.robinson@grafana.com>
59 lines
1.6 KiB
Go
59 lines
1.6 KiB
Go
// Copyright 2023 Prometheus Team
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package featurecontrol
|
|
|
|
import (
|
|
"errors"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/go-kit/log"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestFlags(t *testing.T) {
|
|
tc := []struct {
|
|
name string
|
|
featureFlags string
|
|
err error
|
|
}{
|
|
{
|
|
name: "with only valid feature flags",
|
|
featureFlags: FeatureReceiverNameInMetrics,
|
|
},
|
|
{
|
|
name: "with only invalid feature flags",
|
|
featureFlags: "somethingsomething",
|
|
err: errors.New("Unknown option 'somethingsomething' for --enable-feature"),
|
|
},
|
|
{
|
|
name: "with both, valid and invalid feature flags",
|
|
featureFlags: strings.Join([]string{FeatureReceiverNameInMetrics, "somethingbad"}, ","),
|
|
err: errors.New("Unknown option 'somethingbad' for --enable-feature"),
|
|
},
|
|
}
|
|
|
|
for _, tt := range tc {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
fc, err := NewFlags(log.NewNopLogger(), tt.featureFlags)
|
|
if tt.err != nil {
|
|
require.EqualError(t, err, tt.err.Error())
|
|
} else {
|
|
require.NoError(t, err)
|
|
require.NotNil(t, fc)
|
|
}
|
|
})
|
|
}
|
|
}
|