In accordance with a new rule introduced as part of https://github.com/grafana/dashboard-linter/pull/79 this is now required. However, for the new rule of `panel-unit-rule` we don't reap any benefits from specifiying a particular unit for our panels, the defaults work perfectly fine so they're ignored.
Signed-off-by: gotjosh <josue.abreu@gmail.com>
With https://github.com/grafana/dashboard-linter/pull/49 `template-job-rule` no longer validates both `instance` and `job` labels. Add the new rule of `template-instance-rule` to the exclusions to preserve the previous behaviour.
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Within 9a32e58ed0, the rules have been split into two different rules:
`target-job-rule`
`target-instance-rule`
All of our queries do contain the `job` label but as per the reason, we don't need both in this particular case.
Fixes#2899
Signed-off-by: gotjosh <josue.abreu@gmail.com>
The expression alertmanager_cluster_members{job="alertmanager"}[5m]) is assumed to return
one series for each alertmanager instance in the cluster. When running inside Kubernetes,
alertmanager pods can get evicted and rescheduled. This can change the instance label and
produce a new series for that alertmanager instance.
When the same pod gets evicted several times in a row, there will be a short interval in which
Prometheus will return values from both the new series and the old series.
As a result, counting the number of series for the alertmanager_cluster_members metric
will overestimate the number of instances in the given cluster.
This commit modifies the the AlertmanagerMembersInconsistent alert to increase the for clause to 15m
in order to reduce the probability of a false positive.
Signed-off-by: fpetkovski <filip.petkovsky@gmail.com>
* Implements a Grafana dashboard to the mixin.
The dashboard aims to show an overview of the overall health of Alertmanager.
Signed-off-by: ArthurSens <arthursens2005@gmail.com>
* Drop /vendor.
* Update Go to 1.16.
* Update djfarrelly/maildev to 1.1.0.
* Update protoc to 3.15.8.
* Update mixin test for Go 1.16.
* Bump Go modules.
Signed-off-by: SuperQ <superq@gmail.com>
The alert was just looking at the minimum across integrations. So a
complete failure of one integration would be masked by a still worknig
other integration. With this fix, the `integration` label is retained
(as it was already expected by the `description`), and thus any
failing integration will trigger the alert.
In addition, an `alertmanagerCriticalIntegrationsRegEx` is provided
that allows to mark integrations as critical. Integrations that are
not used to deliver critical alerts, or those that are just there for
auditing and logging purposes can now be configured to only trigger a
warning alert if they fail.
Signed-off-by: beorn7 <beorn@grafana.com>
gotjosh
clyang82
fpetkovski
Arthur Silva Sens
SuperQ
Björn Rabenstein
Tom Wilkie