RepoMirrors
/
alertmanager
mirror of https://github.com/prometheus/alertmanager
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix TestSilenceLimits tests (#3866) 

This commit fixes silence tests that relied on the maintenance
function running at a fixed 100ms interval. If the go runtime
that runs the maintenance is not scheduled with 150ms then the
test will fail.

Signed-off-by: George Robinson <george.robinson@grafana.com>
This commit is contained in:
George Robinson 2024-06-05 15:03:00 +01:00 committed by GitHub
parent 2c189d81d9
commit f9d5a08759
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
silence/silence_test.go
View File

@ -465,12 +465,8 @@ func TestSilenceLimits(t *testing.T) {
MaxSilences: 1,
MaxPerSilenceBytes: 2 << 11, // 4KB
},
Retention: 100 * time.Millisecond,
})
require.NoError(t, err)
stopCh := make(chan struct{})
defer close(stopCh)
go s.Maintenance(100*time.Millisecond, "", stopCh, nil)
// Insert sil1 should succeed without error.
sil1 := &pb.Silence{
@ -493,10 +489,13 @@ func TestSilenceLimits(t *testing.T) {
require.EqualError(t, err, "exceeded maximum number of silences: 1 (limit: 1)")
require.Equal(t, "", id2)
// Expire sil1 and wait for the maintenance to finish.
// This should allow sil2 to be inserted.
// Expire sil1 and run the GC. This should allow sil2 to be
// inserted.
require.NoError(t, s.Expire(id1))
time.Sleep(150 * time.Millisecond)
n, err := s.GC()
require.NoError(t, err)
require.Equal(t, 1, n)
id2, err = s.Set(sil2)
require.NoError(t, err)
require.NotEqual(t, "", id2)
@ -507,7 +506,9 @@ func TestSilenceLimits(t *testing.T) {
// Expire sil2.
require.NoError(t, s.Expire(id2))
time.Sleep(150 * time.Millisecond)
n, err = s.GC()
require.NoError(t, err)
require.Equal(t, 1, n)
// Insert sil3 should fail because it exceeds maximum size.
sil3 := &pb.Silence{