RepoMirrors/alertmanager
1
0
Fork 0
mirror of https://github.com/prometheus/alertmanager synced 2024-12-28 00:52:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Inconsistent use of baseUrl and apiUrl arguments (#1008)

Browse Source 
* Inconsistent use of baseUrl and apiUrl arguments

Both are Strings, so flipping the order between
one invocation and another didn't raise any
argument from the compiler. The baseUrl argument
is actually unnecessary, and has been removed.

* Update bindata.go
This commit is contained in:
stuart nelson 2017-09-29 14:16:03 +02:00 committed by GitHub
parent 4931c9206e
commit a7981e4693
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ui/app/src/Updates.elm
View File

@ -57,7 +57,7 @@ update msg ({ basePath, apiUrl } as model) =
NavigateToSilenceView silenceId -> NavigateToSilenceView silenceId ->
let let
( silenceView, cmd ) = ( silenceView, cmd ) =
Views.SilenceView.Updates.update (InitSilenceView silenceId) model.silenceView apiUrl basePath Views.SilenceView.Updates.update (InitSilenceView silenceId) model.silenceView apiUrl
in in
( { model | route = SilenceViewRoute silenceId, silenceView = silenceView } ( { model | route = SilenceViewRoute silenceId, silenceView = silenceView }
, Cmd.map MsgForSilenceView cmd , Cmd.map MsgForSilenceView cmd
@ -116,7 +116,7 @@ update msg ({ basePath, apiUrl } as model) =
MsgForSilenceView msg -> MsgForSilenceView msg ->
let let
( silenceView, cmd ) = ( silenceView, cmd ) =
Views.SilenceView.Updates.update msg model.silenceView basePath apiUrl Views.SilenceView.Updates.update msg model.silenceView apiUrl
in in
( { model | silenceView = silenceView }, Cmd.map MsgForSilenceView cmd ) ( { model | silenceView = silenceView }, Cmd.map MsgForSilenceView cmd )

4
ui/app/src/Views/SilenceView/Updates.elm
View File

@ -9,8 +9,8 @@ import Utils.Types exposing (ApiData(..))
import Views.SilenceView.Types exposing (Model, SilenceViewMsg(..)) import Views.SilenceView.Types exposing (Model, SilenceViewMsg(..))
update : SilenceViewMsg -> Model -> String -> String -> ( Model, Cmd SilenceViewMsg ) update : SilenceViewMsg -> Model -> String -> ( Model, Cmd SilenceViewMsg )
update msg model apiUrl basePath = update msg model apiUrl =
case msg of case msg of
FetchSilence id -> FetchSilence id ->
( model, getSilence apiUrl id SilenceFetched ) ( model, getSilence apiUrl id SilenceFetched )

4
ui/bindata.go
View File

File diff suppressed because one or more lines are too long