RepoMirrors/alertmanager
1
0
Fork 0
mirror of https://github.com/prometheus/alertmanager synced 2024-12-26 16:12:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1486 from mxinden/staticcheck

Browse Source 
config/test: Count `<secret>` occurrences via golang strings
This commit is contained in:
Max Inden 2018-07-30 09:41:51 +02:00 committed by GitHub
commit 4fff29c683
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
config/config_test.go
View File

@ -257,9 +257,7 @@ func TestHideConfigSecrets(t *testing.T) {
// String method must not reveal authentication credentials.
s := c.String()
secretRe := regexp.MustCompile("<secret>")
matches := secretRe.FindAllStringIndex(s, -1)
if len(matches) != 14 || strings.Contains(s, "mysecret") {
if strings.Count(s, "<secret>") != 14 || strings.Contains(s, "mysecret") {
t.Fatal("config's String method reveals authentication credentials.")
}
}