RepoMirrors
/
alertmanager
mirror of https://github.com/prometheus/alertmanager
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

slack: retry 429 errors (#2112) 

Fix #2111

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
This commit is contained in:
Julien Pivotto 2019-11-21 14:14:10 +01:00 committed by Simon Pasquier
parent 4ec53566e5
commit 26cc96a787
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
notify/slack/slack.go
View File

@ -49,7 +49,7 @@ func New(c *config.SlackConfig, t *template.Template, l log.Logger) (*Notifier,
tmpl: t, tmpl: t,
logger: l, logger: l,
client: client, client: client,
retrier: &notify.Retrier{}, retrier: &notify.Retrier{RetryCodes: []int{http.StatusTooManyRequests}},
}, nil }, nil
} }

4
notify/slack/slack_test.go
View File

@ -15,6 +15,7 @@ package slack
import ( import (
"fmt" "fmt"
"net/http"
"testing" "testing"
"github.com/go-kit/kit/log" "github.com/go-kit/kit/log"
@ -35,7 +36,8 @@ func TestSlackRetry(t *testing.T) {
) )
require.NoError(t, err) require.NoError(t, err)
for statusCode, expected := range test.RetryTests(test.DefaultRetryCodes()) { retryCodes := append(test.DefaultRetryCodes(), http.StatusTooManyRequests)
for statusCode, expected := range test.RetryTests(retryCodes) {
actual, _ := notifier.retrier.Check(statusCode, nil) actual, _ := notifier.retrier.Check(statusCode, nil)
require.Equal(t, expected, actual, fmt.Sprintf("error on status %d", statusCode)) require.Equal(t, expected, actual, fmt.Sprintf("error on status %d", statusCode))
} }