better test documentation
Signed-off-by: gotjosh <josue.abreu@gmail.com>
This commit is contained in:
parent
cd8cd33794
commit
0f8e58a4e8
|
@ -318,38 +318,46 @@ func TestPostSilencesHandler(t *testing.T) {
|
||||||
expectedCreator string
|
expectedCreator string
|
||||||
}{
|
}{
|
||||||
{
|
{
|
||||||
name: "when a header is configured and has a value",
|
name: "when a header is configured and has a value - it takes the header value as the creator",
|
||||||
header: &kv{key: "X-Alertmanager-User", value: "user1"},
|
header: &kv{key: "X-Alertmanager-User", value: "user1"},
|
||||||
expectedStatusCode: http.StatusOK,
|
expectedStatusCode: http.StatusOK,
|
||||||
expectedCreator: "user1",
|
expectedCreator: "user1",
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "when a header is configured with no value",
|
name: "when a header is configured with no value and no creator is set through params - it takes no value",
|
||||||
header: &kv{key: "X-Alertmanager-User", value: ""},
|
header: &kv{key: "X-Alertmanager-User", value: ""},
|
||||||
expectedStatusCode: http.StatusOK,
|
expectedStatusCode: http.StatusOK,
|
||||||
expectedCreator: "",
|
expectedCreator: "",
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "when no header is configured but basic auth is present",
|
name: "when a header is configured with no value and a creator is set through params - it takes the creator via params",
|
||||||
|
header: &kv{key: "X-Alertmanager-User", value: ""},
|
||||||
|
creator: "user3",
|
||||||
|
expectedStatusCode: http.StatusOK,
|
||||||
|
expectedCreator: "user3",
|
||||||
|
},
|
||||||
|
|
||||||
|
{
|
||||||
|
name: "when no header is configured but basic auth is present - it takes the basic auth username",
|
||||||
basicAuth: "userba:password",
|
basicAuth: "userba:password",
|
||||||
expectedStatusCode: http.StatusOK,
|
expectedStatusCode: http.StatusOK,
|
||||||
expectedCreator: "userba",
|
expectedCreator: "userba",
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "when no header is configured and no basic auth - it takes the creator",
|
name: "when no header is configured and no basic auth - it takes the creator via params",
|
||||||
creator: "usernothing",
|
creator: "usernothing",
|
||||||
expectedStatusCode: http.StatusOK,
|
expectedStatusCode: http.StatusOK,
|
||||||
expectedCreator: "usernothing",
|
expectedCreator: "usernothing",
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "when params value is different from basic auth username",
|
name: "when params value is different from basic auth username - it fails",
|
||||||
creator: "userdifferent",
|
creator: "userdifferent",
|
||||||
basicAuth: "user:password",
|
basicAuth: "user:password",
|
||||||
expectedStatusCode: http.StatusBadRequest,
|
expectedStatusCode: http.StatusBadRequest,
|
||||||
expectedError: "created_by does not match HTTP basic authentication or value of HTTP header",
|
expectedError: "created_by does not match HTTP basic authentication or value of HTTP header",
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "when params value is different from header value",
|
name: "when params value is different from header value - it fails",
|
||||||
creator: "userdifferent",
|
creator: "userdifferent",
|
||||||
header: &kv{key: "X-Alertmanager-User", value: "user"},
|
header: &kv{key: "X-Alertmanager-User", value: "user"},
|
||||||
expectedStatusCode: http.StatusBadRequest,
|
expectedStatusCode: http.StatusBadRequest,
|
||||||
|
|
Loading…
Reference in New Issue