RepoMirrors
/
alertmanager
mirror of https://github.com/prometheus/alertmanager
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #702 from prometheus/log-failed-notifiers 

Include notifier type in retry logs and errors
This commit is contained in:
Julius Volz 2017-04-11 13:00:00 +02:00 committed by GitHub
parent b7bea3df5c 7f1d111324
commit 0ce2de56fc
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
notify/notify.go
View File

@ -543,9 +543,9 @@ func (r RetryStage) Exec(ctx context.Context, alerts ...*types.Alert) (context.C
case <-tick.C: case <-tick.C:
if retry, err := r.integration.Notify(ctx, alerts...); err != nil { if retry, err := r.integration.Notify(ctx, alerts...); err != nil {
numFailedNotifications.WithLabelValues(r.integration.name).Inc() numFailedNotifications.WithLabelValues(r.integration.name).Inc()
log.Debugf("Notify attempt %d failed: %s", i, err) log.Debugf("Notify attempt %d for %q failed: %s", i, r.integration.name, err)
if !retry { if !retry {
return ctx, alerts, fmt.Errorf("Cancelling notify retry due to unrecoverable error: %s", err) return ctx, alerts, fmt.Errorf("Cancelling notify retry for %q due to unrecoverable error: %s", r.integration.name, err)
} }
// Save this error to be able to return the last seen error by an // Save this error to be able to return the last seen error by an