RepoMirrors
/
alertmanager
mirror of https://github.com/prometheus/alertmanager
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Ensure matcher values are present when parsing matchers from strings 

Fixes #2936

Signed-off-by: gotjosh <josue.abreu@gmail.com>
This commit is contained in:
gotjosh 2022-06-28 11:51:06 +01:00
parent 0a9a48d60f
commit 05f073f42f
No known key found for this signature in database
GPG Key ID: A6E1DDE38FF3C74E
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/labels/parse.go
View File

@ -120,8 +120,12 @@ func ParseMatcher(s string) (_ *Matcher, err error) {
return nil, errors.Errorf("bad matcher format: %s", s) return nil, errors.Errorf("bad matcher format: %s", s)
} }
rawValue := ms[3]
if len(rawValue) == 0 {
return nil, errors.Errorf("matcher value is not present: %s", s)
}
var ( var (
rawValue = ms[3]
value strings.Builder value strings.Builder
escaped bool escaped bool
expectTrailingQuote bool expectTrailingQuote bool

4
pkg/labels/parse_test.go
View File

@ -189,6 +189,10 @@ func TestMatchers(t *testing.T) {
return append(ms, m, m2) return append(ms, m, m2)
}(), }(),
}, },
{
input: `job=`,
err: `matcher value is not present: job=`,
},
{ {
input: `job="value`, input: `job="value`,
err: `matcher value contains unescaped double quote: "value`, err: `matcher value contains unescaped double quote: "value`,