mirror of
https://github.com/dense-analysis/ale
synced 2024-12-18 12:25:17 +00:00
e19b8c05cd
Some messages of the crystal compiler are not tied to a file. This causes a 'Key not present in Dictionnary' error (E716). For the record, the json output on ```require "./nonexistent.cr"``` is the following : ```json [ { "file":"/tmp/file.cr", "line":1, "column":1, "size":0, "message":"while requiring \"./nonexistent.cr\"" }, { "message":"can't find file './nonexistent.cr' relative to '/tmp'" } ] ``` The second message does not have line/column attributes.
29 lines
875 B
Plaintext
29 lines
875 B
Plaintext
Before:
|
|
runtime ale_linters/crystal/crystal.vim
|
|
|
|
After:
|
|
call ale#linter#Reset()
|
|
|
|
Execute(The crystal handler should parse lines correctly and add the column if it can):
|
|
AssertEqual
|
|
\ [
|
|
\ {
|
|
\ 'lnum': 2,
|
|
\ 'col': 1,
|
|
\ 'text': 'unexpected token: EOF'
|
|
\ }
|
|
\ ],
|
|
\ ale_linters#crystal#crystal#Handle(255, [
|
|
\ '[{"file":"/tmp/test.cr","line":2,"column":1,"size":null,"message":"unexpected token: EOF"}]'
|
|
\ ])
|
|
|
|
Execute(The crystal handler should not fail when a missing file is required):
|
|
AssertEqual
|
|
\ [ { 'lnum':1, 'col': 1, 'text': 'while requiring "./nonexistent.cr"' } ],
|
|
\ ale_linters#crystal#crystal#Handle(255,
|
|
\ json_encode([
|
|
\ { "file":"/tmp/file.cr","line":1,"column":1,"size":0,"message":"while requiring \"./nonexistent.cr\"" },
|
|
\ { "message": "can't find file './nonexistent.cr' relative to '/tmp'" },
|
|
\ ])
|
|
\ )
|