mirror of
https://github.com/dense-analysis/ale
synced 2024-12-24 15:13:02 +00:00
4b0f3257dd
* Remove 'col' from linters where it is hardcoded to 1 When 'col' is 1, the first column will get highlighted for no reason. It should be 0 (which is the default). In the scalac linter there was also a check about the outcome of `stridx`. It would set l:col to 0 if it was -1, and then it uses `'col': l:col + 1` to convert the outcome of `stridx` to the actual column number. This will make 'col' equals 1 when there is no match. We can remove the check because `-1 + 1 = 0`. * Remove outdated comments about vcol vcol was added as a default, and the loclists that follow these comments do not contain 'vcol' anymore
50 lines
1.4 KiB
VimL
50 lines
1.4 KiB
VimL
" Author: jwilliams108 <https://github.com/jwilliams108>
|
|
" Description: phpcs for PHP files
|
|
|
|
function! ale_linters#php#phpcs#GetCommand(buffer) abort
|
|
let l:command = 'phpcs -s --report=emacs --stdin-path=%s'
|
|
|
|
" This option can be set to change the standard used by phpcs
|
|
if exists('g:ale_php_phpcs_standard')
|
|
let l:command .= ' --standard=' . g:ale_php_phpcs_standard
|
|
endif
|
|
|
|
return l:command
|
|
endfunction
|
|
|
|
function! ale_linters#php#phpcs#Handle(buffer, lines) abort
|
|
" Matches against lines like the following:
|
|
"
|
|
" /path/to/some-filename.php:18:3: error - Line indented incorrectly; expected 4 spaces, found 2 (Generic.WhiteSpace.ScopeIndent.IncorrectExact)
|
|
let l:pattern = '^.*:\(\d\+\):\(\d\+\): \(.\+\) - \(.\+\) \(\(.\+\)\)$'
|
|
let l:output = []
|
|
|
|
for l:line in a:lines
|
|
let l:match = matchlist(l:line, l:pattern)
|
|
|
|
if len(l:match) == 0
|
|
continue
|
|
endif
|
|
|
|
let l:text = l:match[4]
|
|
let l:type = l:match[3]
|
|
|
|
call add(l:output, {
|
|
\ 'bufnr': a:buffer,
|
|
\ 'lnum': l:match[1] + 0,
|
|
\ 'col': l:match[2] + 0,
|
|
\ 'text': l:text,
|
|
\ 'type': l:type ==# 'error' ? 'E' : 'W',
|
|
\})
|
|
endfor
|
|
|
|
return l:output
|
|
endfunction
|
|
|
|
call ale#linter#Define('php', {
|
|
\ 'name': 'phpcs',
|
|
\ 'executable': 'phpcs',
|
|
\ 'command_callback': 'ale_linters#php#phpcs#GetCommand',
|
|
\ 'callback': 'ale_linters#php#phpcs#Handle',
|
|
\})
|