RepoMirrors/ale - ale

Commit Graph

Author	SHA1	Message	Date
Tomáš Janoušek	2550f5d952	Fixes to code actions (cursor moving, tests, EOL/EOF corner cases) (#3478 ) * code_action: Don't move cursor when change covers entire file * code_action: Refactor/simplify ApplyChanges * code_action: Fix EOL at EOF corner cases while performing no changes * code_action: Fix column around EOL corner cases * code_action: Handle positions out of bounds * code_action: Add instructions for verifying corner case tests against vscode	2021-02-20 16:16:47 +00:00
Dalius Dobravolskas	01800a23ad	Support for LSP/tsserver Code Actions (#3437 ) * Added tsserver and LSP code action support. * tsserver refactors support added. * Handling special case when new text is added after new line symbol. * ale#code_action#ApplyChanges simplified. * Initial attempt on LSP Code Actions. * workspace/executeCommand added. * Some null checks added. * Add last column to LSP Code Action message. * Pass diagnostics to LSP code action. Previously ApplyChanges code was applied from top-to-bottom that required extra parameters to track progress and there was bug. I have changed code to bottom-to-top approach as that does not require those extra parameters and solved the bug. Tested with typescript-language-server and it is working.	2020-11-14 10:15:17 +00:00

Author

SHA1

Message

Date

Tomáš Janoušek

2550f5d952

Fixes to code actions (cursor moving, tests, EOL/EOF corner cases) (#3478 )

* code_action: Don't move cursor when change covers entire file
* code_action: Refactor/simplify ApplyChanges
* code_action: Fix EOL at EOF corner cases while performing no changes
* code_action: Fix column around EOL corner cases
* code_action: Handle positions out of bounds
* code_action: Add instructions for verifying corner case tests against vscode

2021-02-20 16:16:47 +00:00

Dalius Dobravolskas

01800a23ad

Support for LSP/tsserver Code Actions (#3437 )

* Added tsserver and LSP code action support.
* tsserver refactors support added.
* Handling special case when new text is added after new line symbol.
* ale#code_action#ApplyChanges simplified.
* Initial attempt on LSP Code Actions.
* workspace/executeCommand added.
* Some null checks added.
* Add last column to LSP Code Action message.
* Pass diagnostics to LSP code action.

Previously ApplyChanges code was applied from top-to-bottom that required 
extra parameters to track progress and there was bug. I have changed code
to bottom-to-top approach as that does not require those extra parameters
and solved the bug.

Tested with typescript-language-server and it is working.

2020-11-14 10:15:17 +00:00

2 Commits