From fa02b1d25975a85a9d976214a5161db48fecc907 Mon Sep 17 00:00:00 2001
From: Olaf Alders <olaf@wundersolutions.com>
Date: Tue, 30 May 2017 16:07:21 -0400
Subject: [PATCH] Remove -X flag from perl defaults.

"-X Disables all warnings regardless of use warnings or $^W".  See
"perldoc perlrun" or http://perldoc.perl.org/perlrun.html

With the current defaults, warnings are squashed.  For example:

$ perl -X -Mwarnings -c -e'BEGIN { 42 + undef }'
-e syntax OK

$ perl -Mwarnings -c -e'BEGIN { 42 + undef }'
Use of uninitialized value in addition (+) at -e line 1.
-e syntax OK

So, it's not clear from the current defaults whether Ale wants to remove
warnings or enable them.  As it stands, it's trying to do both and the
disabling appears to win.

This commit enables warnings by default.
---
 ale_linters/perl/perl.vim | 2 +-
 doc/ale-perl.txt          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ale_linters/perl/perl.vim b/ale_linters/perl/perl.vim
index 8720213b..ab4defbc 100644
--- a/ale_linters/perl/perl.vim
+++ b/ale_linters/perl/perl.vim
@@ -5,7 +5,7 @@ let g:ale_perl_perl_executable =
 \   get(g:, 'ale_perl_perl_executable', 'perl')
 
 let g:ale_perl_perl_options =
-\   get(g:, 'ale_perl_perl_options', '-X -c -Mwarnings -Ilib')
+\   get(g:, 'ale_perl_perl_options', '-c -Mwarnings -Ilib')
 
 function! ale_linters#perl#perl#GetExecutable(buffer) abort
     return ale#Var(a:buffer, 'perl_perl_executable')
diff --git a/doc/ale-perl.txt b/doc/ale-perl.txt
index 7daf48ac..58940ca7 100644
--- a/doc/ale-perl.txt
+++ b/doc/ale-perl.txt
@@ -16,7 +16,7 @@ g:ale_perl_perl_executable                         *g:ale_perl_perl_executable*
 g:ale_perl_perl_options                               *g:ale_perl_perl_options*
                                                       *b:ale_perl_perl_options*
   Type: |String|
-  Default: `'-X -c -Mwarnings -Ilib'`
+  Default: `'-c -Mwarnings -Ilib'`
 
   This variable can be changed to alter the command-line arguments to the perl
   invocation.