Merge branch 'vint-improve'

ale_linters/vim/vint.vim

@@ -1,4 +1,4 @@
-" Author: w0rp <devw0rp@gmail.com>
+" Author: w0rp <devw0rp@gmail.com>, KabbAmine <amine.kabb@gmail.com>
 " Description: This file adds support for checking Vim code with Vint.
 
 if exists('g:loaded_ale_linters_vim_vint')
@@ -7,40 +7,11 @@ endif
 
 let g:loaded_ale_linters_vim_vint = 1
 
-function! ale_linters#vim#vint#Handle(buffer, lines)
-    " Matches patterns line the following:
-    "
-    " /home/w0rp/.vim/vimrc:198:30: Prefer single quoted strings (see Google VimScript Style Guide (Strings))
-    let pattern = '^.*:\(\d\+\):\(\d\+\): \(.\+\)$'
-    let output = []
-
-    for line in a:lines
-        let l:match = matchlist(line, pattern)
-
-        if len(l:match) == 0
-            continue
-        endif
-
-        let text = l:match[3]
-
-        " vcol is Needed to indicate that the column is a character.
-        call add(output, {
-        \   'bufnr': a:buffer,
-        \   'lnum': l:match[1] + 0,
-        \   'vcol': 0,
-        \   'col': l:match[2] + 0,
-        \   'text': text,
-        \   'type': 'W',
-        \   'nr': -1,
-        \})
-    endfor
-
-    return output
-endfunction
+let s:format = '-f "{file_path}:{line_number}:{column_number}: {severity}: {description} (see {reference})'
 
 call ALEAddLinter('vim', {
 \   'name': 'vint',
 \   'executable': 'vint',
-\   'command': g:ale#util#stdin_wrapper . ' .vim vint -w --no-color',
-\   'callback': 'ale_linters#haskell#ghc#Handle',
+\   'command': g:ale#util#stdin_wrapper . ' .vim vint -w --no-color ' . s:format,
+\   'callback': 'ale#handlers#HandleGCCFormat',
 \})

plugin/ale/handlers.vim

@@ -1,3 +1,4 @@
+scriptencoding utf-8
 " Author: w0rp <devw0rp@gmail.com>
 " Description: This file defines some standard error format handlers. Any
 "   linter which outputs warnings and errors in a format accepted by one of
@@ -15,7 +16,7 @@ function! ale#handlers#HandleGCCFormat(buffer, lines)
     " <stdin>:8:5: warning: conversion lacks type at end of format [-Wformat=]
     " <stdin>:10:27: error: invalid operands to binary - (have ‘int’ and ‘char *’)
     " -:189:7: note: $/${} is unnecessary on arithmetic variables. [SC2004]
-    let pattern = '^[^:]\+:\(\d\+\):\(\d\+\): \([^:]\+\): \(.\+\)$'
+    let pattern = '^.\+:\(\d\+\):\(\d\+\): \([^:]\+\): \(.\+\)$'
     let output = []
 
     for line in a:lines