From e8cc40b13985e17320437debca0426a1129e0f54 Mon Sep 17 00:00:00 2001 From: Ryan Date: Wed, 14 Jun 2017 03:35:11 -0500 Subject: [PATCH] Add fusion-lint, documentation, and tests (#648) * Add `fusion-lint` for first FusionScript linter * Add documentation over `fusion-lint` * Add tests for `fusion-lint` command callback --- README.md | 1 + ale_linters/fuse/fusionlint.vim | 41 +++++++++++++++++++ doc/ale-fuse.txt | 25 +++++++++++ doc/ale.txt | 3 ++ .../test_fusionlint_command_callback.vader | 24 +++++++++++ 5 files changed, 94 insertions(+) create mode 100644 ale_linters/fuse/fusionlint.vim create mode 100644 doc/ale-fuse.txt create mode 100644 test/command_callback/test_fusionlint_command_callback.vader diff --git a/README.md b/README.md index 8543129b..204c12d6 100644 --- a/README.md +++ b/README.md @@ -77,6 +77,7 @@ name. That seems to be the fairest way to arrange this table. | Erb | [erb](https://github.com/jeremyevans/erubi) | | Erlang | [erlc](http://erlang.org/doc/man/erlc.html) | | Fortran | [gcc](https://gcc.gnu.org/) | +| FusionScript | [fusion-lint](https://github.com/RyanSquared/fusionscript) | | Go | [gofmt -e](https://golang.org/cmd/gofmt/), [go vet](https://golang.org/cmd/vet/), [golint](https://godoc.org/github.com/golang/lint), [gometalinter](https://github.com/alecthomas/gometalinter), [go build](https://golang.org/cmd/go/), [gosimple](https://github.com/dominikh/go-tools/tree/master/cmd/gosimple), [staticcheck](https://github.com/dominikh/go-tools/tree/master/cmd/staticcheck) | | Haml | [haml-lint](https://github.com/brigade/haml-lint) | Handlebars | [ember-template-lint](https://github.com/rwjblue/ember-template-lint) | diff --git a/ale_linters/fuse/fusionlint.vim b/ale_linters/fuse/fusionlint.vim new file mode 100644 index 00000000..968e801b --- /dev/null +++ b/ale_linters/fuse/fusionlint.vim @@ -0,0 +1,41 @@ +" Author: RyanSquared +" Description: `fusion-lint` linter for FusionScript files + +let g:ale_fuse_fusionlint_executable = +\ get(g:, 'ale_fuse_fusionlint_executable', 'fusion-lint') + +let g:ale_fuse_fusionlint_options = +\ get(g:, 'ale_fuse_fusionlint_options', '') + +function! ale_linters#fuse#fusionlint#GetExecutable(buffer) abort + return ale#Var(a:buffer, 'fuse_fusionlint_executable') +endfunction + +function! ale_linters#fuse#fusionlint#GetCommand(buffer) abort + return ale#Escape(ale_linters#fuse#fusionlint#GetExecutable(a:buffer)) + \ . ' ' . ale#Var(a:buffer, 'fuse_fusionlint_options') + \ . ' --filename %s -i' +endfunction + +function! ale_linters#fuse#fusionlint#Handle(buffer, lines) abort + let l:pattern = '^.*:\(\d\+\):\(\d\+\): (\([WE]\)\d\+) \(.\+\)$' + let l:output = [] + + for l:match in ale#util#GetMatches(a:lines, l:pattern) + call add(l:output, { + \ 'lnum': l:match[1] + 0, + \ 'col': l:match[2] + 0, + \ 'text': l:match[4], + \ 'type': l:match[3], + \}) + endfor + + return l:output +endfunction + +call ale#linter#Define('fuse', { +\ 'name': 'fusionlint', +\ 'executable_callback': 'ale_linters#fuse#fusionlint#GetExecutable', +\ 'command_callback': 'ale_linters#fuse#fusionlint#GetCommand', +\ 'callback': 'ale_linters#fuse#fusionlint#Handle', +\}) diff --git a/doc/ale-fuse.txt b/doc/ale-fuse.txt new file mode 100644 index 00000000..2a84f4ec --- /dev/null +++ b/doc/ale-fuse.txt @@ -0,0 +1,25 @@ +=============================================================================== +ALE FusionScript Integration *ale-fuse-options* + + +------------------------------------------------------------------------------- +4.12. fusionlint *ale-fuse-fusionlint* + +g:ale_fusion_fusionlint_executable *g:ale_fuse_fusionlint_executable* + *b:ale_fuse_fusionlint_executable* + Type: |String| + Default: `'fusion-lint'` + + This variable can be changed to change the path to fusion-lint. + + +g:ale_fuse_fusionlint_options *g:ale_fuse_fusionlint_options* + *b:ale_fuse_fusionlint_options* + Type: |String| + Default: `''` + + This variable can be set to pass additional options to fusion-lint. + + +------------------------------------------------------------------------------- + vim:tw=78:ts=2:sts=2:sw=2:ft=help:norl: diff --git a/doc/ale.txt b/doc/ale.txt index 6edd3f74..a8244cdf 100644 --- a/doc/ale.txt +++ b/doc/ale.txt @@ -33,6 +33,8 @@ CONTENTS *ale-contents* erlc................................|ale-erlang-erlc| fortran...............................|ale-fortran-options| gcc.................................|ale-fortran-gcc| + fusionscript..........................ale-fuse-options + fusion-lint.........................ale-fuse-fusionlint go....................................|ale-go-options| gometalinter........................|ale-go-gometalinter| handlebars............................|ale-handlebars-options| @@ -151,6 +153,7 @@ The following languages and tools are supported. * Erlang: 'erlc' * Fortran: 'gcc' * Go: 'gofmt', 'go vet', 'golint', 'go build', 'gosimple', 'staticcheck' +* FusionScript: 'fusion-lint' * Haml: 'hamllint' * Handlebars: 'ember-template-lint' * Haskell: 'ghc', 'ghc-mod', 'hlint', 'hdevtools' diff --git a/test/command_callback/test_fusionlint_command_callback.vader b/test/command_callback/test_fusionlint_command_callback.vader new file mode 100644 index 00000000..5398066c --- /dev/null +++ b/test/command_callback/test_fusionlint_command_callback.vader @@ -0,0 +1,24 @@ +Before: + runtime ale_linters/fuse/fusionlint.vim + +After: + call ale#linter#Reset() + let g:ale_fuse_fusionlint_options = '' + let g:ale_fuse_fusionlint_executable = 'fusion-lint' + +Execute(The fuse fusionlint command callback should return the correct default string): + AssertEqual '''fusion-lint'' --filename %s -i', + \ join(split(ale_linters#fuse#fusionlint#GetCommand(1))) + +Execute(The fuse fusionlint command callback should let you set options): + let g:ale_fuse_fusionlint_options = '--example-option argument' + + AssertEqual '''fusion-lint'' --example-option argument --filename %s -i', + \ join(split(ale_linters#fuse#fusionlint#GetCommand(1))) + +Execute(The fusionlint executable should be configurable): + let g:ale_fuse_fusionlint_executable = 'util/linter.fuse' + + AssertEqual 'util/linter.fuse', ale_linters#fuse#fusionlint#GetExecutable(1) + AssertEqual '''util/linter.fuse'' --filename %s -i', + \ join(split(ale_linters#fuse#fusionlint#GetCommand(1)))